Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752683AbXLZWdl (ORCPT ); Wed, 26 Dec 2007 17:33:41 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751733AbXLZWde (ORCPT ); Wed, 26 Dec 2007 17:33:34 -0500 Received: from nat-132.atmel.no ([80.232.32.132]:58549 "EHLO relay.atmel.no" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751638AbXLZWdd (ORCPT ); Wed, 26 Dec 2007 17:33:33 -0500 Date: Wed, 26 Dec 2007 23:24:54 +0100 From: Haavard Skinnemoen To: Ville Syrjala Cc: Evgeniy Polyakov , linux-kernel@vger.kernel.org, Ville Syrjala Subject: Re: [PATCH] w1-gpio: Add GPIO w1 bus master driver Message-ID: <20071226232454.039372b8@siona> In-Reply-To: <1198222441690-git-send-email-syrjala@sci.fi> References: <1198222441690-git-send-email-syrjala@sci.fi> Organization: Atmel X-Mailer: Claws Mail 2.10.0 (GTK+ 2.12.0; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 863 Lines: 30 On Fri, 21 Dec 2007 09:34:01 +0200 Ville Syrjala wrote: > +static struct platform_device foo_w1_device = { > + .name = "w1-gpio", > + .id = -1, Assigning -1 to a u32 member isn't a very nice example. What does it mean anyway? > +static int __init w1_gpio_probe(struct platform_device *pdev) This must be __devinit, or if you want to save a bit of memory... > + .probe = w1_gpio_probe, ...remove this line, and... > +static int __init w1_gpio_init(void) > +{ > + return platform_driver_register(&w1_gpio_driver); ...call platform_driver_probe(&w1_gpio_driver, w1_gpio_probe) here. Haavard -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/