Received-SPF: pass (google.com: domain of linux-kernel+bounces-67670-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Thu, 15 Feb 2024 21:52:44 +0100
From: Sebastian Reichel <sre@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, 
	Conor Dooley <conor+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>, 
	Sascha Hauer <s.hauer@pengutronix.de>, Fabio Estevam <festevam@gmail.com>, 
	Pengutronix Kernel Team <kernel@pengutronix.de>, NXP Linux Team <linux-imx@nxp.com>, 
	Dong Aisheng <aisheng.dong@nxp.com>, Linus Walleij <linus.walleij@linaro.org>, 
	Dmitry Torokhov <dmitry.torokhov@gmail.com>, Mark Brown <broonie@kernel.org>, 
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 06/17] dt-bindings: soc: imx: fsl,imx-iomuxc-gpr: add
 imx6
Message-ID: <vncxxpe4ts2nybyrrgqps44eyj3t2ss63ado2pqiycpponxyy4@mhp3egl4c27a>
References: <20240213010347.1075251-1-sre@kernel.org>
 <20240213010347.1075251-7-sre@kernel.org>
 <20240215145520.GA20171-robh@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240215145520.GA20171-robh@kernel.org>

Hi,

On Thu, Feb 15, 2024 at 08:55:20AM -0600, Rob Herring wrote:
> On Tue, Feb 13, 2024 at 02:00:55AM +0100, Sebastian Reichel wrote:
> > Add compatibles used by different i.MX6 variants to the i.MX IOMUX
> > Controller GPR binding.
> > 
> > Signed-off-by: Sebastian Reichel <sre@kernel.org>
> > ---
> >  .../bindings/soc/imx/fsl,imx-iomuxc-gpr.yaml   | 18 +++++++++++++++++-
> >  1 file changed, 17 insertions(+), 1 deletion(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/soc/imx/fsl,imx-iomuxc-gpr.yaml b/Documentation/devicetree/bindings/soc/imx/fsl,imx-iomuxc-gpr.yaml
> > index 1da1b758b4ae..8451cb4dd87c 100644
> > --- a/Documentation/devicetree/bindings/soc/imx/fsl,imx-iomuxc-gpr.yaml
> > +++ b/Documentation/devicetree/bindings/soc/imx/fsl,imx-iomuxc-gpr.yaml
> > @@ -17,7 +17,23 @@ properties:
> >    compatible:
> >      oneOf:
> >        - items:
> > -          - const: fsl,imx8mq-iomuxc-gpr
> > +          - enum:
> > +              - fsl,imx6q-iomuxc-gpr
> > +              - fsl,imx8mq-iomuxc-gpr
> > +          - const: syscon
> > +          - const: simple-mfd
> > +      - items:
> > +          - enum:
> > +              - fsl,imx6sl-iomuxc-gpr
> > +              - fsl,imx6sll-iomuxc-gpr
> > +              - fsl,imx6ul-iomuxc-gpr
> > +          - const: fsl,imx6q-iomuxc-gpr
> > +          - const: syscon
> 
> A bit odd that imx6q is a simple-mfd above, but not here. I suppose 
> that could be valid if the variants here don't have sub-devices or they 
> do, but have a dependency on the parent.

These do not have sub-nodes, while the other instances have.

> Acked-by: Rob Herring <robh@kernel.org>

Thanks,

-- Sebastian