Received-SPF: pass (google.com: domain of linux-kernel+bounces-67776-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Thu, 15 Feb 2024 14:27:15 -0800
From: Andrew Morton <akpm@linux-foundation.org>
To: Juntong Deng <juntong.deng@outlook.com>
Cc: ryabinin.a.a@gmail.com, glider@google.com, andreyknvl@gmail.com,
 dvyukov@google.com, vincenzo.frascino@arm.com, kasan-dev@googlegroups.com,
 linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kasan: Increase the number of bits to shift when
 recording extra timestamps
Message-Id: <20240215142715.9c9e2c5295d90cc9c7cac4dc@linux-foundation.org>
In-Reply-To: <AM6PR03MB58481629F2F28CE007412139994D2@AM6PR03MB5848.eurprd03.prod.outlook.com>
References: <AM6PR03MB58481629F2F28CE007412139994D2@AM6PR03MB5848.eurprd03.prod.outlook.com>
Precedence: bulk
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Thu, 15 Feb 2024 18:39:55 +0000 Juntong Deng <juntong.deng@outlook.com> wrote:

> Fix the mistake before,

This is rather imprecise ;)

I shall add to the changelog:

Fixes: 5d4c6ac94694 ("kasan: record and report more information")

> I thought printk only display 99999 seconds
> at max, but actually printk can display larger number of seconds.
> 
> So increase the number of bits to shift when recording the extra
> timestamp (44 bits), without affecting the precision, shift it right by
> 9 bits, discarding all bits that do not affect the microsecond part
> (nanoseconds will not be shown).
> 
> Currently the maximum time that can be displayed is 9007199.254740s,
> because
> 
> 11111111111111111111111111111111111111111111 (44 bits) << 9
> = 11111111111111111111111111111111111111111111000000000
> = 9007199.254740

Another important thing to always changelog is the effect of the
bug/shortcoming upon our users.  So that

a) others can decide whether the issue is serious enough to justify
   backporting the fix into earlier Long Term Stable kernels and 

b) people who maintain other kernel trees (of whom there are many)
   are better able to determine whether this patch is likely to address
   a report which they have received from their customers.

Because 99999 seconds is a very long time, I am assuming that the
effect of this upon our users is basically zero, so I shall not be
adding

Cc: <stable@vger.kernel.org>

to this patch's changelog.