Received-SPF: pass (google.com: domain of linux-kernel+bounces-67839-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
MIME-Version: 1.0
References: <AM6PR03MB58481629F2F28CE007412139994D2@AM6PR03MB5848.eurprd03.prod.outlook.com>
In-Reply-To: <AM6PR03MB58481629F2F28CE007412139994D2@AM6PR03MB5848.eurprd03.prod.outlook.com>
From: Andrey Konovalov <andreyknvl@gmail.com>
Date: Fri, 16 Feb 2024 00:38:14 +0100
Message-ID: <CA+fCnZc4huzB4e1vdmxYa-3fFQadO6j7ZTCAvcRV52LPNWbYow@mail.gmail.com>
Subject: Re: [PATCH] kasan: Increase the number of bits to shift when
 recording extra timestamps
To: Juntong Deng <juntong.deng@outlook.com>
Cc: ryabinin.a.a@gmail.com, glider@google.com, dvyukov@google.com, 
	vincenzo.frascino@arm.com, akpm@linux-foundation.org, 
	kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Feb 15, 2024 at 7:41=E2=80=AFPM Juntong Deng <juntong.deng@outlook.=
com> wrote:
>
> Fix the mistake before, I thought printk only display 99999 seconds
> at max, but actually printk can display larger number of seconds.
>
> So increase the number of bits to shift when recording the extra
> timestamp (44 bits), without affecting the precision, shift it right by
> 9 bits, discarding all bits that do not affect the microsecond part
> (nanoseconds will not be shown).
>
> Currently the maximum time that can be displayed is 9007199.254740s,
> because
>
> 11111111111111111111111111111111111111111111 (44 bits) << 9
> =3D 11111111111111111111111111111111111111111111000000000
> =3D 9007199.254740
>
> Signed-off-by: Juntong Deng <juntong.deng@outlook.com>
> ---
>  mm/kasan/common.c | 2 +-
>  mm/kasan/report.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/kasan/common.c b/mm/kasan/common.c
> index 6ca63e8dda74..e7c9a4dc89f8 100644
> --- a/mm/kasan/common.c
> +++ b/mm/kasan/common.c
> @@ -55,7 +55,7 @@ void kasan_set_track(struct kasan_track *track, depot_s=
tack_handle_t stack)
>         u64 ts_nsec =3D local_clock();
>
>         track->cpu =3D cpu;
> -       track->timestamp =3D ts_nsec >> 3;
> +       track->timestamp =3D ts_nsec >> 9;
>  #endif /* CONFIG_KASAN_EXTRA_INFO */
>         track->pid =3D current->pid;
>         track->stack =3D stack;
> diff --git a/mm/kasan/report.c b/mm/kasan/report.c
> index 7afa4feb03e1..b48c768acc84 100644
> --- a/mm/kasan/report.c
> +++ b/mm/kasan/report.c
> @@ -267,7 +267,7 @@ static void print_track(struct kasan_track *track, co=
nst char *prefix)
>         u64 ts_nsec =3D track->timestamp;
>         unsigned long rem_usec;
>
> -       ts_nsec <<=3D 3;
> +       ts_nsec <<=3D 9;
>         rem_usec =3D do_div(ts_nsec, NSEC_PER_SEC) / 1000;
>
>         pr_err("%s by task %u on cpu %d at %lu.%06lus:\n",
> --
> 2.39.2
>

Acked-by: Andrey Konovalov <andreyknvl@gmail.com>