Received-SPF: pass (google.com: domain of linux-kernel+bounces-67865-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Thu, 15 Feb 2024 15:55:57 -0800
From: Andrew Morton <akpm@linux-foundation.org>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Michal Hocko
 <mhocko@kernel.org>, Mel Gorman <mgorman@techsingularity.net>, Matthew
 Wilcox <willy@infradead.org>, Mike Rapoport <rppt@kernel.org>, Pasha
 Tatashin <pasha.tatashin@soleen.com>, Kent Overstreet
 <kent.overstreet@linux.dev>, Michal Hocko <mhocko@suse.com>
Subject: Re: [PATCH v2] mm: document memalloc_noreclaim_save() and
 memalloc_pin_save()
Message-Id: <20240215155557.93b23f4a69c6062e7878ed14@linux-foundation.org>
In-Reply-To: <20240215095827.13756-2-vbabka@suse.cz>
References: <20240215095827.13756-2-vbabka@suse.cz>
Precedence: bulk
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Thu, 15 Feb 2024 10:58:28 +0100 Vlastimil Babka <vbabka@suse.cz> wrote:
>
> ...
>
> v2: fix issues that Mike pointed out

Cool.

> sending as replacement instead of fixup because I've used the wrong
> address for Kent and it became part of Cc: tag in the mm tree.

akpm has editor ;)

> + * This function marks the beginning of the __GFP_MEMALLOC allocation scope.
> ...
>
> + * This function marks the beginning of the ~__GFP_MOVABLE allocation scope.

pet peeves.  We can assume that the reader knows that this is a
function!  Perhaps we should teach checkpatch to whine.

Like "the function foo" and "the function foo()" in changelogs. 
"foo()" is enough!