Received: by 2002:a05:7412:1e0b:b0:fc:a2b0:25d7 with SMTP id kr11csp820076rdb; Thu, 15 Feb 2024 17:17:03 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWiP59aSonzFmGyivizqHAYn43zkG9bzP3uY3w2azAavj6RP6P0hvTY4sqjIcRPmO+1Oj/63ckSRzHDAAP39izTxE0xb9MyVDGnoKTgYg== X-Google-Smtp-Source: AGHT+IFiNbJRoz9bQQhniVAV2o3IU2/Dwjz5oz/Jl1trfVCCEwvaLfJTfi9OMBX7BKy/Ng055Eaz X-Received: by 2002:aa7:84cf:0:b0:6e0:ef5c:b103 with SMTP id x15-20020aa784cf000000b006e0ef5cb103mr4449629pfn.6.1708046223512; Thu, 15 Feb 2024 17:17:03 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708046223; cv=pass; d=google.com; s=arc-20160816; b=xun2lWJPwd3Nv6jdSSDzCGdsKda30fXlppKg1hdPFcV35Hl+15W3QoL6kfTN6VO9Ns 6Mm6Jo8mjOaY/Bnf7Ux4Ncx+JxdZvQvbRycju1Wps9YH3d/yDu2BfRnQ/Cll/iLLH9Hc 0S+N05Np7Wj8JGF6qNsSCHNNBNxi+f6h1mhShtbEkSxKVm01WYYcMnkGhc6UZDoFIrKf aoa2MsLi+B1fxgFqIQJTBU3cnXC5845LDJjMN9PCryU8lF9jsybBpmKzOEOaXpa6gT9L oJ5Wc2gIPedPNn6w3ItXd5PUGhb0MrmhNKkaSlUuaIZkpU9vFtAvXZASkn3Uz8+19bIA 5rdQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=V0/5eEMUdgTFVPz51GyIaKKFky9Useu7YxYIgUjehmU=; fh=RvA/OOymTsXBr3aTFcJ8XM+5UeHuv+xv8J5QIPXddic=; b=Sw7Y7Rza7mHBMJqD9HGwoUtuH1luDouxMmYoVY8vpvhTrSr3evErb8R93nm3JA3bQX ll2Igm7A+Tud+5IdSanvD4tAaUJUlWb9NA4VnudDOMNLUDlni59bf3/7uB+ESH0p+wQw vibkbEZLPUI7BL9dwq9wRCYErktDmSpiSLGlYTwygPMRH4hGPmrAfeMQ4b6SqgXo8G5I fHZoUhNJRoi/z04u90wgLWD0k3rpp5oFfdnb6kR7cJzAn8qbJ5k43sVsAm9ErR/I5ZTe Zw+rDbOJTs8AjW16UGM/Zj69HIDGkcyi6Vj+wB2IL1Clg+8tb1lcayQPtMy4y/4ZTGE0 n7Rw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b="fiTTd/46"; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-67937-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-67937-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id l64-20020a639143000000b005d8e352afefsi2023255pge.695.2024.02.15.17.17.03 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Feb 2024 17:17:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-67937-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b="fiTTd/46"; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-67937-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-67937-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id DB21928284D for ; Fri, 16 Feb 2024 01:16:58 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4721AD515; Fri, 16 Feb 2024 01:16:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fiTTd/46" Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DAA11D267; Fri, 16 Feb 2024 01:16:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708046212; cv=none; b=DJXL3P8yVaEpwlJ6BJ34O5TNE42NfFhjg5M1yFnVxx9lv3UhU1JJLXsoVagAueVHqLSd4jFcVS8cTeH5M6lAgVUNKvNm4ZNYId6jCUnVOfzd4m9Q8tZ/APqG72Mloi5KaIAoLciNrcAQmjCNrrNiG7PxXvYVUWK9iTPMcVXekSs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708046212; c=relaxed/simple; bh=V+ZtxNTTkmuOF/6gVBMGVUleC+8v+tJPdfpHWcvscao=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UPBtXvazQj2yyUL8EngEILbzrZBSschLh6f2c/81L6qWntkzSwovK6u6UKWeLMPIWAFBeYzI1nJ4H2LV5yHO9Eno3qfNaaD1NIRbkzrDNeEREkaF2UvSlH4uqfYPJQDPjbP1PSNboX+aoZXyz+p59hZ+njYIs3BVK5bPsK3EzW4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fiTTd/46; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-3392b12dd21so787804f8f.0; Thu, 15 Feb 2024 17:16:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708046209; x=1708651009; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=V0/5eEMUdgTFVPz51GyIaKKFky9Useu7YxYIgUjehmU=; b=fiTTd/46tjvShtJcJsgg4VMCIF5L9Yk4N/aMZnTAwphzrvxbC+3/WtPTMrXZrlCuPn jX7YH680OEGO3ZMI+x45oDznxenH3SRkOwVxWQckCMPCJmka9O77p+h1QI5ROhPaE66a O3OtotHmWjemOlZLfy2iLWy5nevqq+s/+B+rMySEG5ShW4LWxL2jq3PMCwu43TW9qQKH V5wG6u31jfQNF+peBKuVB2shyC/fF5+et4a5shVytnruNsTCvXfaTIjY+by1JPgxtSkQ h4qFTuUc/tBpBGdhvMwF+Vb4ySLSyIrAeuKbsbNUoqTF08TrGeB7zlaa3Kl8G1hlxpt3 D2Cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708046209; x=1708651009; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=V0/5eEMUdgTFVPz51GyIaKKFky9Useu7YxYIgUjehmU=; b=PZ3wgHH0eubnnfTDaJHNm53Dj2Esm2HJ5KM6C8jneb+mj8wVmSbdN8oChUsyvn4J7m SGu12t728LEvptchbvwDz7n/qMwJx9UJZtjgoRIDGrSGpWKYBpuZ7Q3RZ/GFqC6y4wNV QBzr7Rqx8U4UCmieaJcxyM2OXhVNUJeH67evemUfh+WBDmxa5XFSdi2IlHvwyF0CNLiQ 8G5v3ommnIDeamJnaUUnyrBtOI+v98/nXCVnVTZq4siSihLTdjvF9aHiqrL+X9c4wYcY Ole9mqG9v9nrMqNjK2IbyOW9t8gqYNFXHLoDZJwoLF3sAwsS+EUlL3MIEOaF638cY/6Y kuVQ== X-Forwarded-Encrypted: i=1; AJvYcCVnh0jvhifEXZ3DeXSa0ZwmCI8aELcQt6uIyx+t0kY3tLohqDlyAhU2s9psg0CTXki6P/4p5+lpraSyfXEuE5Gq6PYQsmT266iz58QcUHDoOiRd+pnodR+gmfQcszqLSisa5kUlxwB5Q5X9Gu6W+fdx6hBJh2l3+UQywxLIzedZgQ== X-Gm-Message-State: AOJu0YzYZdqd5QX5EXPVi2cJTTg/85T2onFWnKs5AsshR/jOGcA7lsXO IB2hrDtzuOGsTxR3THG96ru/vVJ+XXBZakUiKx/eYoJN1ASf75Br X-Received: by 2002:adf:ff8c:0:b0:33a:eb5b:f8cd with SMTP id j12-20020adfff8c000000b0033aeb5bf8cdmr2686949wrr.7.1708046208844; Thu, 15 Feb 2024 17:16:48 -0800 (PST) Received: from skbuf ([188.25.173.195]) by smtp.gmail.com with ESMTPSA id j27-20020adfb31b000000b0033cefb84b16sm645021wrd.52.2024.02.15.17.16.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Feb 2024 17:16:48 -0800 (PST) Date: Fri, 16 Feb 2024 03:16:46 +0200 From: Vladimir Oltean To: Luiz Angelo Daros de Luca Cc: Linus Walleij , Alvin =?utf-8?Q?=C5=A0ipraga?= , Andrew Lunn , Florian Fainelli , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v3 3/3] net: dsa: realtek: support reset controller Message-ID: <20240216011646.yri2ecvuetxbgkhp@skbuf> References: <20240213-realtek-reset-v3-0-37837e574713@gmail.com> <20240213-realtek-reset-v3-3-37837e574713@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Feb 14, 2024 at 07:17:55PM -0300, Luiz Angelo Daros de Luca wrote: > > > The reset controller will take precedence over the reset GPIO. > > I'll remove the "ifs not null" and let both be called. If you do, be sure to update the commit message about it (see first line).