Received-SPF: pass (google.com: domain of linux-kernel+bounces-67962-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <fe77c42c-7a61-49ee-b729-abc87ae6e352@intel.com>
Date: Thu, 15 Feb 2024 18:05:03 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [RFC PATCH v2 0/4] tsm: Runtime measurement registers ABI
To: Dan Williams <dan.j.williams@intel.com>, James Bottomley
	<James.Bottomley@hansenpartnership.com>, Kuppuswamy Sathyanarayanan
	<sathyanarayanan.kuppuswamy@linux.intel.com>, Dan Middleton
	<dan.middleton@linux.intel.com>, Samuel Ortiz <sameo@rivosinc.com>
CC: Qinkun Bao <qinkun@google.com>, "Yao, Jiewen" <jiewen.yao@intel.com>,
	Dionna Amalie Glaze <dionnaglaze@google.com>, <biao.lu@intel.com>,
	<linux-coco@lists.linux.dev>, <linux-integrity@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
References: <b8140cc8-a56b-40f6-a593-7be49db14c77@intel.com>
 <fe1722c3618a8216cb53b8fd3f1b7cbb6fdff5a0.camel@HansenPartnership.com>
 <65c2e4aa54a0_d4122947f@dwillia2-mobl3.amr.corp.intel.com.notmuch>
 <22088ed3-51a4-415f-932c-db84c92a2812@intel.com>
 <527da630-4952-4b1d-80c0-5a87997ff9fd@linux.intel.com>
 <332775d7218843d6cc168c963d76e6841eab5d5b.camel@HansenPartnership.com>
 <65c691e13a50d_afa42948a@dwillia2-xfh.jf.intel.com.notmuch>
 <226df539-b3f4-4099-b6a6-293fa200c536@intel.com>
 <982e19fcd71c41a162ba664281eb0a68d9dc960c.camel@HansenPartnership.com>
 <ef770532-6db6-4262-8225-2d3ee09b7d23@intel.com>
 <65cdabb4be63a_5c7629420@dwillia2-mobl3.amr.corp.intel.com.notmuch>
Content-Language: en-US
From: "Xing, Cedric" <cedric.xing@intel.com>
In-Reply-To: <65cdabb4be63a_5c7629420@dwillia2-mobl3.amr.corp.intel.com.notmuch>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V0pFcnZ5ZFF0cFdsUVhOWFJ2aWhWNWQ1ai91UEZUNEQ5dEpFdXNBTlBCcXBY?=
 =?utf-8?B?WjJQMEhYYjNGRUdFU0RmNUNtendjSW9Mbjkrb3pKV2hzVC9yOUpDQ1c4WVRx?=
 =?utf-8?B?WG9EckxYZWg1bzV5N3hiam1OdFd2K0VaL2trY0JSdmJBOTV6bFdsajNvUElP?=
 =?utf-8?B?VFk0UXNGY2l6Uy9qaUdsVEhhZ0QvNHNDYXp3bE16UktnMjNHaTltMWU4N3JW?=
 =?utf-8?B?K1dFR0czQWhhOXBMaVRyTHFyQUZIYmlFbjlPZlNoZDI3cXpVNHpIYllZNUEw?=
 =?utf-8?B?U1c3VnR3NEl1UngvTWVuMHVhNllVWlVTZ0Vjd2J4MEVGQytaMTh1SWNzWndD?=
 =?utf-8?B?U0pGQndIV1RWcWdBem91bnNXQXJXK2d5SDhCaFdjOWdwNEZ4WERRM0dEK0NR?=
 =?utf-8?B?QmJHRCtKTVcySnZSRFFkOHpuUENtQTRFa2pVTG1HTW9wejlDOE9aWUxLVmE2?=
 =?utf-8?B?Z2gvMVpFY0dod2xJbFVCRGtwOE9aeEtsVmJFWFNydFRjMXUzV21NYzFBdDdW?=
 =?utf-8?B?bWYvMU9TaXA3SHR4WVpsRlVVeEhmRDlBQzlwSFBqRFZDUWdNS2NDMUhGbkVL?=
 =?utf-8?B?TnpybDZ4NU5JdGNMbG1wQmFaOXBZQVI5aGFTYXQ4UFNYQ2RQbVpKWXRScDlu?=
 =?utf-8?B?K3JXUWk2N09JY2Jaa0xMSEpsSVc4OFB4dlFTLytheWZ0YmE5T041TnphUmZj?=
 =?utf-8?B?T1lOSHg3SEFSYjZPRkkzc254TmFtbEo5VldVSkpjN1U1ZXJySGZnQXJ0KytS?=
 =?utf-8?B?VWpKQzN4VlFPM2VaQmw2eGhXUFMvNFRacllNUWJTdVJRMTFmdUY2R1RFMU0y?=
 =?utf-8?B?ZWRLMEdKZWpZT2YyaXRNT3FWYWVCU1RlZ1o0ano0a1hPbTRXTTlTMFJoZTVa?=
 =?utf-8?B?cjJrNC95cGJaZjNlZVNISTZxQlROYzRFLzZLL3FBdmhCV2M5S1dGc2ZGUEFM?=
 =?utf-8?B?Uy9ZTlQ1WmVSNmt5Sk9FOHFnLy8va00zb3pnWGJwVGVWeXFQWUZvTGFYTWlw?=
 =?utf-8?B?NlN1cTVxVDNocW95cmExWTlhQjlqZXIwd2RVeUphY3hneERWZVgzRkEvUWRo?=
 =?utf-8?B?Rm9hdEFLYlZ0L1JhY0c4Ym1rQXJJV2ppYWkxNERsbGNKS1grYlU4UlpCbC9k?=
 =?utf-8?B?RVpGazRUeWR2TzVneXlSYUtmYWN0QklxeFlWODdNSWlWcE9NRVpHMHdVOXpv?=
 =?utf-8?B?VnpPcCtmNTc4dmVGMlF3UGR2WlBDMlJTWWtHNVhQcWJ2SVJIK3cwbFg2RVc2?=
 =?utf-8?B?cWM5aFZwcXllTnZnL1Y1eTJoQ1hVYUFWK1YyU2RGWnZaSXNRQVVrY2ZKL0lr?=
 =?utf-8?B?c3E4a2hwdWFCQmJnd0IzSTJpZHI5bGc4T1hOSWJ6VUdXWEFWeXAyMUhHTk9v?=
 =?utf-8?B?WVA4QmlmR001b25ZLzdMMWxaMVR3MTAyUEt4OXhMYm4zQzFzUVY5VWM4aXlq?=
 =?utf-8?B?T0ZjRmY2SDNXRkQ3SE9qRkgzUjBtNnF6Z0ozT1BhMjF2RzcyK3VSZXEyWVpT?=
 =?utf-8?B?TE4wVjlnbzAvTTFSZnl6SFhCS1hOWXM2WU9nYk54ZjhXSTlhZjJHRlNyTkd4?=
 =?utf-8?B?K1lEUG1qU0owSVZXOWZUSmxQLzVMM2p0N3dvaXdIKzM2d2ljVXpoYXloSDhZ?=
 =?utf-8?B?dWp0TnlRSndWOWw5ckZ2THBodzZHNnhoOGs2cWF4RlExWVhibzNqWkE2UC9V?=
 =?utf-8?B?aWh6VTFGd3pnTlBlNlBiM2luRVFWNEYvTElDQjYvZjlKczNWa1JRQ21vRkNX?=
 =?utf-8?B?RjcrbG9PRy9EbS9PcDBCT2x3RXNSc0tmUllQTWJLd1k4UHhnWUx2T1lrUmor?=
 =?utf-8?B?ejlteXdPT1dTeWVQSlZhcGhRTkJ5allqUDFHdzRXck5WMkJSYXVNMkNBcTZ4?=
 =?utf-8?B?aWNNVG56MENIWFdRNVE0bVhMQXNEQ1VSY3hCQ2tJR1ZvM3hsZjc3eEE4bkVT?=
 =?utf-8?B?YzZWQVJvY0NzWUN2b2x5SHZOU3h6OWNHdTQ0ODdRbVNvNG5FWTNKamRQZlZQ?=
 =?utf-8?B?TCtuZk9JK3pNdFhFcGhBRFYrMGk3Z1AxVWVJemdXUEE4SnRqWUhiVXZ4cCtu?=
 =?utf-8?B?bXluUXg5K3NYOHc1QUVpRFlHbFZKbi9pKzdwc1MxNDZ6TTlSUHl2cTFyeTlB?=
 =?utf-8?Q?VEG8xdP07xYONbYKVz2X942dF?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 60f92834-77f2-49eb-6cd6-08dc2e93b23c
X-MS-Exchange-CrossTenant-AuthSource: DS7PR11MB6269.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2024 02:05:06.6995
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: s4f2JU4cmTy6mn+uAjMcHdIF0KHXVwJNJhQWUgoic+riHjEDmS5ZoIUOZI/ztHmBL+4pOz+IdbQiZZDURl2/9A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB5968
X-OriginatorOrg: intel.com

On 2/14/2024 10:14 PM, Dan Williams wrote:
> Xing, Cedric wrote:
>> On 2/13/2024 8:05 AM, James Bottomley wrote:
> [..]
>>> The TCG crypto agile log format is
>>>
>>>    index (32 bit),
>>>    event tag (32 bit),
>>>    digests array,
>>>    sized event entry (up to 4GB)
>>>
>>> So an IMA log entry can definitely be transformed into this format
>>> (providing someone agrees to the tag or set of tags).  The slight
>>> problem would be that none of the current IMA tools would understand
>>> it, but that could be solved over time (the kernel could use the TCG
>>> format internally but transform to the IMA format for the current
>>> securityfs IMA log).
>>>
>> Hi James,
>>
> [..]
>> Another problem of CEL is that NOT every byte of an event is
>> hashed/extended. CEL spec has defined for each "content_type" the subset
>> of bytes to hash, so a verifier must understand ALL content types to be
>> able to verify the integrity of a log. In other words, the integrity of
>> a "systemd" log can never be verified by a CEL conformant verifier.
> 
> Wait, James said, "crypto agile log format", not CEL. Crypto agile log
> format looks more generic, no "recnum" for example.
> 
If I'm not mistaken, "crypto agile log" refers to the same format as 
"TCG2 log". It's "crypto agile" because it allows a plurality of hash 
algorithms/digests (specified in the "digests" array) to be extended to 
one PCR - each algorithm supported is called a "bank" of the PCR.

CEL is also "crypto agile". I'm not familiar with its history but it 
seems emerged after the TCG2 log format, as CEL's information model is a 
superset of TCG2's. Specifically, CEL's information model covers 3 
applications - "CEL management" (owned by TCG/CEL), "PC Client STD" 
(owned by TCG PC Client WG and equivalent to TCG2 log), and IMA. 
Supporting any new applications would require expanding CEL's 
information model - i.e., by changing the CEL spec.

> [..]
>>>> IMHO, we don't have to follow TCG2 format..
> [..]
>>> https://xkcd.com/927/
>>>
>> That is funny :-D
>>
>> I can't agree more, so "no log" I think is always an option.
> 
> So to me, "no log" means that instead of going from 14 standards going
> to 15, the kernel is saying "whee, infinite userspace log formats!", an
> abdication of its role to support a stable application ABI.
> 
If we look at how CEL is defined, it separates information model from 
encoding. Information models have to be contextualized within specific 
applications, but encodings don't. The reason for 14 standards is 
because there are 14 different applications. The 15th may be able to 
combine the existing 14 into a single one, but probably cannot 
accommodate the 16th.

So I think the only practical approach is to abandon the information 
model and focus on the encoding only. For example, JSON is just a set of 
encoding rules without an information model, hence can serialize data 
for all applications.

Coming back to the TSM log, the real question is: Can we just specify 
the encoding without an information model? The answer is yes and no. The 
kernel does need to know something, such as what to log, what to hash, 
and extend to which MR, but does NOT need to understand anything else 
about the event. So a potential ABI definition could be:
   - Take the MR index and an *encoded* log entry as parameters from 
user mode.
   - Hash the whole entry as-is using the same algorithm as used in MR 
extension, and extend the resulted digest to the specified MR.
   - Append the whole entry as-is to the log file.

The key difference between the aforementioned and CEL is that the former 
takes the *encoded* log entry as a single input to alleviate the kernel 
from the necessity of comprehending the logger's information model.

> The job here to define a kernel de-facto standard for the tags that this
> configs implementation of a cryto agile log emits, right? As James says:
> 
> "(providing someone agrees to the tag or set of tags)"

I don't think we should define any tags because that can only be done 
for existing applications but can never address the needs of future 
applications.

We don't have to maintain a log. The existing TPM module doesn't 
maintain a log either. systemd on the other hand is an example of 
keeping measurement logs in user mode.

But if we agree that a log is indeed necessary, I'd recommend the 
aforementioned approach. We can then focus discussions on the options 
for encoding log entries.