Received-SPF: pass (google.com: domain of linux-kernel+bounces-67968-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Thu, 15 Feb 2024 21:15:23 -0500
From: "Liam R. Howlett" <Liam.Howlett@Oracle.com>
To: Dave Hansen <dave.hansen@intel.com>
Cc: Rick Edgecombe <rick.p.edgecombe@intel.com>, akpm@linux-foundation.org,
        debug@rivosinc.com, broonie@kernel.org,
        kirill.shutemov@linux.intel.com, keescook@chromium.org,
        tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
        dave.hansen@linux.intel.com, x86@kernel.org, luto@kernel.org,
        peterz@infradead.org, hpa@zytor.com, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 1/8] mm: Switch mm->get_unmapped_area() to a flag
Message-ID: <20240216021523.xb2q35kdchwdk4vh@revolver>
Mail-Followup-To: "Liam R. Howlett" <Liam.Howlett@Oracle.com>,
	Dave Hansen <dave.hansen@intel.com>,
	Rick Edgecombe <rick.p.edgecombe@intel.com>,
	akpm@linux-foundation.org, debug@rivosinc.com, broonie@kernel.org,
	kirill.shutemov@linux.intel.com, keescook@chromium.org,
	tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
	dave.hansen@linux.intel.com, x86@kernel.org, luto@kernel.org,
	peterz@infradead.org, hpa@zytor.com, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
References: <20240215231332.1556787-1-rick.p.edgecombe@intel.com>
 <20240215231332.1556787-2-rick.p.edgecombe@intel.com>
 <acac6cc8-fd83-4541-8310-63f37cd41fa6@intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <acac6cc8-fd83-4541-8310-63f37cd41fa6@intel.com>
User-Agent: NeoMutt/20220429
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?vGmHczr6WdGcYO3j3mHK03rrzfjt2OAvkvV5rpMMfx9SiVyZIvg+Lur2Jo1R?=
 =?us-ascii?Q?qnMv30MGVmf3mlxrQKeFTsylbGyoSFXfZZfZ2397UDGjVycLQfPyuA2kskwP?=
 =?us-ascii?Q?s1rRoQrVuyjKo6VkgbhlSOAmsYbQ2NwTiYkqNINWLjdEpEHxCDr2igPEsuf6?=
 =?us-ascii?Q?lcJ2RT5EQQTe2fxTENAnXNiDNMaC1g0uQn0haW7NMo4sBfrPsPMVPDho7TTV?=
 =?us-ascii?Q?xoEMOTHBk0/eTkWfs+ULUdiJ2TXjYOhZLpNs/vWszZK6lTmqGaOZfOy1u75Q?=
 =?us-ascii?Q?ZgRi7P0EvIcPn46Ao2nckVsrdec/ebNW7qjDAxVkZ7muyhE68haDVp8oBOYb?=
 =?us-ascii?Q?ipek1keMIQ6cDiHAEiNkJtm9jOXJqz7OwArYIqdp7Q0lzaH6q9TVwWwsL7Ec?=
 =?us-ascii?Q?MQEJUkloLp7uwoy5VP9E26s77EsksBGBrDFhBYDq6KveZKLifG8fIhv7T6Pb?=
 =?us-ascii?Q?ctnGpAZPPzgwablROi6OrzsVwBa0GDL39jSXhJagYLyj128czoBlaBbrC7gF?=
 =?us-ascii?Q?zZAvL46g5M68zml20nQezFCQ9n97Ca0arg/HoLweUwK6PcmRGnwT7wqf88AP?=
 =?us-ascii?Q?3yKNA2/bwtHQsvRoZIwRdrg7kTD2w9ViU+jSeUP2CyZKQYRY5u2IANS1QM9A?=
 =?us-ascii?Q?5fhy8rHEH9xnYL0ZKXefAeRg8SqhMYZjMuyueqIFdBL05iF6ZCYoprZRNf8u?=
 =?us-ascii?Q?i2twehqbLmPlXfT/ZDR2PDy2lKQMADSJkbtwMPVfV9cy346Kb9KnH/n7zobW?=
 =?us-ascii?Q?xEOl4eANJA6lyM6f/4ePNRAgWQmEeRIU98lXJJU6FgYfzHVvgFv4Y3vaAeLP?=
 =?us-ascii?Q?mSgXXhoCF6coDVhTumx1/8FfFKSzxSMiBB4jTwDtrr1eKPo0350BWkwVTQ4+?=
 =?us-ascii?Q?27XjXn9kgJlo9fHuirNylIhxtXWVg1vRJYgdTuGZ+xpfhG6cKLSz6L3HlEy0?=
 =?us-ascii?Q?jpCwM7kop8PTCt/bahyYi0UtOPVIIIpgCtkpUZwH4hX6mIofG4zBmb0gsyr4?=
 =?us-ascii?Q?qtI0k1pkzEoOrstRS3Soq8zzWbvYBp9qkD7eaqEgim3BDe2uEJww27d0PavV?=
 =?us-ascii?Q?w1AFhrJIty0TL3tEMONX8jBrRiAS6Au54CuEVBX1pTQQFCNdul7FB89RpCtI?=
 =?us-ascii?Q?LF3eLQP3wASMSasP5Wto9Rv6cFocvOruhC0jEl/zmC8t8DcUNu/MQ5oV7P3j?=
 =?us-ascii?Q?6clMap15gE0sNxPACd2O62An9ZYub85HJ5u2M0k+5ol+N1qvtMJRRbaGNEUp?=
 =?us-ascii?Q?XS/zh1Fuv6okOAyJLrcmjODNpZKs6r/P9ItfOY206mn7JlYQBWlc7Oa6VEZA?=
 =?us-ascii?Q?7c/ccZsQH8k/51XIO4/w6tH0ohQ6cdhITVOVZotUr3Jmin+MLJUCnIRyvxqI?=
 =?us-ascii?Q?ZuRZiWWgykwpq9ycKWKtj9MrpavKR5trzBZKF/DAYlR/64nRNORlZkVBCqMQ?=
 =?us-ascii?Q?r9/xQ/wKggR4WF6uLKGKUZ/cQgL0tYTniMF/MdsIFJg735VNId1SYm+oFdEa?=
 =?us-ascii?Q?zHppxFxgTMauEEzEC7izQ0FFq8JXKdP4i7dOhwYttGeYhAcsJzOJkwO07xGC?=
 =?us-ascii?Q?U9YISaBOcLCofpOwrrbn3CAo01ELlsjIskuM0AJR?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	uKQm5MDfaW7e2TmifYgWJO8XJEm1fxOY4790Io3tFFPNZsFnGii2Kdl9BY87JQOfMMJNlJnrLHOvQzZa1NjSABgIEr91ThpVZQbaKtlCBpc2zIqgwpRwFxLwTemADyGb39VdIO8Xi9+eXNqJQ9ylYvzonz98R3kOjnTz7tJzWonVimfBndcremCHruCOAfRp4fx5sF08kL703gVj1R2tFgABuHbvCQSWVWiAfZB0VNMPcgTe17BUXlqVIUF2/2VOXNfFDSoQgO27RFuWG6G5cH5WRof0bbcDL44W1P0+KGC7ppQJmRbxa0K2CNQmQZzmINdO4XBQHrOhmIz1AI9erHfgRF2MYBlXrY2XfJGY+iTlEEibbKIGu3zd1I2svsNz8Txa6wptKDjagvvcgfGSuJvCp4hZK53gOnKU56ALK4q++a9r2SjTHaygTBHObv7EkKcwn+RDQ+POc+AbNKhzYCnHxcULvLPXSjpSS/COaow9DBC5HVTcp/m/kQa/rbSfMK789AqyspdwyTK2DDYC68S151WwbxwmgUJd2nw4ViOQKuSrMmEiCIzXWpyiZZb1rFBTKNbiWQsPnSVwNQV9GcFW+HNOGCkzjDeNwWooCT8=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 13496501-0eb7-4db5-5eaf-08dc2e9522ff
X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB7933.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2024 02:15:25.3512
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dUQlu7GHIR0KftShwRKjozRAa4ke0LWljYWjEJT5oU7pdCkXET40Mw5wvVvN0GF5Bq4Zvh24X80ugbidCsWJAw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR10MB6622
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-16_01,2024-02-14_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxscore=0 spamscore=0
 adultscore=0 phishscore=0 bulkscore=0 mlxlogscore=619 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2402160015
X-Proofpoint-ORIG-GUID: PnHu0ljv_RQAoqEm0j-PNGUKR1ehIywC
X-Proofpoint-GUID: PnHu0ljv_RQAoqEm0j-PNGUKR1ehIywC

* Dave Hansen <dave.hansen@intel.com> [240215 19:30]:
> On 2/15/24 15:13, Rick Edgecombe wrote:
> > The mm_struct contains a function pointer *get_unmapped_area(), which
> > is set to either arch_get_unmapped_area() or
> > arch_get_unmapped_area_topdown() during the initialization of the mm.
> > 
> > Since the function pointer only ever points to two functions that are named
> > the same across all arch's, a function pointer is not really required. In
> > addition future changes will want to add versions of the functions that
> > take additional arguments. So to save a pointers worth of bytes in
> > mm_struct, and prevent adding additional function pointers to mm_struct in
> > future changes, remove it and keep the information about which
> > get_unmapped_area() to use in a flag.
> 
> Indirect calls are just all kinds of evil, especially when Spectre-v2 is
> in play.  This is a really good idea.
> 
> Acked-by: Dave Hansen <dave.hansen@linux.intel.com>

Yes, this change can stand on its own I believe.

Acked-by: Liam R. Howlett <Liam.Howlett@oracle.com>