Received-SPF: pass (google.com: domain of linux-kernel+bounces-67975-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: =?utf-8?B?7J207Iq57Z2s?= <sh043.lee@samsung.com>
To: "'Greg KH'" <gregkh@linuxfoundation.org>
Cc: "'Ulf Hansson'" <ulf.hansson@linaro.org>, <linux-mmc@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <avri.altman@wdc.com>,
	<grant.jung@samsung.com>, <jt77.jang@samsung.com>,
	<dh0421.hwang@samsung.com>, <junwoo80.lee@samsung.com>,
	<jangsub.yi@samsung.com>, <cw9316.lee@samsung.com>,
	<sh8267.baek@samsung.com>, <wkon.kim@samsung.com>, <sh043.lee@samsung.com>
In-Reply-To: <2024021531-speech-lifting-89f6@gregkh>
Subject: RE: [PATCH] mmc: sd: Add a variable to check a faulty device
Date: Fri, 16 Feb 2024 11:26:38 +0900
Message-ID: <015301da607f$92332770$b6997650$@samsung.com>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQI2QrZr/hQwBfLmGOt++EZEApv72gJjevE2AeL7/EgCVM+otwGWv7XmATRrRiUCPo8fJ6/3SnSw
Content-Language: ko
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 101P
DLP-Filter: Pass
References: <CGME20240213051332epcas1p1f45d02dc34d1b95ea5608ab779d6b6cc@epcas1p1.samsung.com>
	<20240213051716.6596-1-sh043.lee@samsung.com>
	<CAPDyKFrjZ4jRHAfXsvrEvezuHTxbA3SAniF8CuObyLuW=AUoeA@mail.gmail.com>
	<000001da5faa$d34e1600$79ea4200$@samsung.com>
	<2024021528-fretted-sustainer-2ebc@gregkh>
	<000001da6000$527c8650$f77592f0$@samsung.com>
	<2024021531-speech-lifting-89f6@gregkh>

> -----Original Message-----
> On Thu, Feb 15, 2024 at 08:15:45PM +0900, =EC=9D=B4=EC=8A=B9=ED=9D=AC=20w=
rote:=0D=0A>=20>=20>=20Subject:=20Re:=20=5BPATCH=5D=20mmc:=20sd:=20Add=20a=
=20variable=20to=20check=20a=20faulty=0D=0A>=20>=20>=20device=0D=0A>=20=0D=
=0A>=20Does=20this=20really=20belong=20in=20the=20body=20of=20the=20email?=
=20=20You=20might=20want=20a=20nicer=0D=0A>=20email=20client=20:)=0D=0A>=20=
=0D=0A=0D=0AIt=20was=20caused=20by=20unfamiliarity=20with=20upstream.=20Sor=
ry=20for=20the=20inconvenience.=0D=0A=0D=0A>=20>=20>=20>=20The=20variable's=
=20usage=20is=20expected=20to=20be=20used=20through=20the=20sysfs=20node=0D=
=0A>=20>=20>=20>=20in=0D=0A>=20>=20>=20the=20vendor=20module.=0D=0A>=20>=20=
>=0D=0A>=20>=20>=20What=20=22vendor=20module=22?=20=20You=20need=20to=20inc=
lude=20all=20of=20the=20needed=20code=0D=0A>=20>=20>=20here=20please.=0D=0A=
>=20>=20>=0D=0A>=20>=20>=20thanks,=0D=0A>=20>=20>=0D=0A>=20>=20>=20greg=20k=
-h=0D=0A>=20>=0D=0A>=20>=20This=20only=20purpose=20of=20this=20variable=20i=
s=20to=20identify=20a=20faulty=20card=20on=20host=0D=0A>=20side.=0D=0A>=20>=
=0D=0A>=20>=20In=20the=20past,=20we=20can=20identify=20that=20the=20card=20=
is=20inserted=20or=20not=20with=0D=0A>=20reading=20get_cd()=20function.=0D=
=0A>=20>=20But=20now,=20most=20mobile=20devices=20use=20hybrid=20type=20of=
=20SD=20card=20tray.=0D=0A>=20>=20If=20the=20tray=20is=20inserted,=20the=20=
return=20value=20of=20get_cd=20is=20the=20same=20whatever=0D=0A>=20the=20SD=
=20card=20is=20inserted=20or=20not.=0D=0A>=20>=20It=20can=20help=20us=20dia=
gonose=20the=20status=20of=20a=20SD=20card=20as=20well.=0D=0A>=20>=0D=0A>=
=20>=20Here=20is=20the=20example=20of=20usage.=0D=0A>=20>=0D=0A>=20>=20stat=
ic=20ssize_t=20status_show(struct=20device=20*dev,=0D=0A>=20>=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20struct=20device_attribute=20*attr,=
=20char=20*buf)=20=7B=0D=0A>=20>=20=20=20=20=20=20=20=20=20struct=20mmc_hos=
t=20*host=20=3D=20dev_get_drvdata(dev);=0D=0A>=20>=20=20=20=20=20=20=20=20=
=20struct=20mmc_card=20*card=20=3D=20host->card;=0D=0A>=20>=20=20=20=20=20=
=20=20=20=20char=20*status=20=3D=20NULL;=0D=0A>=20>=0D=0A>=20>=20=20=20=20=
=20=20=20=20=20if=20(card)=0D=0A>=20>=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20status=20=3D=20mmc_card_readonly(card)=20?=20=22PERMWP=22=20=
:=20=22NORMAL=22;=0D=0A>=20>=20=20=20=20=20=20=20=20=20else=0D=0A>=20>=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20status=20=3D=20host->init_f=
ailed=20?=20=22INITFAIL=22=20:=20=22NOCARD=22;=0D=0A>=20>=0D=0A>=20>=20=20=
=20=20=20=20=20=20=20return=20sysfs_emit(buf,=20=22%s=5Cn=22,=20status);=20=
=7D=0D=0A>=20=0D=0A>=20What=20will=20userspace=20do=20with=20this=20informa=
tion?=0D=0A>=20=0D=0A>=20And=20why=20isn't=20this=20part=20of=20the=20patch=
=20you=20submitted?=0D=0A>=20=0D=0A>=20>=20As=20for=20the=20sysfs=20node,=
=20it=20should=20keep=20the=20path=20of=20node=20with=20or=20without=0D=0A>=
=20the=20SD=20card.=0D=0A>=20>=20That's=20why=20I=20mention=20the=20vendor=
=20module.=0D=0A>=20=0D=0A>=20What=20vendor=20module?=20=20What=20do=20you=
=20mean=20by=20vendor=20module?=20=20You=20know=20we=20can't=0D=0A>=20add=
=20code=20to=20the=20kernel=20that=20is=20only=20used=20by=20code=20that=20=
is=20NOT=20in=20our=20kernel=0D=0A>=20tree.=20=20You=20don't=20want=20us=20=
to=20take=20stuff=20like=20that,=20so=20why=20is=20it=20being=0D=0A>=20prop=
osed=20here?=0D=0A>=20=0D=0A>=20confused,=0D=0A>=20=0D=0A>=20greg=20k-h=0D=
=0A=0D=0AWe=20need=20to=20inform=20users=20that=20there=20is=20a=20problem=
=20with=20the=20SD=20card.=0D=0AThere=20is=20a=20diagnostic=20tool=20in=20t=
he=20customer=20service=20app,=0D=0AAdding=20a=20sysfs=20node=20is=20under=
=20consideration=20so=20that=20the=20tool=20can=20diagnose=20the=20SD=20car=
d.=0D=0ATo=20do=20this,=20a=20node=20capable=20of=20diagnosing=20an=20SD=20=
card=20is=20needed=20regardless=20of=20whether=20an=20SD=20card=20is=20pres=
ent=20or=20not.=0D=0A=0D=0ASince=20I=20understand=20that=20the=20proposed=
=20sysfs=20node=20is=20difficult=20to=20apply=20to=20the=20kernel,=20no=20s=
eparate=20commit=20was=20posted.=0D=0ASo,=20I=20created=20this=20PR=20becau=
se=20I=20needed=20a=20variable=20to=20identify=20the=20faulty=20device.=0D=
=0A=0D=0AI=20will=20consider=20this=20part=20again.=0D=0AAnd=20if=20you=20h=
ave=20any=20other=20good=20ideas,=20please=20feel=20free=20to=20suggest=20t=
hem.=0D=0A=0D=0AThank=20you=20for=20your=20review.=0D=0ASeunghui=20Lee.=0D=
=0A=0D=0A=0D=0A