Received-SPF: pass (google.com: domain of linux-kernel+bounces-68078-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Fri, 16 Feb 2024 11:12:35 +0530
From: Dhruva Gole <d-gole@ti.com>
To: Randy Dunlap <rdunlap@infradead.org>
CC: <linux-kernel@vger.kernel.org>, Mark Brown <broonie@kernel.org>,
        <linux-spi@vger.kernel.org>
Subject: Re: [PATCH -next] spi: spi-summary.rst: fix underline length
Message-ID: <20240216054235.bkfyi5mbdz2yyhan@dhruva>
References: <20240216051637.10920-1-rdunlap@infradead.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240216051637.10920-1-rdunlap@infradead.org>

Hi,

On Feb 15, 2024 at 21:16:37 -0800, Randy Dunlap wrote:
> The change to use "target" requires an underline to be extended by
> one more character to fix a documentation build warning:
> 
>   Documentation/spi/spi-summary.rst:274: WARNING: Title underline too short.
>   Declare target Devices
>   ^^^^^^^^^^^^^^^^^^^^^

Oops, looks like I missed it.

> 
> Fixes: hash ("spi: Update the "master/slave" terminology in documentation")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Dhruva Gole <d-gole@ti.com>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: linux-spi@vger.kernel.org
> ---
>  Documentation/spi/spi-summary.rst |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff -- a/Documentation/spi/spi-summary.rst b/Documentation/spi/spi-summary.rst
> --- a/Documentation/spi/spi-summary.rst
> +++ b/Documentation/spi/spi-summary.rst
> @@ -271,7 +271,7 @@ an external clock, where another derives
>  settings of some master clock.
>  
>  Declare target Devices
> -^^^^^^^^^^^^^^^^^^^^^
> +^^^^^^^^^^^^^^^^^^^^^^

Good catch,
Reviewed-by: Dhruva Gole <d-gole@ti.com>

Mark,
Will you be just squashing the commits since they're still in next
or will this be a separate commit? Just curious how fixes work while
they're still not in any mainline linux tree

-- 
Best regards,
Dhruva Gole <d-gole@ti.com>