Received: by 2002:a05:7412:1e0b:b0:fc:a2b0:25d7 with SMTP id kr11csp932471rdb; Thu, 15 Feb 2024 23:06:12 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUQ+EhZIIEVCdFDKHNvKJXU1oYhZlhavDiAViOcUl8jAVwxKKRuYRvWbsd9hvXZRH/cisdAsSlHnxysvL6Mk7W16sjwNuzH2NbmXzAf+A== X-Google-Smtp-Source: AGHT+IFbAXNYgCu/obHEGwGRzmsIgJwQmsPsTVkOLO0f9fkMPP+23ZyWXOiOTcWJljBYaCEIJG/S X-Received: by 2002:a05:620a:1a08:b0:787:4148:f6e3 with SMTP id bk8-20020a05620a1a0800b007874148f6e3mr1632187qkb.37.1708067172201; Thu, 15 Feb 2024 23:06:12 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708067172; cv=pass; d=google.com; s=arc-20160816; b=k4OvtAJdvOnXidPqMXDyDuFCPoBJ69aBWxCOoOmbIMDTqhNZRjocGXSr2rZNjOF6SY oB2lhvuCyJA/eKjJ/+tf+7jlW7OKB6J77NUioFfpCdlDajY2ed0DjDiBhHrQ8Nk0jXn+ 77oL9R8+sUuuGjD3ybhiXEdCEyI09N26HUhDKN8Kf3VvEoO/U0CghHTyoXuDhJkgxXvY g7dQE2svfouK5r3Yx6kvEyLGjfCcDJoZ7rBTNynU7My8c3bqK3sVyq/mIR5dQ2JOWLm4 KvWLsoxxoRsmylroDPD3o3ojg4d+Rgm2YMSduPChDYPo5aAaCGdc+iZ1xR6WC7wlo3zZ TIrA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=uFOh+ffUHbTzqoNg7f3NtavVRglY5kTfBM1QkaehxhQ=; fh=d0011ibsW8u9F4mU23gkRrkiBaaYLUAED0T3Ag9L01A=; b=J6CyBfsb1QJxhLgMpyRckGyvVGrBYOSQRIVxFOChm4m33Oovjo17dmsCLFFGlXHeea k9BQoTEvWi7uNlEDdYI8AZqmhhoaPGVoNH1p5doFJyMIpr0eAazlAs8H5dmMhCGLnYX+ jofVkwjbIfDMDHxRqeVHbnyfOxQ5TWyYTwTmMMqDH8YMGLTbP9MIRVSSOODdIurCduWY HxFqpf+cqbaayuYLXFPKPn4p/+3ph4J9pLq5ILN20N8vfgQpqA35XfYAroQvEGXg9BD2 ycHWu8qXaBb891yEIdkHYPcscx5Er7aKOqoJVBkG0IofAUvbc02Z81jbk2EgwSRxqXb4 qA4g==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="raa9/M0A"; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-68141-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-68141-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id d9-20020ac85d89000000b0042c67c6f2a1si3550156qtx.608.2024.02.15.23.06.12 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Feb 2024 23:06:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-68141-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="raa9/M0A"; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-68141-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-68141-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id EFAC11C228AF for ; Fri, 16 Feb 2024 07:06:11 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 64E6714F98; Fri, 16 Feb 2024 07:06:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="raa9/M0A" Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 24BE9C15D for ; Fri, 16 Feb 2024 07:06:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708067163; cv=none; b=t9IYFOWDuQVwz7/cZGl8lJgLyt5zxkfh0ioJBF92YOHElCDhJduZn49DiGiDWri7+N1iMVn20M0kMAhKSnYD9QfCGViSnjjQoNaHnprqPgmjPfI5xa0zrHhiODS8gIrJ+VJqIdi82co25PLtrMy6ONAHAcFBlRgNyNCPVwfuzsk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708067163; c=relaxed/simple; bh=UumdA+u7mJW1hsa/1bKQOt92hrmkFZLp9HYQzcowhO4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=hJGV4QeYjF00A6MT/q+F3r0jjRXVOFkS67mkPjLpNDDBCgf7/FDQjXcqaDrTo4evRUemUS8DN/GuXhtPx3TxUYJHQSANDBtFhkGP/gtc06vlqrmvOUeXMOaoNh7o1nmWiZRPF5VUsrajuLcxZujUaQp6o/e7JQW47s/BkOiLB4E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=raa9/M0A; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-33cf6374e58so187995f8f.3 for ; Thu, 15 Feb 2024 23:06:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1708067159; x=1708671959; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=uFOh+ffUHbTzqoNg7f3NtavVRglY5kTfBM1QkaehxhQ=; b=raa9/M0ADHybg3Km+WVEYYYwBWYohUB0O3J1xjZLFhytcuPrIUNKFpHIyP8HcCfijk vv/zWvRRcWacWxBvMMdnWYCfPcHohzwZ6lDHBhaQtnblk+EguFOaAvjctmZrLmjQJ48T JCUP6r8nHoqGci6loztw/OeBrJ9h93uHNH9m5tvpbxgUVcMRYoaScOlue5a2w5M2ZCcZ L6tvKYisrc2F+cD+OK+1wPGbB8FcIwxU04cutzKQ8ZcgZEuY1ytjoQkriL/FE2pdke7j 0Z/uDS7PqN6Xj7HnFT/o0D1XNSLZi6PSj08gGB55USt9LQe6jWUApmeGa89PwZzXhb+Z XyPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708067159; x=1708671959; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=uFOh+ffUHbTzqoNg7f3NtavVRglY5kTfBM1QkaehxhQ=; b=SNUGlkvdIp5FRJnqzIY+crQc+yUWmYkKO/BwWOlriOIfgvDrVIsPcnrWueqYkNoSf+ c0oYtfDpPjlPDBAU3bvWOkXWmAxV1jdu+OcM66x2K5Higl3AUIzUKOoSecrheWUMvjLs fJhJ07Fcdot5AHQ37QjOBVGPEDDGLPp5KQZR8hG5cgsXDBz+egG1JWYDPgkfp2unAUTR SHRWrjmyRV6laf48VolorGTQQcxW9FZhSQOcqduukmePjXWq280T5vG5YkM3JhcWG7Tg zZiczjVnKT44Sb0Fe5+9nnfZz9/Himog8+I9F4MiEgjxvJ4DImep+B1Ju+3awhoJoEyl jaAA== X-Forwarded-Encrypted: i=1; AJvYcCWQiR6iuIm8YzSWJHTdB6+A2bWMXh0RjEXvc16BCQRD6/5sAfIOPvoIsM104MpcL5oL2ApDkUpyoQEW+WBdHeFePvDl32DM/rmQO78M X-Gm-Message-State: AOJu0Yxh1tX5NdI17ziFbHc0upqUhl+4/008Z/LLpsjk8kTGLOjh9zLd Va5HxUk8AfdW/SONYS8bxDAQI90ulu5UwR6L6TNml0RWtxljiZfvjPatjVTCaoY= X-Received: by 2002:a5d:4486:0:b0:33d:d32:2a5b with SMTP id j6-20020a5d4486000000b0033d0d322a5bmr2407932wrq.3.1708067159298; Thu, 15 Feb 2024 23:05:59 -0800 (PST) Received: from ta2.c.googlers.com.com (105.168.195.35.bc.googleusercontent.com. [35.195.168.105]) by smtp.gmail.com with ESMTPSA id k18-20020a5d66d2000000b0033940016d6esm1298839wrw.93.2024.02.15.23.05.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Feb 2024 23:05:58 -0800 (PST) From: Tudor Ambarus To: broonie@kernel.org, robh@kernel.org, andi.shyti@kernel.org, krzysztof.kozlowski@linaro.org, semen.protsenko@linaro.org, conor+dt@kernel.org Cc: alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, devicetree@vger.kernel.org, Tudor Ambarus Subject: [PATCH v3 00/12] spi: s3c64xx: remove OF alias ID dependency Date: Fri, 16 Feb 2024 07:05:43 +0000 Message-ID: <20240216070555.2483977-1-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.44.0.rc0.258.g7320e95886-goog Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The driver was wrong as it assumed that the alias values in devicetree have a particular meaning in identifying instances. This immediately breaks when there is a dtb file that does not use the same alias values, e.g. because it only needs some of the SPI ports. Tested gs101 SPI with spi-loopback-test, all went fine. I updated exynos850 as it uses the same USI.SPI_VERSION as gs101. Maybe Sam can test exynos850, if not, we can drop that patch (12/12). v3: - fix indentation in dt-bindings - collect Rob's R-b v2: - update bindings to consider the asymmetric case where the RX FIFO depth can differ from the TX FIFO depth - update commit message in patch 11/12 to describe the GS101 change (I was wrongly mentioning exynos 850). Tudor Ambarus (12): spi: dt-bindings: introduce FIFO depth properties spi: s3c64xx: define a magic value spi: s3c64xx: allow full FIFO masks spi: s3c64xx: determine the fifo depth only once spi: s3c64xx: retrieve the FIFO depth from the device tree spi: s3c64xx: allow FIFO depth to be determined from the compatible spi: s3c64xx: let the SPI core determine the bus number spi: s3c64xx: introduce s3c64xx_spi_set_port_id() spi: s3c64xx: get rid of the OF alias ID dependency spi: s3c64xx: deprecate fifo_lvl_mask, rx_lvl_offset and port_id spi: s3c64xx: switch gs101 to new port config data spi: s3c64xx: switch exynos850 to new port config data .../bindings/spi/spi-controller.yaml | 27 ++++ drivers/spi/spi-s3c64xx.c | 142 ++++++++++++++---- 2 files changed, 138 insertions(+), 31 deletions(-) -- 2.44.0.rc0.258.g7320e95886-goog