Received: by 2002:a05:7412:1e0b:b0:fc:a2b0:25d7 with SMTP id kr11csp946514rdb; Thu, 15 Feb 2024 23:46:00 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXVno79J4UMz18Dtzc6yvRriJFK1G5618+eSZs5f8SX6Zu2cU98a1run4+wCEUhSkyJ3UFyBsgifoMzAkCj/9a05luljXdv1QuIqFp9rw== X-Google-Smtp-Source: AGHT+IFSN13ybl0OKDXmlbdnD+Wrv7yKdBYvhA5I9PlMeqUrX5c+PFS/srTvn0FvIppz1Fjt2UP3 X-Received: by 2002:a17:906:e2d9:b0:a3c:a65:7bd8 with SMTP id gr25-20020a170906e2d900b00a3c0a657bd8mr2848380ejb.24.1708069560084; Thu, 15 Feb 2024 23:46:00 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708069560; cv=pass; d=google.com; s=arc-20160816; b=JFc2JW6E3OC/zmZu2qDwxtZQmxgxBFZj12iePyfSeIRqHP/Xo7dz/JeNTnch0nYDvJ pOL94I1EU0600Fl/yMDigoKyJ2PVHzSxI5sKLlsn9AzZVIhqbO3kAm9scvBh6eBJ8bC4 /xvlgfviXhg+E/RaCnrKdxJehAdHLtIwADC9j4Ogdqd3HOj9mP9KDxZqyAnhDNTTHEHr CQhhgg27JvZxEJf25Bz3BsqMBh40XZUb9IPB/tgE9etJ7HyjOvECTh9ixuLqrbXc1OsS qcOjo4LlRiyXu896OUaSCdakg8Vo4r8lrn+UVqsawAahQvy6WCtf1w9aziqIOiP11bEc 6sgA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=Y4+Xtt/2QR/jaiCB77YYEz6l8UyC17iHPmEtlyWjDIE=; fh=UguTggosY45Yc5BserhRfE0QqA/DVO319xHxszD1ydI=; b=tl+q+rTBFIycUP+cCMHGw5IwsErCvz/xbxbNTqEGoj8Bm2vd+uiEOn1fUjOkITvi1Y atKtU2PivxlBrIOTQZmK0IL7nhr2mGrC4HyEslmULxkLKZYaczbdCvqfkbU6eZPqEBRt G1snrEVC+53nToCOdZq9dhRu7kzRnFgO4JhJ1yPlRQiidNo4KPOQmEIhmStESoA3MN0U OygJw8boTD19nGEWTjJ3Uouz6P9iVN2qLqLoaVAi6a8CT7+dL8jufIBeDilgK29womzy B3o/OSqvWEyg/eKPCxySiO+kQWjhrdAipy0kEOG75lFQF4xgfH0e+CM5IbXtumm0oWh/ PtFw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@dolcini.it header.s=default header.b=Npyaki0t; arc=pass (i=1 spf=pass spfdomain=dolcini.it dkim=pass dkdomain=dolcini.it dmarc=pass fromdomain=dolcini.it); spf=pass (google.com: domain of linux-kernel+bounces-68184-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-68184-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=dolcini.it Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id n24-20020a170906689800b00a3da5c1ec77si1080126ejr.115.2024.02.15.23.46.00 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Feb 2024 23:46:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-68184-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@dolcini.it header.s=default header.b=Npyaki0t; arc=pass (i=1 spf=pass spfdomain=dolcini.it dkim=pass dkdomain=dolcini.it dmarc=pass fromdomain=dolcini.it); spf=pass (google.com: domain of linux-kernel+bounces-68184-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-68184-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=dolcini.it Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id C22111F235B5 for ; Fri, 16 Feb 2024 07:45:59 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D2F93175BE; Fri, 16 Feb 2024 07:45:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=dolcini.it header.i=@dolcini.it header.b="Npyaki0t" Received: from mail11.truemail.it (mail11.truemail.it [217.194.8.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B58D10962; Fri, 16 Feb 2024 07:45:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.194.8.81 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708069546; cv=none; b=Y7enPDo6IsK7HlhaSIZ2innNepcv9BK+7NGWUAcY36SH+heTCkC1+xx+eUWDamUVYTKjeE/+iNGaOEBNYGaJsdCLg2B9N0yHZNJXzTnoUIj7Z5fFfJ8sbVrN18FP9K7Z9PAVUyAUYOiKqDV/uk2zzjsyjNOEMp7EFYl2oXtkIxk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708069546; c=relaxed/simple; bh=H5Cn/kat7fnjZH35kMK0oH3YmXnUuv6zK85IWPk9t9I=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=OZECBUTmpqwI1Xu6KaaID4wbExKJMlhTHNdY7no1Fvfe8qJMjeZBSao/IILHCyJpn9M1UDJTe31i34B1LI8khvn0F9L9d/BacXKZeJacBrnc6TNh6A528vhLsvGDzUtxhFYfUHESY30UlmuQZHqtAvDEsvSUn9bZqlZ448c/PzY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=dolcini.it; spf=pass smtp.mailfrom=dolcini.it; dkim=pass (2048-bit key) header.d=dolcini.it header.i=@dolcini.it header.b=Npyaki0t; arc=none smtp.client-ip=217.194.8.81 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=dolcini.it Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=dolcini.it Received: from francesco-nb (93-49-2-63.ip317.fastwebnet.it [93.49.2.63]) by mail11.truemail.it (Postfix) with ESMTPA id AFA77211F4; Fri, 16 Feb 2024 08:45:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dolcini.it; s=default; t=1708069533; bh=Y4+Xtt/2QR/jaiCB77YYEz6l8UyC17iHPmEtlyWjDIE=; h=From:To:Subject; b=Npyaki0tZpmnvQRONBP6sCJMD1vO+WcjHYJ2sv/Op1uU3jHx2gn97VetZ+LpW1nZH AN/grT1xX6iFVFpff8uUMWF0sBdCqFkbUIlSRU/QV2nU0tDbuFb+OOPogmStZRIh9p +0P/b7msCR7Le02Tcl6uStHn++6wEyuWr/9TMRsvh/ESAxo2QSKh0RdSMYCQrYxwm4 xPGtuEfiqG58XZPvt4m5bHdazAyFBOg2JLLWwGYaNCnLb7lBUzndn6rwE3SUOaW49e JBLTb0EP50jJvgTq1v5LqKDh/66lZiHnfLb3h2j95pJHXmbJWlW42kT75zz9bJWEMx 0+uWpqU8y9U1Q== Date: Fri, 16 Feb 2024 08:45:27 +0100 From: Francesco Dolcini To: Marc Kleine-Budde , Vincent Mailhol Cc: Chandrasekar Ramakrishnan , Wolfgang Grandegger , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Francesco Dolcini , linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] can: m_can: remove redundant check for pm_clock_support Message-ID: <20240216074527.GA5457@francesco-nb> References: <20240104235723.46931-1-francesco@dolcini.it> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240104235723.46931-1-francesco@dolcini.it> Hello Marc and Vincent, On Fri, Jan 05, 2024 at 12:57:23AM +0100, Francesco Dolcini wrote: > From: Francesco Dolcini > > m_can_clk_start() already skip starting the clock when > clock support is disabled, remove the redundant check in > m_can_class_register(). > > This also solves the imbalance with m_can_clk_stop() that is called > afterward in the same function before the return. > > Signed-off-by: Francesco Dolcini Did you missed this? Or do you have some concern with it? Francesco