Received-SPF: pass (google.com: domain of linux-kernel+bounces-68236-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <36f99696-d7ca-4390-a263-dbb72d5c9ae6@intel.com>
Date: Fri, 16 Feb 2024 10:28:28 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [EXT] Re: [PATCH v2 0/2] Fix PHY init timeout issues
Content-Language: en-US
To: Elad Nachman <enachman@marvell.com>, Ulf Hansson <ulf.hansson@linaro.org>
Cc: "huziji@marvell.com" <huziji@marvell.com>,
 "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <20240215161613.1736051-1-enachman@marvell.com>
 <CAPDyKFpNL_zFgzSNgaSRqaH8tDNjwB16ZD1YGwqM64vcQ2oxtA@mail.gmail.com>
 <BN9PR18MB4251FD4F9BD9915477823316DB4D2@BN9PR18MB4251.namprd18.prod.outlook.com>
From: Adrian Hunter <adrian.hunter@intel.com>
Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki,
 Business Identity Code: 0357606 - 4, Domiciled in Helsinki
In-Reply-To: <BN9PR18MB4251FD4F9BD9915477823316DB4D2@BN9PR18MB4251.namprd18.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 15/02/24 19:01, Elad Nachman wrote:
> 
> 
>> -----Original Message-----
>> From: Ulf Hansson <ulf.hansson@linaro.org>
>> Sent: Thursday, February 15, 2024 6:51 PM
>> To: Elad Nachman <enachman@marvell.com>
>> Cc: huziji@marvell.com; adrian.hunter@intel.com; linux-
>> mmc@vger.kernel.org; linux-kernel@vger.kernel.org
>> Subject: [EXT] Re: [PATCH v2 0/2] Fix PHY init timeout issues
>>
>> External Email
>>
>> ----------------------------------------------------------------------
>> On Thu, 15 Feb 2024 at 17:16, Elad Nachman <enachman@marvell.com>
>> wrote:
>>>
>>> From: Elad Nachman <enachman@marvell.com>
>>>
>>> Fix PHY init timeout issues:
>>>
>>> 1. Clock Stability issue causing PHY timeout
>>>
>>> 2. Timeout taking longer than needed on AC5X.
>>>    Solve by constantly testing the PHY init bit
>>>    until it toggles, but up to 100X timeout factor.
>>>
>>> v2:
>>>     1) convert polling loop to read_poll_timeout()
>>>        for both patches.
>>>
>>> Elad Nachman (2):
>>>   mmc: xenon: fix PHY init clock stability
>>>   mmc: xenon: add timeout for PHY init complete
>>>
>>>  drivers/mmc/host/sdhci-xenon-phy.c | 48
>>> ++++++++++++++++++++++++------
>>>  1 file changed, 39 insertions(+), 9 deletions(-)
>>>
>>
>> The series looks good to me. Although, I assume we should tag this for stable
>> kernels too and possibly add a fixes tag?
> 
> No problem.

Presumably:

Fixes: 06c8b667ff5b ("mmc: sdhci-xenon: Add support to PHYs of Marvell Xenon SDHC")

FWIW:

Acked-by: Adrian Hunter <adrian.hunter@intel.com>

> 
>>
>> Moreover, it would be nice to get an ack from Hu Ziji.
> 
> He does not longer work with Marvell, so this email is invalid, I tried also to send an e-mail manually as well and got:
> huziji@marvell.com
> Remote Server returned '550 5.1.1 RESOLVER.ADR.RecipNotFound; not found'
> 
> Could not locate him via google search either.
> 
>>
>> Kind regards
>> Uffe