Received-SPF: pass (google.com: domain of linux-kernel+bounces-68276-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Content-Type: multipart/signed;
 boundary=52ba317e8c7c5ca537a8d63e6ea42f83f0a58640d2bb4d9412e895a495f2;
 micalg=pgp-sha256; protocol="application/pgp-signature"
Date: Fri, 16 Feb 2024 09:47:27 +0100
Message-Id: <CZ6DFL6061FS.2WMDPMSSBXX8S@walle.cc>
Cc: <linux-kernel@vger.kernel.org>, <kernel@pengutronix.de>
From: "Michael Walle" <michael@walle.cc>
To: "Marco Felsch" <m.felsch@pengutronix.de>,
 <srinivas.kandagatla@linaro.org>, <gregkh@linuxfoundation.org>,
 <miquel.raynal@bootlin.com>, <rafal@milecki.pl>
Subject: Re: [RFC PATCH] nvmem: core: add sysfs cell write support
References: <20240215211401.1201004-1-m.felsch@pengutronix.de>
In-Reply-To: <20240215211401.1201004-1-m.felsch@pengutronix.de>
Precedence: bulk

--52ba317e8c7c5ca537a8d63e6ea42f83f0a58640d2bb4d9412e895a495f2
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8

Hi,

On Thu Feb 15, 2024 at 10:14 PM CET, Marco Felsch wrote:
> @@ -432,6 +466,7 @@ static int nvmem_populate_sysfs_cells(struct nvmem_de=
vice *nvmem)
>  	struct bin_attribute **cells_attrs, *attrs;
>  	struct nvmem_cell_entry *entry;
>  	unsigned int ncells =3D 0, i =3D 0;
> +	umode_t mode;
>  	int ret =3D 0;
> =20
>  	mutex_lock(&nvmem_mutex);
> @@ -456,15 +491,18 @@ static int nvmem_populate_sysfs_cells(struct nvmem_=
device *nvmem)
>  		goto unlock_mutex;
>  	}
> =20
> +	mode =3D nvmem_bin_attr_get_umode(nvmem);
> +
>  	/* Initialize each attribute to take the name and size of the cell */
>  	list_for_each_entry(entry, &nvmem->cells, node) {
>  		sysfs_bin_attr_init(&attrs[i]);
>  		attrs[i].attr.name =3D devm_kasprintf(&nvmem->dev, GFP_KERNEL,
>  						    "%s@%x", entry->name,
>  						    entry->offset);
> -		attrs[i].attr.mode =3D 0444;

cells are not writable if there is a read post process hook, see
__nvmem_cell_entry_write().

if (entry->read_post_processing)
	mode &=3D ~0222;

-michael

--52ba317e8c7c5ca537a8d63e6ea42f83f0a58640d2bb4d9412e895a495f2
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iIcEABYIAC8WIQQCnWSOYTtih6UXaxvNyh2jtWxG+wUCZc8hHxEcbWljaGFlbEB3
YWxsZS5jYwAKCRDNyh2jtWxG+8eBAQDGYo2DtOKLuL0CsiuJCDK03JOD16/qs+uF
gwFEDQ6wUQEA3o3jofN51UHHDYz/EMyPvP6IRxGvCx7djrUXzzdHGgk=
=dSaw
-----END PGP SIGNATURE-----

--52ba317e8c7c5ca537a8d63e6ea42f83f0a58640d2bb4d9412e895a495f2--