Received: by 2002:a05:7412:1e0b:b0:fc:a2b0:25d7 with SMTP id kr11csp994775rdb; Fri, 16 Feb 2024 01:51:23 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCW9TaefA+V+SsGlmmjNeM4JfcqXvyeehPvvyj9rLPKH1oJwEdnCVU4r8ARaXtEAgR86wUBqLT7vIFvrUCBPWV7L7zWKoJUeYgL/LgMunA== X-Google-Smtp-Source: AGHT+IFTyewAGzsOsjn+j0ddxG20yxuuVVwJXq/AWJQdpDFMTTv8HYCNj69p0Pmz7wYBG6WMsU7e X-Received: by 2002:a17:906:b74e:b0:a3d:d7f1:35ff with SMTP id fx14-20020a170906b74e00b00a3dd7f135ffmr887754ejb.55.1708077083545; Fri, 16 Feb 2024 01:51:23 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708077083; cv=pass; d=google.com; s=arc-20160816; b=eGfVI4MDA59EIBD8U0Kqd6C0Oob8pi4ljCV979VU+4J2w+85bGu2tZdJii9obk2rJV w8dE6XNcASJPXYCgvkOIegYTD8kvAAHigdtIAvd6javlxUCbe223ocHgO6kVnBfpSHPs KqKXsCieqOj9YTY3Z4bLc0Tk/p7QgcH6fr4pkOnADcnyCZxJSegrU86RbkF51nnB3f3F WsTfwZtxW/J5NUZ78y3oW2g4uVpnWZiHGeIKJ8W5RPxsD7/NmFqt8nzoWa723DZWpu7C lBG0QYtAr0j2tMXjkh1ED/lh5xmY4D3m2ncEv9QugbAazWlgiexOxdf+Up2pArA+j5TM 6/NA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :message-id:subject:cc:to:from:date; bh=LWkC4kHnd5rDNmh5GwYHGYDQ5SpZJY4qV1M3oGrOn2g=; fh=Z/DuZz7DTBFCNWksBKpKJu8nj+rwZLNKB1GlBH2f3A8=; b=oSYZeBmOKGohzRpGt6unXuBHu71CS9BZrVUpwHPNE+1Fg/b2yAiVH0V0dQRgAXvdUf TvVOZC7YDAGAGCvmg/LJTR8HcyJKcfx6h7k/ypxHKoZ0/ZLMSWtWyKevrJbWiq1xL89N hQtlknV7u3cJ9j25in6/P/oqSeUXgJx0Lnk3KGC3fXXk2kLIoxY9NQ17bpajW5+tSI/c fpFmo+lbNn/CaOP5v19LRSQj8wu56EHKEPFzG8HaKKz3n68cr40S1Su0ECNuU4SSr6RY 5RizS2bnV7n9RhMdVglcA6CT07XYjFd8u2k6k6xsA5P00rc+EVO9XkxUM6N7nkulutiz CAjA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=lst.de); spf=pass (google.com: domain of linux-kernel+bounces-68365-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-68365-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id gw22-20020a170906f15600b00a3d83788edbsi1473962ejb.105.2024.02.16.01.51.23 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Feb 2024 01:51:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-68365-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=lst.de); spf=pass (google.com: domain of linux-kernel+bounces-68365-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-68365-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 435941F20EFC for ; Fri, 16 Feb 2024 09:51:23 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 531C51C692; Fri, 16 Feb 2024 09:50:18 +0000 (UTC) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D4B91C29B for ; Fri, 16 Feb 2024 09:50:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708077017; cv=none; b=QMJXfyc6YYeS/At9I61hK9/ZcpwYfUpsADCt6o6K+4/CbS6g5+eyVnBOklssO8w0Faxye1TgS0jtugSwaOKv0yVREtBlerzD6cccbpdzJgmUT3Nx6Gqslq24FTefGSKf9q3WGA6UIokK6JassaOlFtfMXdNY9Hj9gZNnGdd8ncc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708077017; c=relaxed/simple; bh=OgTTNaCUTyLbECHK5cme/Osf+zYb8mCvQLxELN+mbdE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=uG0fYAu9rXsp3wPnIAIwTjhiAZIaD8aUeAC6+rB5k8BHUP4SH23yGtkF+F7SiEwZpmJp4bLXjcTpDiZVt3bTumgDufWoWmmob9SKc0DcqkaTQzUyhFRW4Ozru/PgtsKPq3+EXr5uU77v8Zj9waEkuDgVGqkx6Oz6/3gZk5Gqt08= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id 63D7168BFE; Fri, 16 Feb 2024 10:50:13 +0100 (CET) Date: Fri, 16 Feb 2024 10:50:13 +0100 From: Christoph Hellwig To: Daniel Wagner Cc: James Smart , Keith Busch , Christoph Hellwig , Sagi Grimberg , Hannes Reinecke , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v0 4/6] nvme-fabrics: introduce ref counting for nvmf_ctrl_options Message-ID: <20240216095013.GD19961@lst.de> References: <20240216084526.14133-1-dwagner@suse.de> <20240216084526.14133-5-dwagner@suse.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240216084526.14133-5-dwagner@suse.de> User-Agent: Mutt/1.5.17 (2007-11-01) On Fri, Feb 16, 2024 at 09:45:24AM +0100, Daniel Wagner wrote: > The FC transport is offloading the connect attempt to a workqueue. When > the attempt fails the transport is starting to cleanup resources. It is > possible for user space to trigger a crash because nvmf_ctrl_options are > exposed to sysfs. Eww. I think the async offload is the real problem here..