Received: by 2002:a05:7412:1e0b:b0:fc:a2b0:25d7 with SMTP id kr11csp998876rdb; Fri, 16 Feb 2024 02:02:32 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWj3FYSo4MMAh5M5/gOP7NX0lWU4aOP13tuuy+QmPvgZ/k3KPNNbczTS++fhUUC3oAbc04E5V8gajBoNyfXH7Td1KYN2eB4ZoSn0F7jmA== X-Google-Smtp-Source: AGHT+IF7XvoLu0wPGhACPYJfVvaEewEcBLqbHAe7yJjzpmOLDJGZcRBLhAkUM36iPbay7bz90LHI X-Received: by 2002:a05:6358:706:b0:17a:b810:aace with SMTP id e6-20020a056358070600b0017ab810aacemr4652119rwj.15.1708077751805; Fri, 16 Feb 2024 02:02:31 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708077751; cv=pass; d=google.com; s=arc-20160816; b=mDVi94i5OKYCOmcf3psVD0rTUt/U9gyaHIWEyMF5jVLzvnfrYAH1rMnISme4v+UcCF 5ioMhA/Edc04xpuEzNWiYlijhVVuBg2hy11fQhJQuBCQwKMFWySV9YX9qTfo9AMHZSmA L9vozfOxXA6zCvihAooQj/4YkX/p4nvP2hzWznsxiZdfOLk561FN+JVF/AGwH0Jaj90i 5UI31u7+rDBsPQUj9So/p5B7dyAuVXA1kTkB5dIwYAAP4+6sHqF76c91kUn99NqCRVHY nUdtxWTtXdtcx5yEYujPZiCb39LMjlCptZ+TcEL4+hy7q3VkDSbVavYRLCCrhqasE0bB Vnxw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :message-id:subject:cc:to:from:date; bh=jD76SPYdx3XEQCplS59GC2hFcWsKN8VKJgqwsIcaius=; fh=Z/DuZz7DTBFCNWksBKpKJu8nj+rwZLNKB1GlBH2f3A8=; b=zM9hGtfmRW8L7Yq0kgo3Z9IYTG0s88130d+UMm4IhG1tUw7F6aaykgoN909ktUR+4B lPOEQNKAybsnMfKyD3CGbIy5QwFWtm89A+S07rFw9mJtC8TXlKgPAZmdzcd0q1l6ULTO sDNbLWVxzQhrrmqdg72155uvBTJ72mVDXsIvg7wCwlrfrZBb4AHo8+py3EQL6V5WsV4f 3z4R0HD0OCSOxVNpEfnsqmoGsYyXgtjbOLEOE6Bgq81Ye1uG/N9UQEX1cw710hZmmc9r /FUSfCb6M0BM7ogACT7o+DmQzoeX5vxjJtMVKYGGZ+1mMPEUpxN5RrKWjauoOhP5s0p3 +D2A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=lst.de); spf=pass (google.com: domain of linux-kernel+bounces-68376-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-68376-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id bq17-20020a056a02045100b005d8b5979996si2966488pgb.492.2024.02.16.02.02.31 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Feb 2024 02:02:31 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-68376-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=lst.de); spf=pass (google.com: domain of linux-kernel+bounces-68376-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-68376-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id EAECBB24099 for ; Fri, 16 Feb 2024 09:54:29 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 44DD622F17; Fri, 16 Feb 2024 09:51:40 +0000 (UTC) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B91722EF9 for ; Fri, 16 Feb 2024 09:51:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708077099; cv=none; b=j4pGiofSwXUIp94BwxC/s9I5k/o9FE0D3kPfupbEePXvuNyyDYeBxe5bj6BAImZ8HrXBA6w3OHSUxTmd0ZB0hc97/gAIsi7aFtMN88h9DrugyNb+wrGej29pKeT4n4P+H00nGjaWdx+k8C5MUg9REzm/hwHY/Tx1qqHyWLKVPfY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708077099; c=relaxed/simple; bh=Byc/pEoOr+0338wCSDrouBDlqgbu0HUtq1mAFDh16m0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XUYzXNU8EaGT5cvpxQ+gzNUa+WWbmQeDLOh3Ep5VwauhKW5ICnHbJKRWFioYh9n7c46IHTGFWfj2w9z8Ny2vqlG9JLsr1HhvIQsUc3uyKfIPA8zxzAtoNE3l9n/7k3SJLkO1/jIFH3dhJqSLDiAnxVvBtGoD/Hy9hYOy1GnIgiI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id 4BA7F68BFE; Fri, 16 Feb 2024 10:51:35 +0100 (CET) Date: Fri, 16 Feb 2024 10:51:34 +0100 From: Christoph Hellwig To: Daniel Wagner Cc: James Smart , Keith Busch , Christoph Hellwig , Sagi Grimberg , Hannes Reinecke , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v0 5/6] nvme-fc: redesign locking and refcounting Message-ID: <20240216095134.GE19961@lst.de> References: <20240216084526.14133-1-dwagner@suse.de> <20240216084526.14133-6-dwagner@suse.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240216084526.14133-6-dwagner@suse.de> User-Agent: Mutt/1.5.17 (2007-11-01) This looks reasonable to me. Without much further reading I don't really feel qualified to comment on nvme-fc locking and refcounting, though.