Received-SPF: pass (google.com: domain of linux-kernel+bounces-68498-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Fri, 16 Feb 2024 11:05:43 +0000
From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Vasileios Amoiridis <vassilisamir@gmail.com>, lars@metafoo.de,
 ang.iglesiasg@gmail.com, 579lpy@gmail.com, linux-iio@vger.kernel.org,
 linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers: iio: pressure: Add SPI support for BMP38x and
 BMP390
Message-ID: <20240216110543.5d6289f6@jic23-huawei>
In-Reply-To: <Zc5D35_4FdERZXe4@smile.fi.intel.com>
References: <20240215164332.506736-1-vassilisamir@gmail.com>
	<Zc5D35_4FdERZXe4@smile.fi.intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Thu, 15 Feb 2024 19:03:27 +0200
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:

> On Thu, Feb 15, 2024 at 05:43:32PM +0100, Vasileios Amoiridis wrote:
> > According to the datasheet of BMP38x and BMP390 devices, in SPI
> > operation, the first byte that returns after a read operation is
> > garbage and it needs to be dropped and return the rest of the
> > bytes.  
> 
> Thank you for the patch, my comments below.
> 
> ...
> 
> > +static int bmp380_regmap_spi_read(void *context, const void *reg,
> > +				  size_t reg_size, void *val, size_t val_size)
> > +{
> > +	struct spi_device *spi = to_spi_device(context);
> > +	u8 ret[BMP380_SPI_MAX_REG_COUNT_READ + 1];
> > +	ssize_t status;
> > +	u8 buf;  
> 
> AFAIU this buffer is not DMA-capable.

Doesn't matter in this case as spi_write_then_read() bounces anyway so you don't need
to provide it with a dma safe buffer. It's in the docs, so we can rely
on this not changing.

https://elixir.bootlin.com/linux/latest/source/drivers/spi/spi.c#L4391