Received-SPF: pass (google.com: domain of linux-kernel+bounces-68512-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Fri, 16 Feb 2024 11:21:20 +0000
From: Jonathan Cameron <jic23@kernel.org>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: puranjay12@gmail.com, lars@metafoo.de, robh+dt@kernel.org,
 krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
 linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
 linux-kernel@vger.kernel.org, kernel@pengutronix.de,
 thomas.haemmerle@leica-geosystems.com
Subject: Re: [RESEND PATCH 1/2] dt-bindings: iio: ti,tmp117: add vcc supply
 binding
Message-ID: <20240216112120.76a0c0ca@jic23-huawei>
In-Reply-To: <20240216102820.1395815-1-m.felsch@pengutronix.de>
References: <20240216102820.1395815-1-m.felsch@pengutronix.de>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Fri, 16 Feb 2024 11:28:19 +0100
Marco Felsch <m.felsch@pengutronix.de> wrote:

> From: Thomas Haemmerle <thomas.haemmerle@leica-geosystems.com>
> 
> Add the binding to specify the vcc supply. We can't make it required
> since this would break the backward compatibility.

Given convention for supplies like this is to make them required in
the dt-binding to reflect that providing power is not optional (unlikely
some other supplies that might not be wired up) and not worry about the
fact that we happily provide dummy supplies for them if they aren't in a
particular dts, it should be fine to make it required here.

Jonathan

> 
> Signed-off-by: Thomas Haemmerle <thomas.haemmerle@leica-geosystems.com>
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> ---
> Resend since I forgot to add the DT maintainers
> 
>  .../devicetree/bindings/iio/temperature/ti,tmp117.yaml        | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/iio/temperature/ti,tmp117.yaml b/Documentation/devicetree/bindings/iio/temperature/ti,tmp117.yaml
> index 8c6d7735e875..cf7799c9734f 100644
> --- a/Documentation/devicetree/bindings/iio/temperature/ti,tmp117.yaml
> +++ b/Documentation/devicetree/bindings/iio/temperature/ti,tmp117.yaml
> @@ -24,6 +24,9 @@ properties:
>    reg:
>      maxItems: 1
>  
> +  vcc-supply:
> +    description: provide VCC power to the sensor.
> +
>  required:
>    - compatible
>    - reg
> @@ -39,5 +42,6 @@ examples:
>          tmp117@48 {
>               compatible = "ti,tmp117";
>               reg = <0x48>;
> +             vcc-supply = <&pmic_reg_3v3>;
>          };
>      };