Received-SPF: pass (google.com: domain of linux-kernel+bounces-68529-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Content-Type: multipart/signed;
 boundary=86f3d511563110b0118336ed3165a0d780ba36a3ab76703486e9fe5bdcaa;
 micalg=pgp-sha256; protocol="application/pgp-signature"
Precedence: bulk
Mime-Version: 1.0
Date: Fri, 16 Feb 2024 12:34:38 +0100
Message-Id: <CZ6GZLO63NL2.3FNHFOQ3W3JSY@gmail.com>
Subject: Re: [PATCH] soc/tegra: pmc: Add SD wake event for Tegra234
From: "Thierry Reding" <thierry.reding@gmail.com>
To: "Petlozu Pravareshwar" <petlozup@nvidia.com>, <jonathanh@nvidia.com>,
 <pshete@nvidia.com>, <p.zabel@pengutronix.de>,
 <dmitry.osipenko@collabora.com>, <ulf.hansson@linaro.org>,
 <kkartik@nvidia.com>, <cai.huoqing@linux.dev>, <spatra@nvidia.com>,
 <linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20240216080450.456135-1-petlozup@nvidia.com>
In-Reply-To: <20240216080450.456135-1-petlozup@nvidia.com>

--86f3d511563110b0118336ed3165a0d780ba36a3ab76703486e9fe5bdcaa
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8

On Fri Feb 16, 2024 at 9:04 AM CET, Petlozu Pravareshwar wrote:
> From: Prathamesh Shete <pshete@nvidia.com>
>
> Add SD wake event for Tegra234 so that system can be woken up from
> suspend when SD card hot-plug/unplug event is detected.
>
> Signed-off-by: Prathamesh Shete <pshete@nvidia.com>
> Signed-off-by: Petlozu Pravareshwar <petlozup@nvidia.com>
> ---
>  drivers/soc/tegra/pmc.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/soc/tegra/pmc.c b/drivers/soc/tegra/pmc.c
> index 6dfcc7f50ece..dc4eab3191c2 100644
> --- a/drivers/soc/tegra/pmc.c
> +++ b/drivers/soc/tegra/pmc.c
> @@ -3,7 +3,7 @@
>   * drivers/soc/tegra/pmc.c
>   *
>   * Copyright (c) 2010 Google, Inc
> - * Copyright (c) 2018-2023, NVIDIA CORPORATION. All rights reserved.
> + * Copyright (c) 2018-2024, NVIDIA CORPORATION. All rights reserved.
>   *
>   * Author:
>   *	Colin Cross <ccross@google.com>
> @@ -4199,6 +4199,7 @@ static const struct tegra_wake_event tegra234_wake_=
events[] =3D {
>  	TEGRA_WAKE_IRQ("pmu", 24, 209),
>  	TEGRA_WAKE_GPIO("power", 29, 1, TEGRA234_AON_GPIO(EE, 4)),
>  	TEGRA_WAKE_GPIO("mgbe", 56, 0, TEGRA234_MAIN_GPIO(Y, 3)),
> +	TEGRA_WAKE_GPIO("sd_wake", 8, 0, TEGRA234_MAIN_GPIO(G, 7)),

I'd prefer to stick with - instead of _ in these names, like we do with
sw-wake. No need to resend, I can make that change when applying,
provided you don't have any objections.

Thierry

>  	TEGRA_WAKE_IRQ("rtc", 73, 10),
>  	TEGRA_WAKE_IRQ("sw-wake", SW_WAKE_ID, 179),
>  };


--86f3d511563110b0118336ed3165a0d780ba36a3ab76703486e9fe5bdcaa
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmXPSE8ACgkQ3SOs138+
s6Ft2Q/7BUsouJfMl7g2EdUjU8QMD1/QRt9NHwdPr6yaDYSXnxkDwY89GScmuBaP
oF41QOLImcT+M8Z1U4GW9Kz9LjGF2d+wR4YdE3t/38jlScJf6ovO7x6Boa71ZCVQ
zddKiaLvVN93noR0nBf26LXE3tFnF8PXjQOTo80Du799k59A9S5+bk00KiDUn3pJ
zDFdmRBiHZA+DkN9fiC6l6Pc1JRKuAvBuhxr25gQBbDLAouj9xKzihcZonp5cLLS
dksI86oRJ7qC8H7lde+T6ONheQ1X+C8XT8F0ftnuYGQHDjTgTQXmEmIWtChgGTp3
PG8fTvefEIGhXpbu9QKOpMakIegSLY4rQ0dTQcpFBlbVse7z81dswG4p2BElWwy9
1isj7KPZItYGA8UCVsf3Sq7jpe4LA3u+Uof5BkAVKli0om+yUYos4MihA0mHfll7
Bd/5BEm9DwMXh6bdZDME+h+W9wjMQNFj9a0Q0hDCRHKCm6seVrCHNHIXgvoAcnzr
AuR1I5rRalVg/nxNsStj9PNCTyn1UBNJjbBmMOEkzSk/QwV05DwGpFNHzqTEl5FV
wsMHF1lJjDwoKLhfFVEpuHpTfN1xQ0cbQJrEMykYsE2KwnBUP1FiwBlmaNTo3NiK
imgyHe2Wacxh0W22lXvC72+KxRJcue3p3L+eXNacdtlTbpQr80U=
=cSkk
-----END PGP SIGNATURE-----

--86f3d511563110b0118336ed3165a0d780ba36a3ab76703486e9fe5bdcaa--