Received-SPF: pass (google.com: domain of linux-kernel+bounces-68548-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Content-Type: multipart/signed;
 boundary=9dee9a19cb63a77cc8f9975bef85216d69227f6fdf7a09b5460baac60383;
 micalg=pgp-sha256; protocol="application/pgp-signature"
Precedence: bulk
Mime-Version: 1.0
Date: Fri, 16 Feb 2024 12:53:18 +0100
Message-Id: <CZ6HDVZIGHOE.2SGOQNXEGENY3@gmail.com>
Cc: <marvin24@gmx.de>, <ac100@lists.launchpad.net>,
 <linux-tegra@vger.kernel.org>, <linux-staging@lists.linux.dev>,
 <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Staging: nvec: nvec: fixed two usleep_range is
 preferred over udelay warnings
From: "Thierry Reding" <thierry.reding@gmail.com>
To: "Nam Cao" <namcao@linutronix.de>, "Moritz C. Weber"
 <mo.c.weber@gmail.com>
References: <20240212133645.1836-1-mo.c.weber@gmail.com>
 <20240212152110.4f8fe0e6@namcao>
In-Reply-To: <20240212152110.4f8fe0e6@namcao>

--9dee9a19cb63a77cc8f9975bef85216d69227f6fdf7a09b5460baac60383
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8

On Mon Feb 12, 2024 at 3:21 PM CET, Nam Cao wrote:
> On 12/Feb/2024 Moritz C. Weber wrote:
> > Fixed a code style issue raised by checkpatch.
> > ---
> >  drivers/staging/nvec/nvec.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >=20
> > diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
> > index 2823cacde..18c5471d5 100644
> > --- a/drivers/staging/nvec/nvec.c
> > +++ b/drivers/staging/nvec/nvec.c
> > @@ -627,7 +627,7 @@ static irqreturn_t nvec_interrupt(int irq, void *de=
v)
> >  		break;
> >  	case 2:		/* first byte after command */
> >  		if (status =3D=3D (I2C_SL_IRQ | RNW | RCVD)) {
> > -			udelay(33);
> > +			usleep_range(32, 33);
> >  			if (nvec->rx->data[0] !=3D 0x01) {
> >  				dev_err(nvec->dev,
> >  					"Read without prior read command\n");
> > @@ -714,7 +714,7 @@ static irqreturn_t nvec_interrupt(int irq, void *de=
v)
> >  	 * We experience less incomplete messages with this delay than withou=
t
> >  	 * it, but we don't know why. Help is appreciated.
> >  	 */
> > -	udelay(100);
> > +	usleep_range(99, 100);
> > =20
> >  	return IRQ_HANDLED;
> >  }
>
> I have zero knowledge about this driver, but nvec_interrupt() seems to be
> a hard interrupt handler, and sleeping in an interrupt handler is a big n=
o
> no. So I think this change breaks the driver.
>
> Delaying like the driver is currently doing doesn't break things, but it =
is
> not very nice because this is interrupt handler and the processor cannot
> switch to other tasks, so delaying is wasting processor's cycles here. Th=
e
> better fix would be to figure out how to remove the delay entirely, or
> switch to threaded interrupt handler and then we can use usleep_range() i=
n
> there, but you need actual hardware to test such changes.

Also, pay attention to what else is being said in the timers-howto.rst
documentation. It specifically mentions that usleep_range() uses a range
in order to give the scheduler some leeway in coalescing with other
wakeups, so choosing a range of 32-33 us or 99-100 us isn't very useful.

Thierry

--9dee9a19cb63a77cc8f9975bef85216d69227f6fdf7a09b5460baac60383
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmXPTK4ACgkQ3SOs138+
s6HDBg/+P8CNOrCzq0UAXAn0mSLmDzBCDoTF2tNRfscugg1X/aUy1k62/Wrl3o8w
g/kk1Co+PKjv/pikrkRxGq6Hw1mB0uCNeLF9WOeJ8ijLlLmuAB/AUsC4JV9vjPyz
Wq88rVERC2yTV+Fltl7rCPBAGRusyiQsvin/ifMLdLnAvi5Oo0XXARCMzwTAT9e6
a511+LMNYQhKShvpBLxY+nK2QhkxqdO8RoPYUq28PxRUkgSp2ubV3WQmXRLoQzub
eJjdhHcCdphcToYj5qwoXYjXL70HdqJv4Ofm7dewaIXiNmPgcmBuqSfYmQQasPw8
0CbI2oe0BLNvpCv152JyHm132Vm4oT8w3Wdbbsgxh+TEufI95pNH0dJZ99/y+m7R
CRETAQWZMJZJMq0if6EttBWO36JrRNg0HbuBJNbvnxWb9zdV0UhEpB1b4Sm/bseG
xec05cKaqzbzc+D5+Wl34k0dOrhgMJKuvTsguorqaIH/kuamMWYLCCl+qhfxBwlZ
dOMGB83vevWj3F6C5TKyVk1Cu7VNzK51ydR7hukp780RvXm+DG6aUCtTAkBAQupc
e6HInnb8n/Dou8TNA+BLFQ2FRWeio9zeA7pVii0pZS0bFPIFRBoAbYdOv+2Bmcef
+MxAelYKEZlY6KLJR/6sX2QV4kqt6VzcBtuRlIu5QSyCuAS0aAY=
=ZEj0
-----END PGP SIGNATURE-----

--9dee9a19cb63a77cc8f9975bef85216d69227f6fdf7a09b5460baac60383--