Received-SPF: pass (google.com: domain of linux-kernel+bounces-68560-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <be84a28a6cdf8971a225166b8b4c865e62ee9a9d.camel@gmail.com>
Subject: Re: [net-next] net: ethernet: adi: adin1110: Reduce the MDIO_TRDONE
 poll interval
From: Nuno =?ISO-8859-1?Q?S=E1?= <noname.nuno@gmail.com>
To: Ciprian Regus <ciprian.regus@analog.com>, linux-kernel@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>, Eric Dumazet
 <edumazet@google.com>,  Jakub Kicinski <kuba@kernel.org>, Paolo Abeni
 <pabeni@redhat.com>, Simon Horman <horms@kernel.org>, Dell Jin
 <dell.jin.code@outlook.com>, Amit Kumar Mahapatra
 <amit.kumar-mahapatra@amd.com>, Yang Yingliang <yangyingliang@huawei.com>, 
 netdev@vger.kernel.org
Date: Fri, 16 Feb 2024 13:14:02 +0100
In-Reply-To: <20240216103636.1231815-1-ciprian.regus@analog.com>
References: <20240216103636.1231815-1-ciprian.regus@analog.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.3 (3.50.3-1.fc39) 
Precedence: bulk
MIME-Version: 1.0

On Fri, 2024-02-16 at 12:36 +0200, Ciprian Regus wrote:
> In order to do a clause 22 access to the PHY registers of the ADIN1110,
> we have to write the MDIO frame to the ADIN1110_MDIOACC register, and
> then poll the MDIO_TRDONE bit (for a 1) in the same register. The
> device will set this bit to 1 once the internal MDIO transaction is
> done. In practice, this bit takes ~50 - 60 us to be set.
>=20
> The first attempt to poll the bit is right after the ADIN1110_MDIOACC
> register is written, so it will always be read as 0. The next check will
> only be done after 10 ms, which will result in the MDIO transactions
> taking a long time to complete. Reduce this polling interval to 100 us.
>=20
> Signed-off-by: Ciprian Regus <ciprian.regus@analog.com>
> ---

Reviewed-by: Nuno Sa <nuno.sa@analog.com>

> =C2=A0drivers/net/ethernet/adi/adin1110.c | 4 ++--
> =C2=A01 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/net/ethernet/adi/adin1110.c
> b/drivers/net/ethernet/adi/adin1110.c
> index d7c274af6d4d..6fca19e6ae67 100644
> --- a/drivers/net/ethernet/adi/adin1110.c
> +++ b/drivers/net/ethernet/adi/adin1110.c
> @@ -467,3 +467,3 @@ static int adin1110_mdio_read(struct mii_bus *bus, in=
t phy_id,
> int reg)
> =C2=A0	ret =3D readx_poll_timeout(adin1110_read_mdio_acc, priv, val,
> -				 (val & ADIN1110_MDIO_TRDONE), 10000, 30000);
> +				 (val & ADIN1110_MDIO_TRDONE), 100, 30000);
> =C2=A0	if (ret < 0)
> @@ -498,3 +498,3 @@ static int adin1110_mdio_write(struct mii_bus *bus, i=
nt phy_id,
> =C2=A0	return readx_poll_timeout(adin1110_read_mdio_acc, priv, val,
> -				=C2=A0 (val & ADIN1110_MDIO_TRDONE), 10000, 30000);
> +				=C2=A0 (val & ADIN1110_MDIO_TRDONE), 100, 30000);
> =C2=A0}