Received: by 2002:a05:7412:1e0b:b0:fc:a2b0:25d7 with SMTP id kr11csp1069619rdb; Fri, 16 Feb 2024 04:40:33 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCW/DFjh9fuwaq6GE9BrKS0u4OAwkaT+QbthqhLeJDUrJ/gM5WecipTZsWMVCbqXQqnXySKEo+RMFWo80huLKI6rms+n+kU2p/lRnGXRXw== X-Google-Smtp-Source: AGHT+IG+Gbwf9BNUVjg3fqhjtg1L27IP4PWuGpM/VrydXW60Z05kjPrxQypsE53arzRGmUixrbRv X-Received: by 2002:a17:906:ad5:b0:a3d:b3a7:b8ce with SMTP id z21-20020a1709060ad500b00a3db3a7b8cemr2603796ejf.0.1708087233185; Fri, 16 Feb 2024 04:40:33 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708087233; cv=pass; d=google.com; s=arc-20160816; b=OcsJmo4ITiu5U3z+MKbhnSVfAkvnHScW4enGVbo8jEqigy8d+kOLbOanI+fZnsQbED 8tXe7iA4znx4g2FLTeAmvhtIRmPfu9KwL7Q49WLpmYVYqvKxYIuiPLzhDmAQCEBSPuXO EdsLy+Sio/FpAkMl39bD05gtmMvJuk+URyMyvY5vV9omcqrI6Q2PWjbD8BUVxomoEiUE Yx5U5snmmqUlO0sYraMyPL6BU/Zy2eRnUIPSoRwO1f76sEPDfrldMPARoLI6nLOH2h5M ozMRtRHTVE0J2WO0ZVSVxC591ec6ov0mR8eNDIcX9UEBbyOiOoEH09iirX+gwzevsPiL /R3g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature:dkim-signature:dkim-signature :dkim-signature; bh=8SE3qrLWVEbZxr++ON5K97v+oJUCvjFpwWzmyWT38QU=; fh=SSjgIB4wAVIw2HXofLINrpSe2C4mGQG//oHunrznjdY=; b=Yu/7LeWQrVVmp34gBA1CHulovSWPjqL+i6pZGNvUoPTHNmzDTDq5qZG9mIrgJDihv8 UyIYWL7suRyPbHKJvu76FLDemX1QjC9VWPOxehSeOTDK1NeM/tS0ga5oeeKoXRPKY2Sz 9TWjXGBzFEm4YxZocWjnduuQUitYhIAQpURxrqyWwuv4y2Ag/ff4G4fLc+nWqUrhvZZ/ I8/l1MrCx+ZW3/UGLF+eQDICNTj7eey5Pq7TKUnItW7bN/d/1xaQLfBUfyN1h7ej9RTU 9X0FGBgwLr/tz+blOhg6sL9Q+DaxJW9/z6zcyPHF6Sb7oXyAyKFE1xZ+rh9Q0ORH+mfN ZVSQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=igJDODRL; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=igJDODRL; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; arc=pass (i=1 spf=pass spfdomain=suse.de dkim=pass dkdomain=suse.de dkim=pass dkdomain=suse.de dmarc=pass fromdomain=suse.de); spf=pass (google.com: domain of linux-kernel+bounces-68589-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-68589-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id si7-20020a170906cec700b00a3d797419efsi1565907ejb.549.2024.02.16.04.40.33 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Feb 2024 04:40:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-68589-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=igJDODRL; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=igJDODRL; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; arc=pass (i=1 spf=pass spfdomain=suse.de dkim=pass dkdomain=suse.de dkim=pass dkdomain=suse.de dmarc=pass fromdomain=suse.de); spf=pass (google.com: domain of linux-kernel+bounces-68589-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-68589-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id E966D1F21A09 for ; Fri, 16 Feb 2024 12:40:32 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8AD9612881C; Fri, 16 Feb 2024 12:40:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="igJDODRL"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="g7z39LWD"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="igJDODRL"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="g7z39LWD" Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1406E58203 for ; Fri, 16 Feb 2024 12:40:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708087214; cv=none; b=AAIkyqpVOa+Fw+oW8mVEHk+zH2m+VbTP9zJQ2p9lyDiMbxO6JVTfwr4+vhw2p9ytPMGQFSUsqvPJxIDPeVTWYrNszWiFkBXcVfVpyj7u+siyfimPpnHqOa7RZmh6YCjVWp7REUqi8erq0Iy+GSOfmoIXrE7H7FVel7NbjKXF+HI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708087214; c=relaxed/simple; bh=Hq3ZrBIlPG9FIfx0LJGO9qrhRsHdz5WSBwryYJdhF2g=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jjWe5+Gi3FyYZ915hamShpf2oPLp5npqrbwv5C4D+Lmf9A5w5KUz+g0Eb7faTIzFAMV8K+IhMXbQaLf8oMk9ZKeq/74so2jvSpEVPFiq3re63uioukTYZE8yB0lAyi8vvkSqeNDMM8GobKUrStFq7yLF1AaPIUs7lAowbnml+qA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=igJDODRL; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=g7z39LWD; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=igJDODRL; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=g7z39LWD; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [10.150.64.98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 51EB61FB68; Fri, 16 Feb 2024 12:40:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1708087211; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8SE3qrLWVEbZxr++ON5K97v+oJUCvjFpwWzmyWT38QU=; b=igJDODRLJf5ZZ/kNCLeNrPbX3BK5cFBFZl1Suv1lxxiFQE9pVrEIdDgbmtuBChwp1F9Sw3 tzA7/ZiMC3iO+U73leK9yUA16P2tmSJFbQvwrtk5/0/4jSnPqDY9ZDFtvxdXd4F6+g0/xx yIqxM9y7ef87S0VbdQoeHjbYGkZy9og= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1708087211; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8SE3qrLWVEbZxr++ON5K97v+oJUCvjFpwWzmyWT38QU=; b=g7z39LWDzHF4YqaFQ8QSkxoB7wsTG42z4EvBJyUWPDpRWdWuic0dF37zbo7gLGJrvsRryj nunN3xwSgmpXxFDg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1708087211; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8SE3qrLWVEbZxr++ON5K97v+oJUCvjFpwWzmyWT38QU=; b=igJDODRLJf5ZZ/kNCLeNrPbX3BK5cFBFZl1Suv1lxxiFQE9pVrEIdDgbmtuBChwp1F9Sw3 tzA7/ZiMC3iO+U73leK9yUA16P2tmSJFbQvwrtk5/0/4jSnPqDY9ZDFtvxdXd4F6+g0/xx yIqxM9y7ef87S0VbdQoeHjbYGkZy9og= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1708087211; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8SE3qrLWVEbZxr++ON5K97v+oJUCvjFpwWzmyWT38QU=; b=g7z39LWDzHF4YqaFQ8QSkxoB7wsTG42z4EvBJyUWPDpRWdWuic0dF37zbo7gLGJrvsRryj nunN3xwSgmpXxFDg== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id 3F7A013343; Fri, 16 Feb 2024 12:40:11 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap2.dmz-prg2.suse.org with ESMTPSA id e0kPDqtXz2XTIgAAn2gu4w (envelope-from ); Fri, 16 Feb 2024 12:40:11 +0000 Date: Fri, 16 Feb 2024 13:40:10 +0100 From: Daniel Wagner To: Hannes Reinecke Cc: James Smart , Keith Busch , Christoph Hellwig , Sagi Grimberg , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: Re: [PATCH v0 5/6] nvme-fc: redesign locking and refcounting Message-ID: References: <20240216084526.14133-1-dwagner@suse.de> <20240216084526.14133-6-dwagner@suse.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Authentication-Results: smtp-out2.suse.de; none X-Spamd-Result: default: False [-3.73 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; REPLY(-4.00)[]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCPT_COUNT_SEVEN(0.00)[7]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_NOT_FQDN(0.50)[]; RCVD_TLS_ALL(0.00)[]; BAYES_HAM(-0.13)[67.32%] X-Spam-Level: X-Spam-Flag: NO X-Spam-Score: -3.73 On Fri, Feb 16, 2024 at 12:09:20PM +0100, Hannes Reinecke wrote: > Hmm. I'm a bit unsure about this; essentially you change the rport > refcounting (and not just the controller refcounting). > And the problem here is that rport refcounting is actually tied to > the driver-internal rports, which have a different lifetime > (dev_loss_tmo and all that). > > Would it be possible to break this in two, with one patch changing the > controller/options refcounting and the other one changing the rport > refcounting? Yeah, I see. I completely forgot about the dev_loss_tmo thing. I'll try to split this patch.