Received: by 2002:a05:7412:1e0b:b0:fc:a2b0:25d7 with SMTP id kr11csp1077785rdb; Fri, 16 Feb 2024 04:57:02 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCU8EW79CyXtNcO941TSYH09kYDXaxNfhBO+h3X8ByOhgEARBZF8cQgbOYoRSedMVLc1Xyu2/M1mVXGL6cOEFxc0CsRaApjbwp8o0oJ6gw== X-Google-Smtp-Source: AGHT+IEskiynH85GKsr59YBC0QwuhnAB240Uq4grPq4dG+tDf14UZRtgIez/xodwwi4NKXQk04RU X-Received: by 2002:a0c:cb12:0:b0:68f:135e:a051 with SMTP id o18-20020a0ccb12000000b0068f135ea051mr4184927qvk.56.1708088222417; Fri, 16 Feb 2024 04:57:02 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708088222; cv=pass; d=google.com; s=arc-20160816; b=u82E80ZeNeZugDCFc0SdO5R/2eVvxEK1P1PbEuvOivX8mlOYgyxKU3/4BIelYa+Lyk sXJgpe/+6/ed6ETZ0rYtoGegcMJucHuTLojr/uKoQlymcd6/QtaSYoHOH+caWAzbqZIo bEei4DwLt0DKeHZxTrTqxzHfnAU6T7OLeAW0U5SzibloKIeoPtwHNyOgbStFNNpMgCjW dt0dhrBKW7vSVaODSuil7K09pWosvxS/A8fgliWY7BfJXOEm9h1JBrQQeZW2ZGOV3cbX 8CIb22anL2zSJgQyZ2uCe/RTLs6M/DoKMTi2xYrs7kY0G4gDKSWRcQHm57wKvvDmbZp7 KtlQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=XPC9luHQLXJNvsEExYPohF2Sh1kO90QLxvjwQRI75nw=; fh=Ibc3vvLs1ePgcjJgw7Z+sNG22nP/JfFEHAoOK0awSR8=; b=gWu8SDmb7dvnAEpGkNW41hAc641ucq/T2jRAkAoy36Yf6KAlUmGho19w9YG5tpzMxQ 2cC2Ud+tNbMy3OibOMUxLVoGDPlI3nllPz+jiylfCzBQBRovdwJNbGKEVbwLJjT7cy9U C3FKlYa3w9GsmTbHqyGPhCoSfp2u+jbjYnfK7irXfow3u7GQNiZz8T5YyBIirFLsyJuJ XY3MY8Ez4ZSyL6HcVfcqcljTNZ4iMKzbN0r3FJjm5Nctk3LusKsJtIhGMV/RERBYqmMP lUsHfQtflFeyKMItEs5WUS3s3eFrKliSv6H9UW136WbS9VXMHUiE/b3LOf3o8qaN9QTH fu/A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=IzCOcGHg; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-68600-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-68600-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id ey2-20020a0562140b6200b0068cc62b0a86si3997997qvb.456.2024.02.16.04.57.02 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Feb 2024 04:57:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-68600-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=IzCOcGHg; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-68600-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-68600-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 28D791C20FB0 for ; Fri, 16 Feb 2024 12:57:02 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2530B1292CD; Fri, 16 Feb 2024 12:56:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="IzCOcGHg" Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B6E877F19 for ; Fri, 16 Feb 2024 12:56:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.15 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708088216; cv=none; b=jbFcPBx8wkPcjPBF4ma81og6aaSz3XOBWT8QH77l+ZgbeptzHo23e1IlErhqOROGE4avsksw5+r8ZumNEx6AvUjFqMgjZ+p+Bb3kViVtZ7QVbwNJvSQm8nk0xPuD/Gkn2bEGuCoVOEX+2uRfTHnzLTBWNKxgEk8MAZXurLB8pU8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708088216; c=relaxed/simple; bh=n3nIo7ta+lpOf6Vkf5nvSLxYrw9xngsA3TZcxZbTcZo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TMYRY26JnghVzpkrD59Ya1MbAlX9LY+aNhTPTvNvMPYkbeN2r0xsZEEDVefiFMgSb2L95O0TAmp5gnVuxICW1lv3xWRyoA6vzWqA5HDNbnlOQxNWCEwjKoP1M15wUW35bD3uPaQkRxeCCv8RwAdHGFub+SwoREWGAQtUeBH4a7w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=IzCOcGHg; arc=none smtp.client-ip=198.175.65.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708088214; x=1739624214; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=n3nIo7ta+lpOf6Vkf5nvSLxYrw9xngsA3TZcxZbTcZo=; b=IzCOcGHg4ZSiMGe28XTQW/YGGmW7wQD9ULJg2LiiJbnHlXnz/AznAbnv W+MKJUI3iIJOvPb0zMB3DIdwUcecp7dedV71cn8obqEjtovD2ozFvLMl/ SbnX1yJcOSWvQnEFmJPMND8/7+hNY+FyegTpJg6MqN3RqHQGu6DpHDqKA xD5V9Pyk+v5sLnnSjrpURws4ETqcEqV0RVpiTi7nzg1HF8vWqLUtDBvD8 EXC68aaZh+unMUDU+7OXoj7rhydKr6kxN+NqDAgplehk2GMuu6uUFlAcs zVNOgorQu/iS65qXaQzrId+SHdcABIxRBMT9xNKSrk/Qy589tM0BcU7KP g==; X-IronPort-AV: E=McAfee;i="6600,9927,10985"; a="6041851" X-IronPort-AV: E=Sophos;i="6.06,164,1705392000"; d="scan'208";a="6041851" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Feb 2024 04:56:54 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10985"; a="935844562" X-IronPort-AV: E=Sophos;i="6.06,164,1705392000"; d="scan'208";a="935844562" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 16 Feb 2024 04:56:49 -0800 Received: by black.fi.intel.com (Postfix, from userid 1000) id 994342E9; Fri, 16 Feb 2024 14:56:48 +0200 (EET) Date: Fri, 16 Feb 2024 14:56:48 +0200 From: "Kirill A. Shutemov" To: Rick Edgecombe Cc: Liam.Howlett@oracle.com, akpm@linux-foundation.org, debug@rivosinc.com, broonie@kernel.org, keescook@chromium.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, luto@kernel.org, peterz@infradead.org, hpa@zytor.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 3/8] mm: Use get_unmapped_area_vmflags() Message-ID: References: <20240215231332.1556787-1-rick.p.edgecombe@intel.com> <20240215231332.1556787-4-rick.p.edgecombe@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240215231332.1556787-4-rick.p.edgecombe@intel.com> On Thu, Feb 15, 2024 at 03:13:27PM -0800, Rick Edgecombe wrote: > @@ -1879,6 +1879,12 @@ get_unmapped_area(struct file *file, unsigned long addr, unsigned long len, > return error ? error : addr; > } > > +unsigned long > +get_unmapped_area(struct file *file, unsigned long addr, unsigned long len, > + unsigned long pgoff, unsigned long flags) > +{ > + return __get_unmapped_area(file, addr, len, pgoff, flags, 0); > +} > EXPORT_SYMBOL(get_unmapped_area); Any reason it is not a static inline function in the header file? -- Kiryl Shutsemau / Kirill A. Shutemov