Received: by 2002:a05:7412:1e0b:b0:fc:a2b0:25d7 with SMTP id kr11csp1102970rdb; Fri, 16 Feb 2024 05:37:35 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXrT6B2c+m148LL7U4gEkdptDNFbQMV+m35wNYPG0EmdTw9jERjbUgKVyhur83L2YcGAIFc06Ogrs6U4S18WcbqkHszzH3RJ3ugFDViNQ== X-Google-Smtp-Source: AGHT+IHmHwQ0ctkc6TpApagmxYf8AAX+5+K0uYI/CV3N+hixjln4gt+w6hvhrAnvvxJ5uhXyyc8u X-Received: by 2002:a0c:aa19:0:b0:68f:2b1a:c8de with SMTP id d25-20020a0caa19000000b0068f2b1ac8demr3498817qvb.24.1708090655502; Fri, 16 Feb 2024 05:37:35 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708090655; cv=pass; d=google.com; s=arc-20160816; b=jHq4E28ALThqYEWajrnVfr9FjKM/ZaI+vJrk1ucwL/LY8yt97NWZgsPrUD0YMQ3+U2 C2cvomosuljqk3JkqvUZiQgVRBtn0VnVhMCNzeT5JvBEn/ZtoeGyuAPXD3QlZLBN7nVf By2sKfbGKOVu0HhQNYJAQSfCsdDNDsLFH7x3ZEqGOPmLFTLVyokN96XQiQf4lIBu2++c xu14ZhWAbT88aIsFghUKfwI8LZOMzdDI7QwOqakHFtohoC4AAu0amH/HUmCw3bjRG5pj nm+qnRMgr7xGj4wCKXuFbB/vhTyZIzyTN9ml6d19vr+lfZMkQYtDdMukSx2YkiKe9Pgj PeCg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=e7mWMJkXIbMvIROqSSXDtNCbW+ZmdhTlFHhBB0TaXxE=; fh=6yCHZ3IxwNPGpOh0KbF7roVHX07sO9ryJ8yCiOPGO+U=; b=vY05y92jva9mvK9i058J7nRVG7cIsMNYMeyYsfpTv9tEb/CkWj3wm5DFEFFR/hUuiU YJpagNUMzzZGsl7cbXVSXWWnhMLWRbxs46oH/4yS18qVnnLQkLakBJ/nzNrC8LfT0hJM gSCVZSmF0JBITaWbWU4Q3AltVohHNzbU0pnJ9SqcARK5H5NF3CVwwiBNiZC/yfSqUtve rLK2NvPLQnYvqWEudFgkN4DQLjfmnAqCtIo08W89QtlR8x22jJLZOain0thNSUXWWWnQ CNXoFyYGTk5s51Z9NLfbDFaZUgEJDYu5DLrhs03iZ2IdCW3pxNtqdxJy+9i2eJpbEVHz XlJQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=oK0GGcr+; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-68646-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-68646-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id im8-20020a056214246800b0068d16bb5959si4103771qvb.609.2024.02.16.05.37.35 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Feb 2024 05:37:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-68646-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=oK0GGcr+; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-68646-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-68646-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 23A261C23B86 for ; Fri, 16 Feb 2024 13:37:35 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0B19912A157; Fri, 16 Feb 2024 13:37:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="oK0GGcr+" Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 72EAD129A6F for ; Fri, 16 Feb 2024 13:37:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708090646; cv=none; b=T1LhtkxaFm4AN785hxKM4crvl/8hJX059IF7bXiIso422qkgZ70C93O/6/FfoRMf9HkTIggL/OVfbIDzWllYZd9KdgC2WloQz+uEG6iatGKg/eYEE5zl0WBEhAVaE27WZk/GL8e32UWGs2s/bwv9ba2daFbXd/fKQh7XKJizW3o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708090646; c=relaxed/simple; bh=tBzEnpo6V6IoCla74hvhX5lK3lSzxG36T+6/aFqAzK0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=tBQIjkDWJfDb58mqQqlB9tP5jb41iARtrgeudZLTj8wmIN7NZjD8stLPAi9U7BxWJVo1BJ78G4ApgUAhgOkA50cTiHZyCpjc9Mp3425cOe/eUDqGRfsIN/706pFvOM6aaDbj/NmXPDdbz5OF4MTgqmO6dVFAZxeWVSJhitP1LrA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=oK0GGcr+; arc=none smtp.client-ip=209.85.208.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ed1-f53.google.com with SMTP id 4fb4d7f45d1cf-5620595f743so2628968a12.3 for ; Fri, 16 Feb 2024 05:37:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1708090643; x=1708695443; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=e7mWMJkXIbMvIROqSSXDtNCbW+ZmdhTlFHhBB0TaXxE=; b=oK0GGcr+00a4YBQ4s1ZbfeMtjS67Pqr9ckiM1AGc7SxRMGyAiuueFPGuJdjOUvT+9g o4IH36XRpN8s8UG0G1Mf8FLiaO03w2G1hYZi3wwGVd+oc9wnnrJBD08PncWFsz+HnsHH i4Z7S/7zvCv/hwxMh/Mj7mL/0KDzFM/thM++VHd9Ow4oWd4G+LYLHpCOAqnZl5Ac4VXx MhRQgPrQ/jkJB9Aj/Bjjk3cheoDcSMxZl3NonBD1fdqQfSTMJZ4Pxi3Ck1ayY9jpOxYr TRC1niilKRi3dWpG7ig/GSjYE4QaqGwhmucRt+0T95i2h0L6vpmUleIOa18+AAHhf0Bf WVfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708090643; x=1708695443; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=e7mWMJkXIbMvIROqSSXDtNCbW+ZmdhTlFHhBB0TaXxE=; b=Gqp3j0EMy24geemepdKPGoccT/6fsXkc7TvXsf/zkjL7kgZ9O5CdlpJZf1rV9rFxk9 OKnVUopKx9+kwnYA3wKp7uZ9yqMc9vZCh8mHIIFvB8WHi8NaB5u/wGNC6BE4f+B3mcD+ +B5a01AzMjY0R31sF92vmMwBYH/7vpbttP3550aEA15378dj0oUIfbUKo0D0uUo3vrhG vbja9fy0Y9zwVKfhCL1n+XiHGObc2ptpxN6ff20YHrCOzzLmdSVPrU3d/VhasoTNzLEo gWGk6vb1DLag3JlUl3Aoh0sFtco0d48XGEzjk/gb0NSgmgHFBLocfG5eUaj+3rGRSnUD nIlA== X-Forwarded-Encrypted: i=1; AJvYcCX/iMsr+PhhQaqEGlNLQ+1RSAhNR+60WECoQstjt8tSzm2U0BtzHIn9X0WhvMUld0HL//pogUTa1bWnVHELODXy6OYmahdr+L5vq1I/ X-Gm-Message-State: AOJu0YxPU77+q8CR8sL+YsfroBkssuZlTg0HdCzHiMxhvjEnMlUsBcgA 4IDPeACB8h38QGsr0LN7kklOLxEjybG1YwmtpUnFCP9AI8l6clIH/EVqUzSXRuo= X-Received: by 2002:a05:6402:50c:b0:563:c54e:fb with SMTP id m12-20020a056402050c00b00563c54e00fbmr160941edv.15.1708090642646; Fri, 16 Feb 2024 05:37:22 -0800 (PST) Received: from [192.168.192.135] (078088045141.garwolin.vectranet.pl. [78.88.45.141]) by smtp.gmail.com with ESMTPSA id y2-20020a50eb02000000b00561a443a393sm1495698edp.92.2024.02.16.05.37.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 Feb 2024 05:37:21 -0800 (PST) Message-ID: Date: Fri, 16 Feb 2024 14:37:19 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/2] phy: qcom: edp: Add set_mode op for configuring eDP/DP submode Content-Language: en-US To: Abel Vesa , Vinod Koul , Kishon Vijay Abraham I , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Dmitry Baryshkov , Johan Hovold Cc: linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org References: <20240216-x1e80100-phy-edp-compatible-refactor-v4-0-c07fd1a52186@linaro.org> <20240216-x1e80100-phy-edp-compatible-refactor-v4-2-c07fd1a52186@linaro.org> From: Konrad Dybcio Autocrypt: addr=konrad.dybcio@linaro.org; keydata= xsFNBF9ALYUBEADWAhxdTBWrwAgDQQzc1O/bJ5O7b6cXYxwbBd9xKP7MICh5YA0DcCjJSOum BB/OmIWU6X+LZW6P88ZmHe+KeyABLMP5s1tJNK1j4ntT7mECcWZDzafPWF4F6m4WJOG27kTJ HGWdmtO+RvadOVi6CoUDqALsmfS3MUG5Pj2Ne9+0jRg4hEnB92AyF9rW2G3qisFcwPgvatt7 TXD5E38mLyOPOUyXNj9XpDbt1hNwKQfiidmPh5e7VNAWRnW1iCMMoKqzM1Anzq7e5Afyeifz zRcQPLaqrPjnKqZGL2BKQSZDh6NkI5ZLRhhHQf61fkWcUpTp1oDC6jWVfT7hwRVIQLrrNj9G MpPzrlN4YuAqKeIer1FMt8cq64ifgTzxHzXsMcUdclzq2LTk2RXaPl6Jg/IXWqUClJHbamSk t1bfif3SnmhA6TiNvEpDKPiT3IDs42THU6ygslrBxyROQPWLI9IL1y8S6RtEh8H+NZQWZNzm UQ3imZirlPjxZtvz1BtnnBWS06e7x/UEAguj7VHCuymVgpl2Za17d1jj81YN5Rp5L9GXxkV1 aUEwONM3eCI3qcYm5JNc5X+JthZOWsbIPSC1Rhxz3JmWIwP1udr5E3oNRe9u2LIEq+wH/toH kpPDhTeMkvt4KfE5m5ercid9+ZXAqoaYLUL4HCEw+HW0DXcKDwARAQABzShLb25yYWQgRHli Y2lvIDxrb25yYWQuZHliY2lvQGxpbmFyby5vcmc+wsGOBBMBCAA4FiEEU24if9oCL2zdAAQV R4cBcg5dfFgFAmQ5bqwCGwMFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQR4cBcg5dfFjO BQ//YQV6fkbqQCceYebGg6TiisWCy8LG77zV7DB0VMIWJv7Km7Sz0QQrHQVzhEr3trNenZrf yy+o2tQOF2biICzbLM8oyQPY8B///KJTWI2khoB8IJSJq3kNG68NjPg2vkP6CMltC/X3ohAo xL2UgwN5vj74QnlNneOjc0vGbtA7zURNhTz5P/YuTudCqcAbxJkbqZM4WymjQhe0XgwHLkiH 5LHSZ31MRKp/+4Kqs4DTXMctc7vFhtUdmatAExDKw8oEz5NbskKbW+qHjW1XUcUIrxRr667V GWH6MkVceT9ZBrtLoSzMLYaQXvi3sSAup0qiJiBYszc/VOu3RbIpNLRcXN3KYuxdQAptacTE mA+5+4Y4DfC3rUSun+hWLDeac9z9jjHm5rE998OqZnOU9aztbd6zQG5VL6EKgsVXAZD4D3RP x1NaAjdA3MD06eyvbOWiA5NSzIcC8UIQvgx09xm7dThCuQYJR4Yxjd+9JPJHI6apzNZpDGvQ BBZzvwxV6L1CojUEpnilmMG1ZOTstktWpNzw3G2Gis0XihDUef0MWVsQYJAl0wfiv/0By+XK mm2zRR+l/dnzxnlbgJ5pO0imC2w0TVxLkAp0eo0LHw619finad2u6UPQAkZ4oj++iIGrJkt5 Lkn2XgB+IW8ESflz6nDY3b5KQRF8Z6XLP0+IEdLOOARkOW7yEgorBgEEAZdVAQUBAQdAwmUx xrbSCx2ksDxz7rFFGX1KmTkdRtcgC6F3NfuNYkYDAQgHwsF2BBgBCAAgFiEEU24if9oCL2zd AAQVR4cBcg5dfFgFAmQ5bvICGwwACgkQR4cBcg5dfFju1Q//Xta1ShwL0MLSC1KL1lXGXeRM 8arzfyiB5wJ9tb9U/nZvhhdfilEDLe0jKJY0RJErbdRHsalwQCrtq/1ewQpMpsRxXzAjgfRN jc4tgxRWmI+aVTzSRpywNahzZBT695hMz81cVZJoZzaV0KaMTlSnBkrviPz1nIGHYCHJxF9r cIu0GSIyUjZ/7xslxdvjpLth16H27JCWDzDqIQMtg61063gNyEyWgt1qRSaK14JIH/DoYRfn jfFQSC8bffFjat7BQGFz4ZpRavkMUFuDirn5Tf28oc5ebe2cIHp4/kajTx/7JOxWZ80U70mA cBgEeYSrYYnX+UJsSxpzLc/0sT1eRJDEhI4XIQM4ClIzpsCIN5HnVF76UQXh3a9zpwh3dk8i bhN/URmCOTH+LHNJYN/MxY8wuukq877DWB7k86pBs5IDLAXmW8v3gIDWyIcgYqb2v8QO2Mqx YMqL7UZxVLul4/JbllsQB8F/fNI8AfttmAQL9cwo6C8yDTXKdho920W4WUR9k8NT/OBqWSyk bGqMHex48FVZhexNPYOd58EY9/7mL5u0sJmo+jTeb4JBgIbFPJCFyng4HwbniWgQJZ1WqaUC nas9J77uICis2WH7N8Bs9jy0wQYezNzqS+FxoNXmDQg2jetX8en4bO2Di7Pmx0jXA4TOb9TM izWDgYvmBE8= In-Reply-To: <20240216-x1e80100-phy-edp-compatible-refactor-v4-2-c07fd1a52186@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 16.02.2024 14:02, Abel Vesa wrote: > Future platforms should not use different compatibles to differentiate > between eDP and DP mode. Instead, they should use a single compatible as > the IP block is the same. It will be the job of the controller to set the > submode of the PHY accordingly. > > The existing platforms will remain with separate compatibles for each > mode. > > Signed-off-by: Abel Vesa > --- [...] > > +static int qcom_edp_phy_set_mode(struct phy *phy, enum phy_mode mode, int submode) > +{ > + struct qcom_edp *edp = phy_get_drvdata(phy); > + > + if (mode != PHY_MODE_DP) > + return -EINVAL; > + > + edp->is_edp = submode == PHY_SUBMODE_EDP ? true : false; it's bool-converted even without the ternary operator Konrad