Received: by 2002:a05:7412:1e0b:b0:fc:a2b0:25d7 with SMTP id kr11csp1114849rdb; Fri, 16 Feb 2024 06:00:34 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVQXaTFgYXn4lbLEoifOm2y1XWOIKs5IpHQOz2b4ZZ2AA/D0elKOxezZ/KWtdDE1dMcPu7mib4NdRiL/UZVh5M6kzM9kBL8M5fS2POdVQ== X-Google-Smtp-Source: AGHT+IGHwP5ZxF6Dh5q1ym2/K0K8hrTEXuUgTmtL6snRKH3CiiSySYnxNUHUa8OsZqWcG2JSj/Bs X-Received: by 2002:a05:6a00:3d08:b0:6e0:4b47:8216 with SMTP id lo8-20020a056a003d0800b006e04b478216mr5820861pfb.16.1708092034246; Fri, 16 Feb 2024 06:00:34 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708092034; cv=pass; d=google.com; s=arc-20160816; b=Tg1S0/dcHaBVZ7NbL26KzYjdrMijAP8xfj7z+2703xUOyIDd9qSHAkWJAQOl5sRmG7 Yu9xNdVzk+2ZYCDJvKxK7SpzVUiKTTtDEevNPnOaaR6YCDWlXQysv+18/I8l/AbkAHyG vSWLQJn1duLOZ6HN82FOe6j/7uGvXS2hldhnMa8oWd41TR0H09vR3i9HW7YXQt/GDSiC PTG9Pp/1wx9xbcAQ14yBC9QCTumURls6EKEOvPSx1QvG/dDCIvFHohM/xl+xW1sZMO5C fjjcR4mIII3emdyluBxuie47+uFfpKlPjwtLQhTTWRcI6vaBRYn03ysZd9+aXLonntHk X3ug== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=udSul/eRgtJRJ6ARIbkr4NL1MgBVE7MGsgqQqJxfgPQ=; fh=IYpH4/UhLPzMl1PxC0El/+dO0/ZLJK34t2x3Gwy5JxU=; b=fTLV9msNGgNHhY/uhwvPDGyv1Y8SpAPdcL/oXA7ndTFmvUVyO4hfh7XXkSnyo2KyNx 45pY/QQ4dtTaeCBdFXkgdZgMjnxWaYBxiueU1kpP3bszB5TuEtN0heXwWnVZoNusEYUg GwicwFlAlSf6xvguYm84D57cR2XdUmF2YghJySwxlvv+Gr1t9c3hstfC4/I0lO0IKGvu AUxwx+fPSihNyMNLgw4FutOuOGrd8Ly+R9MkWHEUMHgy3QdjkayrrXhWs3v+tTqZozui +Vj6X6BjuJ5Kdo6iP/kc7LX0ObN5OszD6xuBAZ5VudfhnfJkgESnrwbQ2/VRfPFao6yI 9qIA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@bgdev-pl.20230601.gappssmtp.com header.s=20230601 header.b=D5B7Hw53; arc=pass (i=1 dkim=pass dkdomain=bgdev-pl.20230601.gappssmtp.com); spf=pass (google.com: domain of linux-kernel+bounces-68634-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-68634-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id bw39-20020a056a0204a700b005c661524f67si3177557pgb.26.2024.02.16.06.00.33 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Feb 2024 06:00:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-68634-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@bgdev-pl.20230601.gappssmtp.com header.s=20230601 header.b=D5B7Hw53; arc=pass (i=1 dkim=pass dkdomain=bgdev-pl.20230601.gappssmtp.com); spf=pass (google.com: domain of linux-kernel+bounces-68634-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-68634-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id B3DDA288EEB for ; Fri, 16 Feb 2024 13:21:21 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 352F1129A88; Fri, 16 Feb 2024 13:21:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="D5B7Hw53" Received: from mail-vk1-f175.google.com (mail-vk1-f175.google.com [209.85.221.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4340554745 for ; Fri, 16 Feb 2024 13:21:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708089676; cv=none; b=YRC/xUytLhYPvz8GEVqa47pWb2hBkBs0yKx+T4V/ai4wowrhUvuT3PwFj6xeaWPvsWUjcvMxd+eHPFXdWVEBe7phmG4kVTcM2tdAbVbI5ip2Otw36xKvicPo/hDel65g4w/7GErFQOdJtSQ5GfT57XgbUU9JBLRgJ2X0yGKGdk0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708089676; c=relaxed/simple; bh=udSul/eRgtJRJ6ARIbkr4NL1MgBVE7MGsgqQqJxfgPQ=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=AOBHjFEbgdHXsI5gZePBz2ecOM6lALcMUDnDo1xpPmOqb+RA76f9ggNumAbcJb5psox8ECY890g6rr8rWR9x77WMOmbox5TEDmXx1pEUWAxPJPOL0eTKkzb5Vap7S0zLKmeWNz24lSs2MLaI1Li0puYvGTljVXaPdvn2NmpReD8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=D5B7Hw53; arc=none smtp.client-ip=209.85.221.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Received: by mail-vk1-f175.google.com with SMTP id 71dfb90a1353d-4c020f519f7so247216e0c.0 for ; Fri, 16 Feb 2024 05:21:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1708089673; x=1708694473; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=udSul/eRgtJRJ6ARIbkr4NL1MgBVE7MGsgqQqJxfgPQ=; b=D5B7Hw532AoRkHriohZsnR4IMiOIUAhHjtXgwZuz/OGSpug3sPxDMwt0zCJQ73De9/ 3ZzyAjTphlZh01tivRvDu490p9jK5s1z3gV/3esaABUqeEqebcFvRAr6dJBgCkgDDSI2 VlnG+a70e1m/E1fxhA1NVoL13AJtaIncnWuxRvter5Nv7BvFL68MTmS5dfQ+R5oysXdB AOKHSthxdmpLZfFfjAGI2PXkpoPnVS4fD+GLNcWzME5JC50LfvlF1PlXRQuPTTFxiYPF PzT0rlfg9UO0T+4f5UyZDoXMDJgf/Z9EpIvpelf2xzm47aS1Hu3fO2NtqCXus/fDBAik tnXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708089673; x=1708694473; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=udSul/eRgtJRJ6ARIbkr4NL1MgBVE7MGsgqQqJxfgPQ=; b=rcXUiNOlqtv9oOy7uufgf5MCmfSoLt0bJKkpUjfp8wUhoXo8A/w+NpzoAIw0aadBx6 JLt9brj9RgD2+nmLytXxhcUpV3vW1TYDy8uERDCsUkJRXroY60zMgElsHRHFenxdV+u9 5tVq/SmYwbi8HC/CPXSXoOrd3+rdJQx1huwdDTLeDg4KbznXT1LzHo2Clnx0E8bR99va 9ZSTX3YEEi+Zdp9dvIyCuLeID4odlEhnmM2IvYqm9+AgzYxaOmTT3NmemcOy7XCK7iRD ayIpX9mMnTNiQ2QkphHSMY8n57G6jPCpqrdxDVx5bikOdeLwlGsllUArgWLGPPu3sIhD IEDg== X-Forwarded-Encrypted: i=1; AJvYcCUxccUvxtRRTBo/KLaV6+g5gFQGDTrXUE3BSHxaVUfcOQe7I11Omf+QNCnmgWCqf7H4fPu4e0ta9JyDjCkFoWvzBfvpZcj7AyLrMbDv X-Gm-Message-State: AOJu0YwqrNkl8k1NkYRLHJYf8+hxqqeniGYKZIKopsg3NIK7JckSxlGd 2cRelkwDjdWoPWd7eWGUA3lv07x2x1b0CbGexFqOC/otchcbXkWGKFeKdCRj3QrMdxy03Eqm2Nx 8bAJwhNYiIBUg17nW8SmFk1oMsSjYrzAdN1z9SA== X-Received: by 2002:a1f:e043:0:b0:4c0:5e95:b9f3 with SMTP id x64-20020a1fe043000000b004c05e95b9f3mr4382436vkg.5.1708089673107; Fri, 16 Feb 2024 05:21:13 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240216105930.16265-1-brgl@bgdev.pl> <1542ef65-508b-45be-ad5c-63ad124cb1a2@samsung.com> In-Reply-To: <1542ef65-508b-45be-ad5c-63ad124cb1a2@samsung.com> From: Bartosz Golaszewski Date: Fri, 16 Feb 2024 14:21:02 +0100 Message-ID: Subject: Re: [PATCH] gpio: cdev: fix a NULL-pointer dereference with DEBUG enabled To: Marek Szyprowski Cc: Kent Gibson , Linus Walleij , "Paul E . McKenney" , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Feb 16, 2024 at 1:35=E2=80=AFPM Marek Szyprowski wrote: > > On 16.02.2024 11:59, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski > > > > We are actually passing the gc pointer to chip_dbg() so we have to > > srcu_dereference() it. > > > > Fixes: 8574b5b47610 ("gpio: cdev: use correct pointer accessors with SR= CU") > > Reported-by: Marek Szyprowski > > Closes: https://lore.kernel.org/lkml/179caa10-5f86-4707-8bb0-fe1b316326= d6@samsung.com/ > > Signed-off-by: Bartosz Golaszewski > Tested-by: Marek Szyprowski Thanks, patch applied. Bart [snip]