Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754328AbXL0SCx (ORCPT ); Thu, 27 Dec 2007 13:02:53 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753991AbXL0SBy (ORCPT ); Thu, 27 Dec 2007 13:01:54 -0500 Received: from idcmail-mo1so.shaw.ca ([24.71.223.10]:6494 "EHLO pd4mo1so.prod.shaw.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753657AbXL0SBi (ORCPT ); Thu, 27 Dec 2007 13:01:38 -0500 Date: Thu, 27 Dec 2007 11:59:23 -0600 From: Robert Hancock Subject: Re: [Patch v2] Make PCI extended config space (MMCONFIG) a driver opt-in In-reply-to: To: Arjan van de Ven Cc: Jeff Garzik , linux-kernel@vger.kernel.org, Linus Torvalds , gregkh@suse.de, linux-pci@atrey.karlin.mff.cuni.cz, Benjamin Herrenschmidt , Martin Mares , Matthew Wilcox Message-id: <4773E7FB.2020000@shaw.ca> MIME-version: 1.0 Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 7bit References: User-Agent: Thunderbird 2.0.0.9 (Windows/20071031) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1418 Lines: 38 Arjan van de Ven wrote: >> 2) [non-minor] hmmmm. >> >> [jgarzik@core ~]$ lspci -n | wc -l >> 23 >> >> So I would have to perform 23 sysfs twiddles, before I could obtain a >> full and unabridged 'lspci -vvvxxx'? > > not you as human, but "lspci" ought to yes. > >> For the userspace interface, the most-often-used knob for diagnostic >> purposes will be the easiest one. And that's > > the easiest one is an option to lspci. Nothing more nothing less. > > Making a global knob in kernel space is a lot more tricky, and in addition > really there's enough cases where userspace wants the one device anyway > Doing the "for each device I'm about to dump" in lspci is pretty much as hard as doing > the global one (if not simpler) So then if you have a system where MMCONFIG doesn't work and you're not using any devices that require extended config space, then doing lspci -vvvxxx will blow up the machine? Yuck. Still don't like this approach. It seems like (partially) covering up problems rather than solving them. -- Robert Hancock Saskatoon, SK, Canada To email, remove "nospam" from hancockr@nospamshaw.ca Home Page: http://www.roberthancock.com/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/