Received: by 2002:a05:7412:1e0b:b0:fc:a2b0:25d7 with SMTP id kr11csp1148595rdb; Fri, 16 Feb 2024 06:52:31 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXbXQCmzI7L14ds90ur4w2YLbXU5y01r9FFPQftz9SNMFGvXJxIxshrCNJEKWD6fa+YLg0QsEpLmSIV11rdB9a4q7YpeJ3+zglhK9owyQ== X-Google-Smtp-Source: AGHT+IEh5BwueuLB9eLoTe9QQaGgFFYxylJ9J2J5MqDxKwWFKENG/6a3mR9zXBjY87xCXzazQS5D X-Received: by 2002:a9d:784e:0:b0:6e2:f471:d748 with SMTP id c14-20020a9d784e000000b006e2f471d748mr5306887otm.29.1708095151661; Fri, 16 Feb 2024 06:52:31 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708095151; cv=pass; d=google.com; s=arc-20160816; b=NNWo7ahrIbMJiE6fSaT6Ss4CrBgoHmuUjeYWrSL+BExLlOm7RGoanAQMgMrI8Jy6VT dLl1gHwiTIguOAWl1kl2O01IiOdmYJgvmVBelAfd2DxBWHFftuJRMX70HQUkR+k0TKoZ 2QXZuc+wfLt9aYvBdbiylLiphXd/O8jxWWiLHzz9e96QHuH8ZBHhxAIrTOs4o5hUFsYk KScNuqBPvMYzmOKpFPOUO5NsTvKYw6Xc1OaOl6oRopOaIDNmDsKhP3e81ssFJWgGkBzA sQuYgQHmdKhr3PISVSQOIxLYf2cDv3RuL7nRrw6X361hb1AijLG4EwcyQjdb+3OYnbd3 J7qg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=kQ97dKft5WrF7BNUwY/j9weG3NyrlqoJSdM7ZhHZjIA=; fh=EEJZPK5F9KcAQtpYmsDnqp2FnYMqqdYgq/ecaXsj2/o=; b=y3740DhZABZeS4l5uAbrZfnMPQ+13PEfQ0in+KPtGYSCV+/Sxn6nY7jr9hIfYqwxBA lVstOOhGAoLBa+tZ7ImBhWs0xppgofN4PCime83nCOyC+h0Yp6ZdnsQ31mj8ZyjemhBU OBB1S+HHkF+nySRtYDqCU/wL1kqKAf7Xe7/xLr0GemkzsjR8qzdAtWJjr68e2B2xrqOY sI0kicviYZudYvZqwMkju8yr9nst6tZQlURg7by2G94i+vFIpIvSfrsDSUX410HFQhDd 2KMzOa9aMp1kj1iwz/Vp3cqwSDWffB0mlacFM7eoZYbHBNShPpZCvqvLIzUZraMybjcc uZww==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=p6zY6U3z; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-68764-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-68764-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id b13-20020ac8540d000000b0042c6d930f8csi3820685qtq.382.2024.02.16.06.52.31 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Feb 2024 06:52:31 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-68764-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=p6zY6U3z; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-68764-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-68764-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 297951C21AC9 for ; Fri, 16 Feb 2024 14:52:31 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id ADE4F12F371; Fri, 16 Feb 2024 14:52:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="p6zY6U3z" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D02E912EBF7; Fri, 16 Feb 2024 14:52:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708095139; cv=none; b=m+If3o+7Depk7k6aqPzhK//dBvxeZ846IVACUZvHHjeSy6C93Ue2T6BbDfWBkGuPMYrWhmlgzb4hTDJ/xCmRK8EIvNc/MyEL/jq/FyOPGij/XgpwJA+DlJQR6lyuei8kWNier14iLFIHuUzx2udCGr632oujyiHMbz8nSfeOjac= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708095139; c=relaxed/simple; bh=bUtgLau8oqAzmALl7r4ZTuGib2lzrEo5ddgEED7CwzE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DKfeEZKokd8epS8oCtiNS/5MlUnFMZNlyP53kyzqfWxLGs+LqUfLgrTmnE5AUMwK8Yq93yMWfTrB4G2uT/pQIP4z4q6kIwvlrxy9UN9dpzPCiR3qgvU8olutoBFoPLsmbikI2vVzE18SUYD/evrzh6B2DCIsEl86OIqbbiH9c5M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=p6zY6U3z; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 75C78C433F1; Fri, 16 Feb 2024 14:52:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708095139; bh=bUtgLau8oqAzmALl7r4ZTuGib2lzrEo5ddgEED7CwzE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=p6zY6U3zj3ZrM2WG/PaoBQd+eQ5hktTIkzgZYbyGLxo6cmWVcR4BfE7VcQ2rOe/DL C2pyY3bVx+AT90EmcHAef2orXOZ1CvhjwfbPJTvrC2jO+yCrxe1bco7wkKYNWF+Xfi se2aG2OVaKj1yHeZt1cnRS7DB/i0DrpAvg7d7oH9YHnEGoCmfrLQyGiq+dTyglvyGK ZpdROl37gjLWO1UpEwZ7SDMrHHBP0pYm88e6MWSKs7cWuxq3TTwOqf7826l0yyHNdC shmkIkBKp74w4/p3iqE5doEYJ3HZpMdY8DoDpCHWDsd/t2Ei5afpo4kYU44eBLyFIK yUDHdjiAh03ZQ== Date: Fri, 16 Feb 2024 15:52:13 +0100 From: Christian Brauner To: Eric Dumazet Cc: Greg Kroah-Hartman , linux-kernel , "Rafael J . Wysocki" , Andrew Morton , netdev@vger.kernel.org, "David S . Miller" , Jakub Kicinski , Paolo Abeni , Eric Dumazet Subject: Re: [PATCH 1/2] kobject: make uevent_seqnum atomic Message-ID: <20240216-fluggast-wohnt-17a30f7420d4@brauner> References: <20240214084829.684541-1-edumazet@google.com> <20240214084829.684541-2-edumazet@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240214084829.684541-2-edumazet@google.com> On Wed, Feb 14, 2024 at 08:48:28AM +0000, Eric Dumazet wrote: > We will soon no longer acquire uevent_sock_mutex > for most kobject_uevent_net_broadcast() calls, > and also while calling uevent_net_broadcast(). > > Make uevent_seqnum an atomic64_t to get its own protection. > > This fixes a race while reading /sys/kernel/uevent_seqnum. > > Signed-off-by: Eric Dumazet > Cc: Greg Kroah-Hartman > Cc: Christian Brauner > --- Nice, Reviewed-by: Christian Brauner