Received: by 2002:a05:7412:1e0b:b0:fc:a2b0:25d7 with SMTP id kr11csp1157799rdb; Fri, 16 Feb 2024 07:05:55 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCUyDXWQD/nc7KIx4Th6VGyZWNwp6XHjnXnFE/Oq/VvYfwb/AYsZJ0CeZTC+LWIFyGe031wOZdaeTUoW2y/1ATRzSxoswELBtm/fzpvBrw== X-Google-Smtp-Source: AGHT+IHQHecv4OsuH4GvXf70dYFcvYuJdYAnLxE+/UOEky1EwxmQsahlYLbZgZOJTVmRtoN1mYnR X-Received: by 2002:a17:902:ec8d:b0:1d8:ee28:a305 with SMTP id x13-20020a170902ec8d00b001d8ee28a305mr6138028plg.54.1708095955378; Fri, 16 Feb 2024 07:05:55 -0800 (PST) Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id lv3-20020a1709032a8300b001db6dfc5c39si3228713plb.334.2024.02.16.07.05.55 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Feb 2024 07:05:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-68769-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; arc=fail (body hash mismatch); spf=pass (google.com: domain of linux-kernel+bounces-68769-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-68769-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 2C6B2289F67 for ; Fri, 16 Feb 2024 14:56:44 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id AFB6012F37D; Fri, 16 Feb 2024 14:56:34 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B18D312EBE2; Fri, 16 Feb 2024 14:56:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708095394; cv=none; b=BTN3RffHfCrQ2EGSUjnklWFc2YGKNFJQPij/TeGSF2FXmJhNcSRi7hEZMkTaeLH1tNV5d7jbHqIBDMz1MKoV/igfYNrBcQJzmvfpPH688xVtA2UaDd2+GhZ10zaHDJYBVLQzyWhDovlNEMdWnRXHFgcfrCBbYfpEhr9vEnw4djY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708095394; c=relaxed/simple; bh=uU5ex5sFczwr9eLJc4HYmer9AHvonlJknY9TibazMSk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FUEe5ST1VJg4fNKoBAp9hW+UNHz6mh/ILDm8ly25s8QtbesQpdUlMCPUMKRE9TQdORJWzRPu7FJbrC1UAAHSejuCG4CEUiYJ08FU5mygOulagfHLmJGQDI3r78tULoz7Sj5N8INlKwLgxP1xNFiib4C7am9YRlk01clEeElTsHY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org; spf=fail smtp.mailfrom=kernel.org; arc=none smtp.client-ip=198.175.65.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=kernel.org X-IronPort-AV: E=McAfee;i="6600,9927,10985"; a="2336760" X-IronPort-AV: E=Sophos;i="6.06,164,1705392000"; d="scan'208";a="2336760" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Feb 2024 06:56:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10985"; a="912372670" X-IronPort-AV: E=Sophos;i="6.06,164,1705392000"; d="scan'208";a="912372670" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Feb 2024 06:56:25 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1razdW-000000054ij-1AX9; Fri, 16 Feb 2024 16:56:22 +0200 Date: Fri, 16 Feb 2024 16:56:22 +0200 From: Andy Shevchenko To: Vinod Koul Cc: Thomas Richard , Linus Walleij , Bartosz Golaszewski , Tony Lindgren , Haojian Zhuang , Vignesh R , Aaro Koskinen , Janusz Krzysztofik , Andi Shyti , Peter Rosin , Kishon Vijay Abraham I , Philipp Zabel , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-i2c@vger.kernel.org, linux-phy@lists.infradead.org, linux-pci@vger.kernel.org, gregory.clement@bootlin.com, theo.lebrun@bootlin.com, thomas.petazzoni@bootlin.com, u-kumar1@ti.com Subject: Re: [PATCH v3 08/18] phy: ti: phy-j721e-wiz: split wiz_clock_init() function Message-ID: References: <20240102-j7200-pcie-s2r-v3-0-5c2e4a3fac1f@bootlin.com> <20240102-j7200-pcie-s2r-v3-8-5c2e4a3fac1f@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Fri, Feb 16, 2024 at 11:32:31AM +0530, Vinod Koul wrote: > On 15-02-24, 17:43, Andy Shevchenko wrote: > > On Thu, Feb 15, 2024 at 04:17:53PM +0100, Thomas Richard wrote: .. > > (Side note, as this can be done later) > > > > > if (rate >= 100000000) > > > > > + if (rate >= 100000000) > > > > > + if (rate >= 100000000) > > > > I would make local definition and use it, we may get the global one as there > > are users. > > > > #define HZ_PER_GHZ 1000000000UL > > Better to define as: > #define HZ_PER_GHZ 1 * GIGA (with parentheses) Maybe here, but when it appears in units.h it will be defined as I wrote to be aligned with the rest of definitions. -- With Best Regards, Andy Shevchenko