Received-SPF: pass (google.com: domain of linux-kernel+bounces-68774-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Fri, 16 Feb 2024 10:00:08 -0500
From: Frank Li <Frank.li@nxp.com>
To: Vinod Koul <vkoul@kernel.org>
Cc: "open list:DMA GENERIC OFFLOAD ENGINE SUBSYSTEM" <dmaengine@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>, imx@lists.linux.dev
Subject: Re: [PATCH 1/1] dmaengine: fsl-qdma: add __iomem and struct in union
 to fix sparse warning
Message-ID: <Zc94eDQf77fyS/k4@lizhi-Precision-Tower-5810>
References: <20240209210837.304873-1-Frank.Li@nxp.com>
 <Zc9WGbgscNeqmuvk@matsya>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Zc9WGbgscNeqmuvk@matsya>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?Q+EaZzv07XPemZKAGYxZfI3E7N4oS7PU8MWffzoWXhRMc8hMUnzZHjfhb52t?=
 =?us-ascii?Q?C1yrHhqFyrQWAf1HcKh8skbOlWYjWKmoiDTUG7LCwz2JmYp5mTbtRz4Nmjoo?=
 =?us-ascii?Q?084NuxPp/z7tQBqeLRcif2ac6fYQemDNDC55mL2MkZ5hBvXdSo2/QFQua+Id?=
 =?us-ascii?Q?8ixBbPBBlpyP2b1eLrUcZqO5ha5TKI9v0RMNH09Po0VVwYQgUkMKmdGHBsmR?=
 =?us-ascii?Q?tYSRiH2dMEl/fRXIzW4mCONC0PpwGWiSVzpGH+KEuyp3oXkHJ7Q9/6b/lk6I?=
 =?us-ascii?Q?6eLXws0rWQnj3N+6c7Q2kNCt/5pKLXhaRZj/9OKPGOHKg+5NlyeKv8JmP3ln?=
 =?us-ascii?Q?2WqOGgg9Iklgd6Or5nZlfPIXAgPNdXzKdCxc9DBq/H8Wt+oltkslhTyPccCE?=
 =?us-ascii?Q?lF9NZxPFMaEXNExvUOGPRiVS9IzXeTyACHpRSr96uhtsEhDpcJqyS+ZlbCWm?=
 =?us-ascii?Q?eHvq1+AHOReHaLvNlMSy8uKPJiTbRU9Vx4Gs2pQiaUnK+X2OM2t64yMkuePy?=
 =?us-ascii?Q?kikk0+/9IvuLSXyRG9UDRPsYNWpruYiYIJIflr4Ad5StmIoVNO87SB1uchQW?=
 =?us-ascii?Q?F51/OqXgCsjAH5sSDS5tU7LPYZoQknhK3kWIDjhRdKmrmZaQrbEp7hK0AZ4D?=
 =?us-ascii?Q?i9VcRTnYUko6psj7eMeSuvQgCN2uHWFUge6NGDME3g8VSrGrB2jrgeHz6o7t?=
 =?us-ascii?Q?aYaiZoUH/6Kw4KW8W9hO2VU0HQi3gOT6XMAdcpZAplJGmTH912xivEDneGhR?=
 =?us-ascii?Q?G6i0nVvwX8MW8yoEI4Lym3VJXwR8f/bMC3TQpOxXqjRXwKuAB94WwkF8FzMJ?=
 =?us-ascii?Q?vUIet6TNdOmmhEfrAuYvSJ2CmeLSa0zmTGtVdI7gIbFEwxLchMeh9dd7gsro?=
 =?us-ascii?Q?XqIgeNckpWIEGnliy9cDTbQPQXW+370vT7Gig3khh3k+liTV7o0PJnSwnVzg?=
 =?us-ascii?Q?XW6fgZ4KCMF8ZtdruF7EafvQeAAiEuK/ngsnCQB5xTv/QHH9YAw78qxwgjuA?=
 =?us-ascii?Q?HXwjSWL27BP1MR2LukIzo+WCx3xcN/shD1RglZG+Z+atTeqRxDUfdtBHUClG?=
 =?us-ascii?Q?5lMcyQx38Umal5QNZUXl6TnmDFGPZmhAKNcmjQ1lnxHZ/k8uI1vsTCcX228w?=
 =?us-ascii?Q?UmpSpvu+UyVebgtzfFRZtQtT89Jwj/yLKGwB7FvjTy2eWM4yEgBJSYAr0Cb3?=
 =?us-ascii?Q?GQ2RwIjn0Kp7nTBew9WXHylRzH0opDAaF945n+tI1hfLsdz847hhsAjAyB8C?=
 =?us-ascii?Q?FY2jF/WNlbpkrSJT5molQoT5rgrYoosrYVA/dA87dm3qJ8Dkh9wZIXTxMqsL?=
 =?us-ascii?Q?aU+NtR3f2ubNa6t8239sxZZXOos6gj8f/GP97gFU5QCZ5GfyezFVkGjn+Osr?=
 =?us-ascii?Q?u7m+TzkNDJKeFsMxBAF67CyrJ/8qFagaidyCpT0tdVC6qBI0YJPBqsH0W8/w?=
 =?us-ascii?Q?HFLqmRroYu+a+4AZq++jEQJ7vedZRboIgn78kOskBgU9+Ep2gh3cWwyhBlyS?=
 =?us-ascii?Q?Riri/vaU2CzeGEu6qTrsdOLHRzF31FglC3Ai5N/cJmXJq6WW2qM9CCEjFJQq?=
 =?us-ascii?Q?WU4z5bspyQSoKYdlrnK+sH8JZoprqqABC9vVqYG6?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fae122ed-8f75-48ea-41f7-08dc2efffbd5
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2024 15:00:15.7529
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: raTBpeyilJSoApW5cd/3vqw4tx6zwpGY0ILcu9mAktiGpbbz7NaVU3od1Iiw1pZLmniyvAH1YZS1JVjPkEve6A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8689

On Fri, Feb 16, 2024 at 06:03:29PM +0530, Vinod Koul wrote:
> On 09-02-24, 16:08, Frank Li wrote:
> > Fix below sparse warnings.
> > 
> > drivers/dma/fsl-qdma.c:645:50: sparse: warning: incorrect type in argument 2 (different address spaces)
> > drivers/dma/fsl-qdma.c:645:50: sparse:    expected void [noderef] __iomem *addr
> > drivers/dma/fsl-qdma.c:645:50: sparse:    got void
> > 
> > drivers/dma/fsl-qdma.c:387:15: sparse: sparse: restricted __le32 degrades to integer
> > drivers/dma/fsl-qdma.c:390:19: sparse:     expected restricted __le64 [usertype] data
> > drivers/dma/fsl-qdma.c:392:13: sparse:     expected unsigned int [assigned] [usertype] cmd
> 
> Please document why you are adding the annotations

Okay, I will add at next version.

> 
> Also I see this after the patch:

Strange!, it is difference driver (fsl-qdma.c, which will not touch
fsl-edma*). the below warning should exist or invovled by other patches.

Did you try antoher patches
https://lore.kernel.org/imx/20240209213606.367025-1-Frank.Li@nxp.com/T/#t

what's command do you build to see below warning.

Frank

> 
> dmaengine/drivers/dma/fsl-edma-main.c:56:16: warning: cast removes address space '__iomem' of expression
> dmaengine/drivers/dma/fsl-edma-main.c:60:9: warning: cast removes address space '__iomem' of expression
> dmaengine/drivers/dma/fsl-edma-common.c:76:15: warning: cast removes address space '__iomem' of expression
> dmaengine/drivers/dma/fsl-edma-common.c:93:9: warning: cast removes address space '__iomem' of expression
> dmaengine/drivers/dma/fsl-edma-common.c:100:22: warning: cast removes address space '__iomem' of expression
> dmaengine/drivers/dma/fsl-edma-common.c:101:25: warning: cast removes address space '__iomem' of expression
> dmaengine/drivers/dma/fsl-edma-common.c:104:15: warning: cast removes address space '__iomem' of expression
> dmaengine/drivers/dma/fsl-edma-common.c:106:9: warning: cast removes address space '__iomem' of expression
> dmaengine/drivers/dma/fsl-edma-common.c:131:19: warning: cast removes address space '__iomem' of expression
> dmaengine/drivers/dma/fsl-edma-common.c:137:17: warning: cast removes address space '__iomem' of expression
> dmaengine/drivers/dma/fsl-edma-common.c:140:9: warning: cast removes address space '__iomem' of expression
>   CC [M]  drivers/dma/idma64.o
> dmaengine/drivers/dma/fsl-edma-common.c:473:17: warning: cast removes address space '__iomem' of expression
> dmaengine/drivers/dma/fsl-edma-common.c:473:17: warning: cast removes address space '__iomem' of expression
> 
> > 
> > Reported-by: kernel test robot <lkp@intel.com>
> > Closes: https://lore.kernel.org/oe-kbuild-all/202402081929.mggOTHaZ-lkp@intel.com/
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > ---
> >  drivers/dma/fsl-qdma.c | 21 ++++++++++-----------
> >  1 file changed, 10 insertions(+), 11 deletions(-)
> > 
> > diff --git a/drivers/dma/fsl-qdma.c b/drivers/dma/fsl-qdma.c
> > index 1e3bf6f30f784..5005e138fc239 100644
> > --- a/drivers/dma/fsl-qdma.c
> > +++ b/drivers/dma/fsl-qdma.c
> > @@ -161,6 +161,10 @@ struct fsl_qdma_format {
> >  			u8 __reserved1[2];
> >  			u8 cfg8b_w1;
> >  		} __packed;
> > +		struct {
> > +			__le32 __reserved2;
> > +			__le32 cmd;
> > +		} __packed;
> >  		__le64 data;
> >  	};
> >  } __packed;
> > @@ -355,7 +359,6 @@ static void fsl_qdma_free_chan_resources(struct dma_chan *chan)
> >  static void fsl_qdma_comp_fill_memcpy(struct fsl_qdma_comp *fsl_comp,
> >  				      dma_addr_t dst, dma_addr_t src, u32 len)
> >  {
> > -	u32 cmd;
> >  	struct fsl_qdma_format *sdf, *ddf;
> >  	struct fsl_qdma_format *ccdf, *csgf_desc, *csgf_src, *csgf_dest;
> >  
> > @@ -384,15 +387,11 @@ static void fsl_qdma_comp_fill_memcpy(struct fsl_qdma_comp *fsl_comp,
> >  	/* This entry is the last entry. */
> >  	qdma_csgf_set_f(csgf_dest, len);
> >  	/* Descriptor Buffer */
> > -	cmd = cpu_to_le32(FSL_QDMA_CMD_RWTTYPE <<
> > -			  FSL_QDMA_CMD_RWTTYPE_OFFSET) |
> > -			  FSL_QDMA_CMD_PF;
> > -	sdf->data = QDMA_SDDF_CMD(cmd);
> > -
> > -	cmd = cpu_to_le32(FSL_QDMA_CMD_RWTTYPE <<
> > -			  FSL_QDMA_CMD_RWTTYPE_OFFSET);
> > -	cmd |= cpu_to_le32(FSL_QDMA_CMD_LWC << FSL_QDMA_CMD_LWC_OFFSET);
> > -	ddf->data = QDMA_SDDF_CMD(cmd);
> > +	sdf->cmd = cpu_to_le32((FSL_QDMA_CMD_RWTTYPE << FSL_QDMA_CMD_RWTTYPE_OFFSET) |
> > +			       FSL_QDMA_CMD_PF);
> > +
> > +	ddf->cmd = cpu_to_le32((FSL_QDMA_CMD_RWTTYPE << FSL_QDMA_CMD_RWTTYPE_OFFSET) |
> > +			       (FSL_QDMA_CMD_LWC << FSL_QDMA_CMD_LWC_OFFSET));
> >  }
> >  
> >  /*
> > @@ -626,7 +625,7 @@ static int fsl_qdma_halt(struct fsl_qdma_engine *fsl_qdma)
> >  
> >  static int
> >  fsl_qdma_queue_transfer_complete(struct fsl_qdma_engine *fsl_qdma,
> > -				 void *block,
> > +				 __iomem void *block,
> >  				 int id)
> >  {
> >  	bool duplicate;
> > -- 
> > 2.34.1
> 
> -- 
> ~Vinod