Received-SPF: pass (google.com: domain of linux-kernel+bounces-68778-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Received-SPF: Pass (protection.outlook.com: domain of topic.nl designates
 20.93.157.195 as permitted sender) receiver=protection.outlook.com;
 client-ip=20.93.157.195; helo=westeu11-emailsignatures-cloud.codetwo.com;
 pr=C
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=topic.nl;
Message-ID: <14f92c6d-7c26-437c-aaa7-9b6691cb3042@topic.nl>
Date: Fri, 16 Feb 2024 16:04:45 +0100
User-Agent: Mozilla Thunderbird
From: Mike Looijmans <mike.looijmans@topic.nl>
Subject: Re: [PATCH v4 2/2] iio: adc: ti-ads1298: Add driver
Content-Language: en-US, nl
To: Jonathan Cameron <jic23@kernel.org>
CC: devicetree@vger.kernel.org, linux-iio@vger.kernel.org,
 Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
 Lars-Peter Clausen <lars@metafoo.de>, Liam Beguin <liambeguin@gmail.com>,
 Liam Girdwood <lgirdwood@gmail.com>, Maksim Kiselev <bigunclemax@gmail.com>,
 Marcus Folkesson <marcus.folkesson@gmail.com>,
 Marius Cristea <marius.cristea@microchip.com>,
 Mark Brown <broonie@kernel.org>, Niklas Schnelle <schnelle@linux.ibm.com>,
 Okan Sahin <okan.sahin@analog.com>, linux-kernel@vger.kernel.org
References: <20240214063736.88283-1-mike.looijmans@topic.nl>
 <1b153bce-a66a-45ee-a5c6-963ea6fb1c82.949ef384-8293-46b8-903f-40a477c056ae.da2f422c-5c6b-41b4-8916-d1a90f0f0973@emailsignatures365.codetwo.com>
 <20240214063736.88283-2-mike.looijmans@topic.nl>
 <20240216133816.18c42c99@jic23-huawei>
Organization: Topic
In-Reply-To: <20240216133816.18c42c99@jic23-huawei>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
MIME-Version: 1.0
X-Microsoft-Antispam-Message-Info-Original:
 kQHywVQczUJlMz0evUsH0z+rU214MydckbRky9kQXu4SE2kCDfwWxYQ57wmu9RBBvgk7X8vl5CeTLbN/MRNY1juJg7pCI3cXqmqu0Uas7LLZwqFA/oRY15Ce+PPIkDDAQJmuhQIFFj+DluxP7QoIGhla938RYtP6yLtsIZKoeC2OQoqQIYLDzlNjw4WJ0W1GxG2Pc+QfaF5iUKFQvBfrYfCbF6XImWe1GpYCFplaJwc4jlX7rnTFDynWfmWgbL/tyvoBF4JQhU13pzFefLA/FipR+yIBoDYRuKPGOdq+sheq06ws7VGKFBnQvt2gU2YwqKb/RmdFskL30Ky9/WGuDoqUdr2//hZqSGHjLgxZwJhpAuR5+VqDbQTq77cpjxwEQE55hkWdDCZZ0j5frHnYB1a0mtkHqJ51FOijQaH1wIHpjG0fdThNJKPzY7/F4pYcLVDpgr9J8NPL54nK4/AZwqQJfd5NGkDVz4EfdLVr7TbAGL6c/gcxZGPxy36K26ga+bban3/ljOLQynCvp2xL9kUgk52Ugk3pe9338GrbKYjP5sU/MGoR1ORzh+/l/9QYjFnfI+P/ibavhgcgrCdb/8lO0c3t04JIqawKv93TTHE=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB8644.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(396003)(376002)(39830400003)(366004)(346002)(136003)(230922051799003)(451199024)(186009)(64100799003)(1800799012)(31686004)(478600001)(6512007)(41300700001)(6486002)(7416002)(44832011)(8676002)(8936002)(4326008)(5660300002)(2906002)(36916002)(6506007)(38350700005)(316002)(52116002)(53546011)(66556008)(66476007)(54906003)(66946007)(6916009)(83380400001)(15974865002)(31696002)(2616005)(26005)(38100700002)(36756003)(86362001);DIR:OUT;SFP:1102;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB9859
X-CodeTwo-MessageID: a8ff0e3e-4cef-41c9-b468-216565b5e2d9.20240216150449@westeu11-emailsignatures-cloud.codetwo.com
X-CodeTwoProcessed: true
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AMS0EPF000001A2.eurprd05.prod.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	2939d137-ec93-4c7c-dd35-08dc2f009cb4
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	yijI5kSD7L5otLWHgo6IyI38JHSCihYr+Io+S+2hC3B354L2hwOwbfFJE+v2Y5MZjMxoAMihOqFCOVcgHPtt2ZMAndpZCbMt+det8rBsLwHsBdlBwBmBRy9rBbN+qCV+j1Qh6RkCxcrbqzii98w85dKFyo3qW4f8Dr91ClzyMpuvemh2i1+xN26zNG6WwDl2FhTx6tcn22qfMgscs/B7k+QNcJmD24aMtAaQ8J+zKrD2GrZJGMPDk9XwSXaIqfhId5q1utUI5aj/bzPq9nuiPyYSWORxTMOu9lWqVt9BGF/wx9Kh7q7l6yMiil/SbQHUrZRVkFyc6NTDr1frpduIgGYxOb85UI0ZChbV331XTkFMcNW5J6WByfObizVhEiC/1UPK5Xl7PNjlLEAzdyNvyHZrJA3LF17JiZwNg3LkPRUlhQbRdCCBVM8Vd00zLYYRS5PnZu5y7uG1C8tirAOmqo0MSfX7SgO5BuxCTPUAULDFln24p3Wj0CaARypsGxfX1VoXAyopBRKyDdQlYhcRBgbwxqbIEdawztGPLjymAlrXekAFNSEEIw8/HjxAOOaWy631cV7lujYOR9PNIP1invpfXl9CaM2tjyzJ8XSvpR9UVO9DOLsa2pgXS+h7aglyZoGJwieKT42rAN95j3ybOQ==
X-Forefront-Antispam-Report:
	CIP:20.93.157.195;CTRY:NL;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:westeu11-emailsignatures-cloud.codetwo.com;PTR:westeu11-emailsignatures-cloud.codetwo.com;CAT:NONE;SFS:(13230031)(4636009)(396003)(346002)(376002)(136003)(39840400004)(230922051799003)(186009)(451199024)(64100799003)(1800799012)(82310400011)(36860700004)(46966006)(31696002)(7636003)(86362001)(356005)(15974865002)(7596003)(36756003)(6486002)(36916002)(6512007)(6506007)(316002)(478600001)(54906003)(41300700001)(83380400001)(336012)(2616005)(53546011)(26005)(2906002)(7416002)(70586007)(70206006)(31686004)(4326008)(8936002)(8676002)(6916009)(5660300002)(44832011);DIR:OUT;SFP:1102;
X-OriginatorOrg: topic.nl
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2024 15:04:50.6401
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 6f00a8e0-2caf-4421-a825-08dc2f009fc6
X-MS-Exchange-CrossTenant-Id: 449607a5-3517-482d-8d16-41dd868cbda3
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=449607a5-3517-482d-8d16-41dd868cbda3;Ip=[20.93.157.195];Helo=[westeu11-emailsignatures-cloud.codetwo.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AMS0EPF000001A2.eurprd05.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB7033

On 16-02-2024 14:38, Jonathan Cameron wrote:
> On Wed, 14 Feb 2024 07:37:36 +0100
> Mike Looijmans <mike.looijmans@topic.nl> wrote:
>
>> Skeleton driver for the TI ADS1298 medical ADC. This device is
>> typically used for ECG and similar measurements. Supports data
>> acquisition at configurable scale and sampling frequency.
>>
>> Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
>>
> Hi Mike,
>
> One final thing noticed on a (hopefully) last read through.
>
> /sys/bus/iio:device0/name is going to read ads1298 whichever
> chip is detected.
>
> Would be more useful to users if it identified the actual
> part given that is easily read from the ID register.

Implemented it like that, the "name" now reflects the chip's information.

While at it, I also made the probe fail on invalid ID (tested by probing=20
an empty SPI bus)

And also pass the channel count into the "num_channels" member, and=20
adapted the SPI transaction, which should support the devices with 4 or=20
6 channels better.

I'll post a v5 soon, bit of testing first...

--=20
Mike Looijmans
System Expert

TOPIC Embedded Products B.V.
Materiaalweg 4, 5681 RJ Best
The Netherlands

T: +31 (0) 499 33 69 69
E: mike.looijmans@topic.nl
W: www.topic.nl