Received-SPF: pass (google.com: domain of linux-kernel+bounces-68785-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <Zc9493j46rZMRIDv@tpad>
In-Reply-To: <Zc9493j46rZMRIDv@tpad>
From: Eric Dumazet <edumazet@google.com>
Date: Fri, 16 Feb 2024 16:13:36 +0100
Message-ID: <CANn89iJkjrBr-giBTA3=5t5-EMhc76X1gG6jha3rmm90NriEpw@mail.gmail.com>
Subject: Re: [PATCH] net/core/dev.c: enable timestamp static key if CPU
 isolation is configured
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: linux-kernel@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>, 
	Frederic Weisbecker <frederic@kernel.org>, Valentin Schneider <vschneid@redhat.com>, 
	netdev <netdev@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Feb 16, 2024 at 4:02=E2=80=AFPM Marcelo Tosatti <mtosatti@redhat.co=
m> wrote:
>
>
> For systems that use CPU isolation (via nohz_full), creating or destroyin=
g
> a socket with  timestamping (SOF_TIMESTAMPING_OPT_TX_SWHW) might cause a
> static key to be enabled/disabled. This in turn causes undesired
> IPIs to isolated CPUs.
>
> So enable the static key unconditionally, if CPU isolation is enabled,
> thus avoiding the IPIs.
>
> Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
>
> diff --git a/net/core/dev.c b/net/core/dev.c
> index 0d548431f3fa..cc9a77b4aa4e 100644
> --- a/net/core/dev.c
> +++ b/net/core/dev.c
> @@ -153,6 +153,7 @@
>  #include <linux/prandom.h>
>  #include <linux/once_lite.h>
>  #include <net/netdev_rx_queue.h>
> +#include <linux/sched/isolation.h>
>
>  #include "dev.h"
>  #include "net-sysfs.h"
> @@ -11601,3 +11602,14 @@ static int __init net_dev_init(void)
>  }
>
>  subsys_initcall(net_dev_init);
> +
> +static int __init net_dev_late_init(void)
> +{
> +       /* avoid static key IPIs to isolated CPUs */
> +       if (housekeeping_enabled(HK_TYPE_MISC))
> +               net_enable_timestamp();
> +
> +       return 0;
> +}
> +
> +late_initcall(net_dev_late_init);
>

CC netdev@

SGTM, but could you please add netdev@ when sending patches for network tre=
es ?

Thanks.