Received-SPF: pass (google.com: domain of linux-kernel+bounces-68905-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Fri, 16 Feb 2024 07:51:56 -0800
From: "Paul E. McKenney" <paulmck@kernel.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Bartosz Golaszewski <brgl@bgdev.pl>, Arnd Bergmann <arnd@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Kent Gibson <warthog618@gmail.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gpio: cdev: avoid uninitialized variable dereference
Message-ID: <c6290c26-8d06-4032-8599-83556d44687c@paulmck-laptop>
Reply-To: paulmck@kernel.org
References: <20240216125959.3766309-1-arnd@kernel.org>
 <CAMRc=MdBbzff5BppY4Hjwfi=SnmYopnFxg1AX4QsGt3Y+-g60Q@mail.gmail.com>
 <14ab7b63-b2c0-41e3-8104-da5515b379be@app.fastmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <14ab7b63-b2c0-41e3-8104-da5515b379be@app.fastmail.com>

On Fri, Feb 16, 2024 at 03:04:14PM +0100, Arnd Bergmann wrote:
> On Fri, Feb 16, 2024, at 14:19, Bartosz Golaszewski wrote:
> > On Fri, Feb 16, 2024 at 2:00 PM Arnd Bergmann <arnd@kernel.org> wrote:
> >>
> >> From: Arnd Bergmann <arnd@arndb.de>
> >>
> >> The 'gc' variable is never set before it gets printed:
> >>
> >> drivers/gpio/gpiolib-cdev.c:2802:11: error: variable 'gc' is uninitialized when used here [-Werror,-Wuninitialized]
> >>  2802 |         chip_dbg(gc, "added GPIO chardev (%d:%d)\n", MAJOR(devt), gdev->id);
> >>       |                  ^~
> >> drivers/gpio/gpiolib.h:277:11: note: expanded from macro 'chip_dbg'
> >>   277 |         dev_dbg(&gc->gpiodev->dev, "(%s): " fmt, gc->label, ##__VA_ARGS__)
> >>       |                  ^~
> >>
> >> Use dev_dbg() directly.
> >>
> >> Fixes: 8574b5b47610 ("gpio: cdev: use correct pointer accessors with SRCU")
> >> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> >> ---
> >
> > I seem to have beat you to it[1] and my patch doesn't change the log
> > message so I'll apply it instead of this one.
> 
> Ok, thanks. I thought about doing this, but could not
> figure out which of the RCU primitives to use.

I will count that as a bug against RCU's documentation, but I am not
sure how to fix it.  Thoughts?

							Thanx, Paul