Received: by 2002:a05:7412:1e0b:b0:fc:a2b0:25d7 with SMTP id kr11csp1209451rdb; Fri, 16 Feb 2024 08:23:06 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCV931MUIKXI+ZjNitCQKSgqkhXAzREGufSLJ9Z4nJaj2eUE1ZPhOk5VxkJcOza4pIU7lPQJomi1dd2sZfETQwYfLydntOhf+Jbs9sT4jA== X-Google-Smtp-Source: AGHT+IG8bwYAfSM5HfF09WO5+rV3+xbPoRit0yzUX6fL+Pat54yMtRfhBy6IGHAyUYWWBBAqRjc5 X-Received: by 2002:a17:906:fac3:b0:a3d:a763:f849 with SMTP id lu3-20020a170906fac300b00a3da763f849mr3142215ejb.76.1708100586674; Fri, 16 Feb 2024 08:23:06 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708100586; cv=pass; d=google.com; s=arc-20160816; b=SYQzD4HUgqLqqKAinwnLWkNpH9OAvIYlptH7a3025uxbWnU3xknpJUkpM2GiKpsPAt nmERIu54VCOMbGwTwv4g83eYJVJtpxWbleDxczpfs/GEjGmd4uTfti3vHAg5C/0YrjL7 OFBTFXYYuSWsjhrE9yjV+nMeHz90yxsu/c7j3nxY60zepqpzC5KY+8mI8+5ddd3EZkQi dijjNiiaBNGcJJ1ZqB6q8UB6BcDVgFQkeV6EyU9yW65Ou/wyOsCDLD3bAsKERGKbW+/M vbkavGeRHiZj9uNKvSzl7ufyJtQoRJhCS2IVhtNwgr1BQyTcxfayWz+S+N9FdIoWVwmc rCpA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=GrYF1dWTlGPpRhl6DLPo/DaiRb2f0DtkTQYkYyH+8NM=; fh=7LB/JMquuQUF7V9LwTHKu7WvKzcVXEB8mVKh/HmMFxM=; b=KR+pNydtI++dHMd0bvdPaNwU+IqutAv2uhP9ewb02wDx2dM8bIP0egUCOTxbrPcC4N m8Yj4kIZAEIfbNGKf1Z5+37j6Swq8I730rRrTZkN1i7UKkzPvDb16P9Yk38RqK83QHrR Oqv2z7qZ5Zkn9c9+Q260SRYFHWMrdPZYsGu3fzieJZcE03PpS/NBEn1il7bowDHHB+2d mtKzrEu333OHpSyS7r0SWCOvZoA/VCXUBj/RhM5K7s1JKKXI0EnBsaCEKXFmIAqxk5zR UEh+VHbAORrl1qdxqHkdU6zKt1oVnaK5lrjNAXKNHMe7ndxaWaXlgRnrSGDi6JF+Usi8 YRSw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="Y7L/QiUU"; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-68952-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-68952-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id zl4-20020a170906990400b00a3da0cdefffsi62848ejb.539.2024.02.16.08.23.06 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Feb 2024 08:23:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-68952-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="Y7L/QiUU"; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-68952-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-68952-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 6C9BC1F21816 for ; Fri, 16 Feb 2024 16:23:06 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5EA2012D770; Fri, 16 Feb 2024 16:22:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Y7L/QiUU" Received: from mail-oo1-f53.google.com (mail-oo1-f53.google.com [209.85.161.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0DF2A12CDA0 for ; Fri, 16 Feb 2024 16:22:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708100578; cv=none; b=pnJelvAVZ/MVD+tWS8thSaXsGXCfupIOf4wWbIMzBDWn1Q+6F+74xD5lfhSaPAEm4YdZgwIcJNw6vudT6+F/K1TKLcX0LOC0Tuc4Ghybd7KjTBmnLaFiJyun6sEeZ6ZlZAiL6U4oAkJIP+aQ46IW7IrkdnrGxTmt+1oq4V1OwQ4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708100578; c=relaxed/simple; bh=eeq/n7ab4GkpbGp/WWvm8JcwaMcM0G2mRvEUmj4AOy4=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=dEHwCIoD9/mi8HjYCOEB3l8hIZR/5+dMt2uIuXxhOJK68SO3LxurBT7rZz2o51Q2IwHU5eJL6sW/gPon1FzkAMNVhtydDu/R7Lb3Tw/75KGXfmb1+qnj1KpxVGjNRZ7NOL7tY6BMAIPkd0a3c7KJnfwhRjfh2YUYw8RnEUvTRe4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=Y7L/QiUU; arc=none smtp.client-ip=209.85.161.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Received: by mail-oo1-f53.google.com with SMTP id 006d021491bc7-59a8ecbadf7so247057eaf.0 for ; Fri, 16 Feb 2024 08:22:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1708100576; x=1708705376; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=GrYF1dWTlGPpRhl6DLPo/DaiRb2f0DtkTQYkYyH+8NM=; b=Y7L/QiUU080UnUcG17MaXalaaoHJ8DpuQEExZGY37keyn3m1a+UftzBAehThBNjYbc MG2sVwp19QH4M6d9VMKChtwlIhMqFw0n20TfExnPvFj+t4ahcL1fQkdrCHt4v/+Mo/+k iHGkrAG/B6dlzRNW/+sCvq73/+uU+jzUiY0DM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708100576; x=1708705376; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GrYF1dWTlGPpRhl6DLPo/DaiRb2f0DtkTQYkYyH+8NM=; b=ukGDYIK2t83t/IOlZL+uDKOwM9jClSj+YYl8/99cofbR52ld356ixa2phKA0aYzZWo spdK6Zh15TqJSGRuUn2LdHSNv7efkaxbAXcchxPY9BQpUNEBNlxYKbOZK7Da0cTtG5pr tkAzSphyB9+xvWC0WPFQx/xDNOd40LGlcECZLpVXlfu4iv9c9Wlh7MxSrEWlYZ8bB6wy aeKEQJAOvqxNt30PXlsp8encKXEMZtx8fI1EHpq0W/VlmRbAE/kW9JyOSNsRQhbFJYLE 3UoWMs0vY06ogFCnA8ARsNhcbVhflX+MlX2pwSJg7OP7iRe7ZmipSfbkSC2qeNpIxWHR UVSQ== X-Forwarded-Encrypted: i=1; AJvYcCXXB3rc+QIOPX1dYjeKADWFq+b/FvkQ6nOTQ89kcAh28worTPN3K2aUVATu0CzbjI/U4mjsqroQql5UMauR1x0a0RhIUIcCpFKfcUjd X-Gm-Message-State: AOJu0YyNEL7TJ2p922LRKdTK0AcfG45wqxS9Riyb9lUmkHqgbiIRRSEc CkqVjPdrbQjVHx6Lu4ci+jZoKvXdx31EC7n2bkBwKOg6PaRE58mI41IFG+DExveRUiqhi067ZKd suc2dyV1TXvq2Y5AFF6yu5Rmayxde6cXF0jXo X-Received: by 2002:a4a:6245:0:b0:59d:c3a:d6a0 with SMTP id y5-20020a4a6245000000b0059d0c3ad6a0mr5661582oog.4.1708100576157; Fri, 16 Feb 2024 08:22:56 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240214170720.v1.1.Ic3de2566a7fd3de8501b2f18afa9f94eadb2df0a@changeid> <20240215034528.240-1-hdanton@sina.com> <87h6iaf7di.wl-tiwai@suse.de> <875xypk6d6.wl-tiwai@suse.de> <20240216043426.1218-1-hdanton@sina.com> <87plwwiz6z.wl-tiwai@suse.de> <87frxsiueo.wl-tiwai@suse.de> <87zfw0h3lu.wl-tiwai@suse.de> In-Reply-To: <87zfw0h3lu.wl-tiwai@suse.de> From: Sven van Ashbrook Date: Fri, 16 Feb 2024 11:22:45 -0500 Message-ID: Subject: Re: [PATCH v1] ALSA: memalloc: Fix indefinite hang in non-iommu case To: Takashi Iwai Cc: Kai Vehmanen , Hillf Danton , Karthikeyan Ramasubramanian , LKML , Brian Geffon , linux-sound@vger.kernel.org, "Arava, Jairaj" , Curtis Malainey Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Feb 16, 2024 at 9:43=E2=80=AFAM Takashi Iwai wrote: > > OK, then how about the one like below? > > This changes: > - Back to __GFP_NORETRY as default > - Use __GFP_RETRY_MAYFAIL for SNDRV_DMA_TYPE_NONCONTIG with IOMMU; > this should cover the commit a61c7d88d38c > - Also use __GFP_RETRY_MAYFAIL for the SG-fallback allocations of the > minimal order, just like IOMMU allocator does. > > This should be less destructive, while still allowing more aggressive > allocations for SG buffers. This one looks like it would keep the SOF firmware allocation issue at bay, in both iommu and non-iommu cases. If there is no further discussion in this thread, we'll stress test this on iommu and non-iommu Chromebooks.