Received: by 2002:a05:7412:1e0b:b0:fc:a2b0:25d7 with SMTP id kr11csp1210017rdb; Fri, 16 Feb 2024 08:24:11 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCV/1ok+y8dg8rd0wA/6QQbB0OR9abgjkVO/ipj0TIB50TCSKuaFt38EnmVWqd6Y3Y/irbEiF03ByrOS51XDH1BRtF21WP2CPwcSqjQahA== X-Google-Smtp-Source: AGHT+IEMhBD67fUFu6h1r+633j2xdkqdOmo7NgAaxCS1+/Y2ewsz9cEQ9qr2KW8XyK+x0K2yncQ2 X-Received: by 2002:a05:6a21:3a41:b0:19e:cf1a:5372 with SMTP id zu1-20020a056a213a4100b0019ecf1a5372mr6596188pzb.34.1708100651318; Fri, 16 Feb 2024 08:24:11 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708100651; cv=pass; d=google.com; s=arc-20160816; b=yWXlaflm3Wq3IHs8NTlUqpuUipI/fWX1PMjoTHRfCDOxPXq/K7wTMjwjzh5U9SNfSE dBPOia+1fgCwNxVS79ozHjqoy6LhCovl/ObaqRfDr8FAuoMRRNupFhLIttZ+Z8ZWFZCM OkGddUlGjm/jhBPUg9HG+4LD1pJDsc2oCE7dvhFoTcQrj1jzroR84TJMrHJoMFazLmw2 Ye7DkA5i3t0+krqEIyD8+oPy81o8CGsar1MY4SN4vPje4+kktMUXn+r2BEZAGFk8u+Qj upLd5JvphjXYVjbCaXllZ59Qo3jskMMFQAVuVlZ76+Ott0iVL1IKJZp6Ck+QxYi0RV9u tGPw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=Cni14qWVF5Qo6yP1IoU8PFubchx+rq7qZRzJfHnvpQM=; fh=hauEBNBWa3rFoV2+O6B9XkVD3WhsvBU6hOcjzndK+TU=; b=KShcez7+7konoDAOiN43I1JkmWxHsgG0hBLPeUkAY8iMaFgEiECuwPKzOSZ/jwUHoB Fn0Ig9KAadEZmve+0fpDdef6JZDUfwfBmyXXMOuvSqRMb8+rS6SiWBVHEqf0BQ+xZt+B Cdlx3lhhWG86VQSRmoYVEcmZ/PRNyhnsi41IAGdfR6GmtGSnEzfPQK8wFQCB5VJgyTda 5QA8d3yTm/glU5uvphwRanMhuDKLszYdOos3m5fTO/v/8dv31P6jj/xjkD+lrxAPhVNw LFdilAzlJ8xYGfCc5Shl8BAY9u7asajN/ir3sY3wsoVvNp0MpbqJraWp/jog4Iit0ThP FGdw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gaisler.com header.s=unoeuro header.b=TuGPUb0P; arc=pass (i=1 spf=pass spfdomain=gaisler.com dkim=pass dkdomain=gaisler.com dmarc=pass fromdomain=gaisler.com); spf=pass (google.com: domain of linux-kernel+bounces-68953-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-68953-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=gaisler.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id a26-20020a637f1a000000b005dcbb75b1fdsi111915pgd.218.2024.02.16.08.24.11 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Feb 2024 08:24:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-68953-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@gaisler.com header.s=unoeuro header.b=TuGPUb0P; arc=pass (i=1 spf=pass spfdomain=gaisler.com dkim=pass dkdomain=gaisler.com dmarc=pass fromdomain=gaisler.com); spf=pass (google.com: domain of linux-kernel+bounces-68953-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-68953-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=gaisler.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id EE6C1281E50 for ; Fri, 16 Feb 2024 16:24:10 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6E92B12FF6D; Fri, 16 Feb 2024 16:24:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=gaisler.com header.i=@gaisler.com header.b="TuGPUb0P" Received: from smtp-out3.simply.com (smtp-out3.simply.com [94.231.106.210]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0925B12CDA0; Fri, 16 Feb 2024 16:24:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=94.231.106.210 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708100644; cv=none; b=Miz36FgzUXwkC469tz5nNN2vpTx57XGL9vt2XbaxOKf/Zr08mLVtO2t4aFC4GLNFfNWdcEP6/327iyxetmwbIBwa+DZIyjlr/TLd74CUoNzKz5Ev+a9U6hulKZCbMTtTy4razYyYlf3iGxtj37UcXTiEFhbvMWjgTl15wuFC6b0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708100644; c=relaxed/simple; bh=Rfy5t+Ke97W7RYMJt/erJUa1+/Vwj2VdUC6H8BztsRc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=P1UJpQhZBR4Y3L8/HpsdQBHQcIpiGGYWtOVok69M2dGjj+8ni2NWTuZKXBkK5PJq4g5hWzCK1Vu/Mh6prdyvvNVGDJ1VE/ug4fOuWZjb/99rktRr4Y3zUDKMfjynut+ovwGexdBuURvH+KC2CCoDU0MYAp20+wgg5MtgEjndwB0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=gaisler.com; spf=pass smtp.mailfrom=gaisler.com; dkim=pass (1024-bit key) header.d=gaisler.com header.i=@gaisler.com header.b=TuGPUb0P; arc=none smtp.client-ip=94.231.106.210 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=gaisler.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gaisler.com Received: from localhost (localhost [127.0.0.1]) by smtp.simply.com (Simply.com) with ESMTP id 4Tby1D3DQ6z681W; Fri, 16 Feb 2024 17:24:00 +0100 (CET) Received: from [10.10.15.23] (h-98-128-223-123.NA.cust.bahnhof.se [98.128.223.123]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by smtp.simply.com (Simply.com) with ESMTPSA id 4Tby1110Yhz681q; Fri, 16 Feb 2024 17:23:48 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gaisler.com; s=unoeuro; t=1708100640; bh=Cni14qWVF5Qo6yP1IoU8PFubchx+rq7qZRzJfHnvpQM=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=TuGPUb0P7sFMjY7wydvc6Z9EnfErmRkHqJTvj6wzzPD2AMRdoPwYnmpphOaMjXf8F 5CJJShVpg8H/BKZjnw6uZnO5OSNsqeWQ2TtJsMUJvo9so4j9MFJlQ+NFCOXgShy2Te J46TtXVqS8Frkam9F35ZRgRTDx8RBjp8gPWxNx08= Message-ID: Date: Fri, 16 Feb 2024 17:23:48 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5] sparc: vDSO: fix return value of __setup handler Content-Language: en-US To: Randy Dunlap , linux-kernel@vger.kernel.org Cc: Igor Zhbanov , "David S. Miller" , sparclinux@vger.kernel.org, Dan Carpenter , Nick Alcock , Sam Ravnborg , Andrew Morton , stable@vger.kernel.org, Arnd Bergmann References: <20240211052808.22635-1-rdunlap@infradead.org> From: Andreas Larsson In-Reply-To: <20240211052808.22635-1-rdunlap@infradead.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2024-02-11 06:28, Randy Dunlap wrote: > __setup() handlers should return 1 to obsolete_checksetup() in > init/main.c to indicate that the boot option has been handled. > A return of 0 causes the boot option/value to be listed as an Unknown > kernel parameter and added to init's (limited) argument or environment > strings. Also, error return codes don't mean anything to > obsolete_checksetup() -- only non-zero (usually 1) or zero. > So return 1 from vdso_setup(). > > Fixes: 9a08862a5d2e ("vDSO for sparc") > Signed-off-by: Randy Dunlap > Reported-by: Igor Zhbanov > Link: lore.kernel.org/r/64644a2f-4a20-bab3-1e15-3b2cdd0defe3@omprussia.ru > Cc: "David S. Miller" > Cc: sparclinux@vger.kernel.org > Cc: Dan Carpenter > Cc: Nick Alcock > Cc: Sam Ravnborg > Cc: Andrew Morton > Cc: stable@vger.kernel.org > Cc: Arnd Bergmann > Cc: Andreas Larsson Applied to my for-next branch. Thanks, Andreas