Received: by 2002:a05:7412:1e0b:b0:fc:a2b0:25d7 with SMTP id kr11csp1215469rdb; Fri, 16 Feb 2024 08:33:50 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCX5hl3ZXLhgd07pDIO3BxD+hCKT9e5elXsloN8Rib/xA4d3t2kFxxyhxxPWE2H7gKfY8fGnwg31+h/VgbiatLbCVWdcSen9z1HaQwa1iw== X-Google-Smtp-Source: AGHT+IH2AYJokWxZnJSwSrYszvtw6vK37PWQc/yHuykBXFVIieGCOm8fUUfPnqBBVcRBVjNUiBIf X-Received: by 2002:a17:902:f78e:b0:1db:92e1:2e50 with SMTP id q14-20020a170902f78e00b001db92e12e50mr5283077pln.43.1708101229814; Fri, 16 Feb 2024 08:33:49 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708101229; cv=pass; d=google.com; s=arc-20160816; b=M3zihxbOqb1iORnIn58y/JIX6aAcUYRFTenFsE3GGvsJzF/NowXlm77OtpEHCTWa6O ZZdMVU1ao8eGM0jDoKqJZIjeOrcHVQQsSMxzIam7jEGhXFCTtwXPTE48mpEr/ktL1HOi X9+OV6coGF5sx6MSadfTdhNB1zWMMfIiCvULqS15eClWIL1n++Wzul1kkaHX2nV5R3cX rFXEUeKv4FRmkGRPU+K6cuCxJJROEYPWeWgqoEAaKgy41yT8X5NdsxfokFQAiSkLVfF2 t9xR+huTrp1FHJiQzGmwTR/HJvrYnv1z1bl1hWBogj8oMpePRRf+TVSXfUmnOgaQCN56 7OAg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=wfmhXnx49BRBtPMqtcbBb/ZIo/Mc+0byxiHLNwHcVYM=; fh=BH8Pic0Ukt7UkSu7qDi6oWQJO9Qe7u4nC8Fy0b2w8NU=; b=ubViFs90Yzbx+JvPtrouqdzWeKd2OSz/P29gCz2lQmF4rJUTmxUQNigEetPl4j17ml CijuTpjo5+C+vHAOTztnrF+miJgi8KI2ZEOalXpLp8yA0EMybUxk64HdeTTCKad1KMac CL+NfvH2YnEqSS1MKnqR5E2aNGfXCi36mLyF3GqGaL/zhhQoMGLpWtvy+m2Pigx1eblw QcA+Y0j+686Q+rIt2684MoXmlH2WVSJXnnE3dG2870DW/g3bucTQu6DrWcb4SBParX8g Nivl5HFihKjJpXuVsuN2uIKDkiuJ0l64djfxIjPiQjp8O749cioa/I1Ctb09wymQnePL KCvw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gaisler.com header.s=unoeuro header.b=JmAQXqBD; arc=pass (i=1 spf=pass spfdomain=gaisler.com dkim=pass dkdomain=gaisler.com dmarc=pass fromdomain=gaisler.com); spf=pass (google.com: domain of linux-kernel+bounces-68951-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-68951-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=gaisler.com Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id z16-20020a170902ccd000b001d8d54d83c5si105563ple.94.2024.02.16.08.33.49 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Feb 2024 08:33:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-68951-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@gaisler.com header.s=unoeuro header.b=JmAQXqBD; arc=pass (i=1 spf=pass spfdomain=gaisler.com dkim=pass dkdomain=gaisler.com dmarc=pass fromdomain=gaisler.com); spf=pass (google.com: domain of linux-kernel+bounces-68951-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-68951-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=gaisler.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 14A24B22537 for ; Fri, 16 Feb 2024 16:22:55 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9349812FF6B; Fri, 16 Feb 2024 16:22:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=gaisler.com header.i=@gaisler.com header.b="JmAQXqBD" Received: from smtp-out3.simply.com (smtp-out3.simply.com [94.231.106.210]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A7F5E78B5C; Fri, 16 Feb 2024 16:22:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=94.231.106.210 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708100566; cv=none; b=K3MTbWNQTXUN78ZDNBmINYexHxnocEYBYY8SZ9x+632ZfkY0O2iWhg8ih+WlAiqNTj2xvGQk+B53zcUXsTyS+ChtkR+zvkqT4c5FQqJ2nUyNnX9eutmmFqv1u6id0OiaAobBsWdumkylw6vl7EsqKz7hINMZmeTvpQEgVsIvyNg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708100566; c=relaxed/simple; bh=tqZk/F2kUUs8KKNbAeHCorX3lc0ZR1oe/NUwF6XZTYI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ou9EblgETJu/dERob1fS/LPpL5IAYaNmUUlVT1FmJ7aMSfIljKTGH1zi/cjleHF59UdEmVbqX21dzIj0k4g5lKL2MezpHZzCx+dLblsE2kKmAt4yoYeTPyz0GDkjcd5DdihDm5ujs+90UFeQnMR85wyCekWauGE8Sbuk1YwUtf0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=gaisler.com; spf=pass smtp.mailfrom=gaisler.com; dkim=pass (1024-bit key) header.d=gaisler.com header.i=@gaisler.com header.b=JmAQXqBD; arc=none smtp.client-ip=94.231.106.210 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=gaisler.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gaisler.com Received: from localhost (localhost [127.0.0.1]) by smtp.simply.com (Simply.com) with ESMTP id 4Tbxzl0DQHz681Z; Fri, 16 Feb 2024 17:22:43 +0100 (CET) Received: from [10.10.15.23] (h-98-128-223-123.NA.cust.bahnhof.se [98.128.223.123]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by smtp.simply.com (Simply.com) with ESMTPSA id 4TbxzZ0013z681w; Fri, 16 Feb 2024 17:22:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gaisler.com; s=unoeuro; t=1708100562; bh=wfmhXnx49BRBtPMqtcbBb/ZIo/Mc+0byxiHLNwHcVYM=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=JmAQXqBDj1O81hg+7U5kPWKb7bWgnBRlgs9Boc1xKDUP4trOyNjzL+MDjneNaDGCc eWog6BF8NBNNS2e1LJAHi2dkjli6z4W4GX2kd3nh3Sd7cOa19KeaOb6lFCUsyTxJ7k 000GbsrmBreIyYMiHxdL42FbGX2K5TsCyGEi/PRo= Message-ID: Date: Fri, 16 Feb 2024 17:22:32 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5] sparc64: NMI watchdog: fix return value of __setup handler Content-Language: en-US To: Randy Dunlap , linux-kernel@vger.kernel.org Cc: Igor Zhbanov , "David S. Miller" , sparclinux@vger.kernel.org, Sam Ravnborg , Andrew Morton , stable@vger.kernel.org, Arnd Bergmann References: <20240211052802.22612-1-rdunlap@infradead.org> From: Andreas Larsson In-Reply-To: <20240211052802.22612-1-rdunlap@infradead.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2024-02-11 06:28, Randy Dunlap wrote: > __setup() handlers should return 1 to obsolete_checksetup() in > init/main.c to indicate that the boot option has been handled. > A return of 0 causes the boot option/value to be listed as an Unknown > kernel parameter and added to init's (limited) argument or environment > strings. Also, error return codes don't mean anything to > obsolete_checksetup() -- only non-zero (usually 1) or zero. > So return 1 from setup_nmi_watchdog(). > > Fixes: e5553a6d0442 ("sparc64: Implement NMI watchdog on capable cpus.") > Signed-off-by: Randy Dunlap > Reported-by: Igor Zhbanov > Link: lore.kernel.org/r/64644a2f-4a20-bab3-1e15-3b2cdd0defe3@omprussia.ru > Cc: "David S. Miller" > Cc: sparclinux@vger.kernel.org > Cc: Sam Ravnborg > Cc: Andrew Morton > Cc: stable@vger.kernel.org > Cc: Arnd Bergmann > Cc: Andreas Larsson Applied to my for-next branch. Thanks, Andreas