Received-SPF: pass (google.com: domain of linux-kernel+bounces-69029-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Fri, 16 Feb 2024 18:07:36 +0100
From: Daniel Vetter <daniel@ffwll.ch>
To: "Jiri Slaby (SUSE)" <jirislaby@kernel.org>
Cc: airlied@redhat.com, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] char/agp: remove agp_bridge_data::type
Message-ID: <Zc-WWH8_UNBCOlri@phenom.ffwll.local>
Mail-Followup-To: "Jiri Slaby (SUSE)" <jirislaby@kernel.org>,
	airlied@redhat.com, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org
References: <20240213111511.25187-1-jirislaby@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240213111511.25187-1-jirislaby@kernel.org>

On Tue, Feb 13, 2024 at 12:15:11PM +0100, Jiri Slaby (SUSE) wrote:
> agp_bridge_data::type is unused (and I cannot find when was used last).
> 
> Therefore, remove it.
> 
> Found by https://github.com/jirislaby/clang-struct.
> 
> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
> Cc: David Airlie <airlied@redhat.com>
> Cc: dri-devel@lists.freedesktop.org

Thanks, pushed to drm-misc-next.
-Sima

> ---
>  drivers/char/agp/agp.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/char/agp/agp.h b/drivers/char/agp/agp.h
> index 5c36ab85f80b..67d7be800a7c 100644
> --- a/drivers/char/agp/agp.h
> +++ b/drivers/char/agp/agp.h
> @@ -138,7 +138,6 @@ struct agp_bridge_data {
>  	unsigned long gart_bus_addr;
>  	unsigned long gatt_bus_addr;
>  	u32 mode;
> -	enum chipset_type type;
>  	unsigned long *key_list;
>  	atomic_t current_memory_agp;
>  	atomic_t agp_in_use;
> -- 
> 2.43.1
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch