Received: by 2002:a05:7412:1e0b:b0:fc:a2b0:25d7 with SMTP id kr11csp1247690rdb; Fri, 16 Feb 2024 09:28:47 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWNwJIv8Hm9IpS1tysALqjkMbs2LD8LoBP6nADN0wFgxmt9pCBI7DCsuKU4PIXW5blGIhqwRJ/o0b7uDZW5VuA0+zxphNxNi3xuk5mZJQ== X-Google-Smtp-Source: AGHT+IHN3sOMqRmzCOMQrwXhhIrcj+xPs/92D905NGDknDkJCU1KDVhODue8IE7MQjo9iicFObw6 X-Received: by 2002:a05:6808:1a23:b0:3c1:34f8:718e with SMTP id bk35-20020a0568081a2300b003c134f8718emr6561648oib.44.1708104527558; Fri, 16 Feb 2024 09:28:47 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708104527; cv=pass; d=google.com; s=arc-20160816; b=WFRhIWP60IKNnDNgWtnFTKiO++cbKrfcaESBWGC8mo6GO/9JY9BRIWBUjLUAb0YukH 7w5+f5n+nE1UN/HKBYqU8Pjj7OETYxWV55T3ns9ci5pNSJvKIxnCWilti9yV4E779mug +nNQBpdK4lSwMWpeQbRtBFwuSSvNwkxaUEqFmotKvoYlHbm/fV7tc+1wX7CTwjpQRnjo GgQ0IviVPXNTBa2IWyk8aBgu2QZ94JADowm9tkXBUPxCV3XHAozeD66VbsCNz3vbHTot Z94qFdfHkevylA+ACigYfYp3I2aBazG8E3AhAqE0NDRM79h9YJIvI96/iy26L9xM5gCu CbkA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :references:message-id:subject:cc:to:from:date:dkim-signature; bh=2o0piiHymx2o0AqbvBOlZhU2HWHRJd9hWUdKlncu1Wo=; fh=l+vvkWii3ciUk0zS2ajE7IG9unlnJNbgzLGs55pnY3g=; b=vlP3ZAe0Y4EA1XE9/Gv5uMDqWQOs71C34pwd1QJCEwc88+iERd6sBBD4Glveti1Z6u +r+u8b4VmAEHCt/wxg4HFHmjfSCacF3Kio3wtk9ab/THT+wr3Uaq+njx//8vb63jyeAV ZOaXAywjfuYtnhPpl95a4pqk0LfjNmT+34Loi7sIuGuypdCYew8vLhs3gRepciOY66ju TvhS/j8esS7R0H2q5xTC7uqcvcyldjEPgzMVz8WHaVWytnSt8halWvUy+tJHGT9UD89n TpyiuoeouIgAYgiL2n+WPKX8NbRPniPS0SUY7qOt/5vOrDWtmKWMn2wTzQ3og3qerqxJ y/FA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=z3il1sbo; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-69071-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-69071-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id f10-20020ac859ca000000b0042c71e36eaasi302026qtf.143.2024.02.16.09.28.47 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Feb 2024 09:28:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-69071-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=z3il1sbo; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-69071-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-69071-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 2B2B71C22828 for ; Fri, 16 Feb 2024 17:28:47 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4875F13247C; Fri, 16 Feb 2024 17:28:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="z3il1sbo" Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 01142130E39; Fri, 16 Feb 2024 17:28:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708104518; cv=none; b=XHEk7a7MTUVwh5F7rx40HpqcnfHjQAO8U27bO05JgBhD4qEfrYsaVlArnGq/U4elSs6IYsAAg3l6Q/818iWia+9Cgbgbck2QZF1aPle7sAcnzi+9+1+SGHBkTZTYmQQQjHb5svZ8B6FNN4qF4rlBFPXYKTt06cNmi0jsIL5UDeE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708104518; c=relaxed/simple; bh=aNVEXDiJi6VMChdVIAhoIHDD0mjExyyaV2pttYA54tM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=OXEYQzPV0PVKpOM1rMPva9hZp7Jkaz0GawgLUm/qH9/3cxlzuMz6THLqtEmX6YCmCYFuIlQ3CvphD4azoosiezd4A02fsf9ehdaIj5SBvXF+VBRgP/jHMEnTG77tfQe3bp/VyrBXScT0BgTgK01kCiWuaqB901MFI7OZiDz4TxM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=z3il1sbo; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Transfer-Encoding:Content-Disposition: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:From: Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Content-Disposition: In-Reply-To:References; bh=2o0piiHymx2o0AqbvBOlZhU2HWHRJd9hWUdKlncu1Wo=; b=z3 il1sboGebyF5ty+7v10SJ58TyYQXM/49dLz6nCS9zXdy9KG7vajiSHnIGQyYql2r52FBSAgx982wm nSHfeaz9boeIdFAh7Ffv0v+aUity5zWjpVUiOyCkKIJAG0T6+xWPI3cnSs36n/JCxavkRbn4BPJOr JBDcC7XKOE+4SH4=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1rb20l-00809r-J7; Fri, 16 Feb 2024 18:28:31 +0100 Date: Fri, 16 Feb 2024 18:28:31 +0100 From: Andrew Lunn To: Bastien Curutchet Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Richard Cochran , Heiner Kallweit , Russell King , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Thomas Petazzoni , Herve Codina Subject: Re: [PATCH 1/2] dt-bindings: net: Add TI DP83640 Message-ID: <68c3b805-5532-41dd-bcf3-ff3cb86f4acc@lunn.ch> References: <20240130085935.33722-1-bastien.curutchet@bootlin.com> <20240130085935.33722-2-bastien.curutchet@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: > > > + ti,phy-control-frames: > > > + $ref: /schemas/types.yaml#/definitions/uint32 > > > + enum: [0, 1] > > > + description: | > > > + If present, enables or disables the PHY control frames. > > > + PHY Control Frames support can also be strapped. If the strap pin is not > > > + set correctly or not set at all then this can be used to configure it. > > > + - 0 = PHY Control Frames disabled > > > + - 1 = PHY Control Frames enabled > > > + - unset = Configured by straps > > What is a control frame? > I'm not an expert on this but it seems that if the PHY's Serial Management > interface is not available, it is possible to build PCF (PHY Control Frame) > packets that will be passed to PHY through the MAC Transmit Data interface. > The > PHY is then able to intercept and interpret these packets. Enabling it > increases > the MII Transmit packet latency. > You'll find details in ?5.4.6 of datasheet > [https://www.ti.com/lit/gpn/dp83640] Do you actually need this feature? [Looks at data sheet] Ah, so it allows you to access PHY registers by sending it commands in Ethernet frames. That should in theory be faster than MDIO. However, my experience with Ethernet switches which offer similar capabilities, it is often not faster, because of interrupt coalescing. Anyway, the serial management interface is the MDIO bus. You know this is available, because that is how the PHY driver it talking to the PHY! Also, i've not seen any code which implements sending commands to the PHY using Ethernet frames. So why not just hard code it in the driver to disable this feature? Andrew