Received-SPF: pass (google.com: domain of linux-kernel+bounces-69059-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Fri, 16 Feb 2024 17:19:21 +0000
From: Jonathan Cameron <jic23@kernel.org>
To: Mike Looijmans <mike.looijmans@topic.nl>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
 devicetree@vger.kernel.org, linux-iio@vger.kernel.org, Arnd Bergmann
 <arnd@kernel.org>, Lars-Peter Clausen <lars@metafoo.de>, Liam Beguin
 <liambeguin@gmail.com>, Liam Girdwood <lgirdwood@gmail.com>, Maksim Kiselev
 <bigunclemax@gmail.com>, Marcus Folkesson <marcus.folkesson@gmail.com>,
 Marius Cristea <marius.cristea@microchip.com>, Mark Brown
 <broonie@kernel.org>, Niklas Schnelle <schnelle@linux.ibm.com>, Okan Sahin
 <okan.sahin@analog.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 2/2] iio: adc: ti-ads1298: Add driver
Message-ID: <20240216171921.5a6b6b20@jic23-huawei>
In-Reply-To: <fb7d41fc-328a-4ce1-88ad-5ce22ee158e4@topic.nl>
References: <Zc-E3-MNe9dG9tdW@smile.fi.intel.com>
	<fb7d41fc-328a-4ce1-88ad-5ce22ee158e4@topic.nl>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Fri, 16 Feb 2024 17:07:49 +0100
Mike Looijmans <mike.looijmans@topic.nl> wrote:

> On 16-02-2024 16:53, Andy Shevchenko wrote:
> 
> ...
> 
> +       if (reset_gpio) {
> +               /*
> +                * Deassert reset now that clock and power are active.
> +                * Minimum reset pulsewidth is 2 clock cycles.
> +                */
> +               udelay(ADS1298_CLOCKS_TO_USECS(2));
> 
> This is sleeping context and you are calling unsleeping function. I haven't
> checked the macro implementation and I have no idea what is the maximum it may
> give, but making code robust just use fsleep() call.
> 
> It'll actually delay for 1 us (the "clock" is ~2MHz). So fsleep will compile to udelay anyway, which is fine, fsleep might get smarter in future and this would then profit.
> 
> 
> 
> +               gpiod_set_value_cansleep(reset_gpio, 0);
> +       } else {
> +               ret = ads1298_write_cmd(priv, ADS1298_CMD_RESET);
> +               if (ret)
> +                       return dev_err_probe(dev, ret, "RESET failed\n");
> +       }
> +       /* Wait 18 clock cycles for reset command to complete */
> +       udelay(ADS1298_CLOCKS_TO_USECS(18));
> 
> Ditto.
> 
> ...
> 
> 
> If it's the only issue I think Jonathan can modify when applying
> (no new patch version would be needed).
> 
> That'd be nice.

ok.  As this is still the top of my tree I'll just tweak it.

Does anyone else read fsleep as femtosecond sleep every time? :)
Maybe computers will go that fast one day.

Jonathan


> 
> 
> --
> Mike Looijmans
> System Expert
> 
> TOPIC Embedded Products B.V.
> Materiaalweg 4, 5681 RJ Best
> The Netherlands
> 
> T: +31 (0) 499 33 69 69
> E: mike.looijmans@topic.nl<mailto:mike.looijmans@topic.nl>
> W: www.topic.nl<http://www.topic.nl>
> 
>