Received-SPF: pass (google.com: domain of linux-kernel+bounces-69138-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Fri, 16 Feb 2024 19:09:25 +0100
From: Robert Richter <rrichter@amd.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Davidlohr Bueso <dave@stgolabs.net>,
	Jonathan Cameron <jonathan.cameron@huawei.com>,
	Dave Jiang <dave.jiang@intel.com>,
	Alison Schofield <alison.schofield@intel.com>,
	Vishal Verma <vishal.l.verma@intel.com>,
	Ira Weiny <ira.weiny@intel.com>, linux-cxl@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] cxl/pci: Fix disabling memory if DVSEC CXL Range does
 not match a CFMWS window
Message-ID: <Zc-k1TDk1hfvakQS@rric.localdomain>
References: <20240216160113.407141-1-rrichter@amd.com>
 <65cfa34b741ea_5c762946@dwillia2-mobl3.amr.corp.intel.com.notmuch>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <65cfa34b741ea_5c762946@dwillia2-mobl3.amr.corp.intel.com.notmuch>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?sqfnwJvGGL3w32Oi0wQx9899U0P4Ny+2r4g8RazqmVot8nxeXV5YH1JK9aFP?=
 =?us-ascii?Q?WoNZhoYSQJ2ZqX6uhVeTliK3qviVMvIor0AZy4wK7D28BK2LN3NRI5gdiyOR?=
 =?us-ascii?Q?zYELBxZPKLu/9fTPa0pkEbY0K0gEN4kxrmbJA/V7DBMJnOHBlznWPDZpHdXY?=
 =?us-ascii?Q?OahQX912TE+OWtWpvnbRdRpWFR3JdPryMvscYIePQsanrBm/X+OnHuVZuvUH?=
 =?us-ascii?Q?ga6F7cKT4vdsJX6P+8hsMUtUpt+i64cHW5B9O6LOF8unc07Pv0SdRwxBCtUo?=
 =?us-ascii?Q?MBOAidAGbT3CG8gaJ8ndp6mEneyiuMGZJASNnHTq9e4xcKw1CPIoczdGnY6Y?=
 =?us-ascii?Q?Xfm8Av1AVZoRWQ1EjhvJwOYROsGqtZctd9TbvQymAPkzCkQNFXm/OSdAln92?=
 =?us-ascii?Q?qDuczsgkmHz1ZuugHkXrm6tKOgLXjFjz3FmtAY922Oe+NVPBM6ZOerEPfRoX?=
 =?us-ascii?Q?hbE91wP3nbydat7rZZCQzGzmuyGnj+KejFGtkTav+RXNr4TbkgJ2wdgpR22B?=
 =?us-ascii?Q?ejdsjItTNGzj/wILRjH0T2gEjyRzv783+aiR5EiEfh7juZGzcyqb5AtEbDLf?=
 =?us-ascii?Q?jVJVPwPZeLuWpQ5s/bTuukWZ/fUtmW1pWHo1W2fur6yiHag7RV9fq00x1dIh?=
 =?us-ascii?Q?4c+z9n3GC+9mF4Qnh+KhrIW+RMY5OXzEDUBa0wzIwHzzU6fFAcE7Wc4nTau7?=
 =?us-ascii?Q?/wrvQwzmsmaCCAfF9UZ0uCLJXihQ4o9MXLgE1jDz3DWuFsd46Q2PYbI25Yi0?=
 =?us-ascii?Q?fsUWcl8PCagMmOYh5BjwZZgbAp3pQoDj8hmBgickSUDywRR/5UnjMPHtoU8C?=
 =?us-ascii?Q?2ahiDfd/+NSwcqXZz6Onic1BrfTEnmIjAfm9QWCzmpP/xWcboHbUTPmUuUb2?=
 =?us-ascii?Q?yO2Zmw2RqkRgmXs5jQFxYLZfRxccndwE1QXRsnpPhWkMpDDcG8awuhhDInj0?=
 =?us-ascii?Q?Xvv6xN2p+KaBz37BaUKjMaK5SyslNFwP41/008S6fwlJeVX+I6e/ebUOMWEV?=
 =?us-ascii?Q?PKfAhsdeY0gjYhTETgk3BjOipFMgn6s9TW0B61Sx8ixVWNdqURosZrhHXXwW?=
 =?us-ascii?Q?0NDQpMfj4t2QTkb1fcO2/SGzYiRdaj2KRIj2XpjdyfcH8FR95FV1nyUKwkD2?=
 =?us-ascii?Q?xUTGp6Tir7nyGf4uHsdJm3cSttYd+s2il+ffotf+jKne0liPxdvMLh7gM/Ly?=
 =?us-ascii?Q?nUhcKEcnsim/bKrt+UfgdxXceffdDFQX4VEM/hT5Lq3KHe5CxI4Rp2Jxx62+?=
 =?us-ascii?Q?0hVmrBG0zttHZBOI34CyJgI5CLUxZ3LAXD13HtgG/8qdi2aSNGBJ5zRjqVj6?=
 =?us-ascii?Q?r8sMfO3c/Qwm1ifS555Dpt1St8TVAMGW20fcneurO89uzUczT4nIlJgJ1ADE?=
 =?us-ascii?Q?yZE0YNWnViG6c7sLp++UlzxVVNaQdPdEBtBjFhlGLitu09ZSdmU3Icw/AQWC?=
 =?us-ascii?Q?17dXYuNwpo6KkUrqCqPQZGmNWljRwzPqsGzoMbuwW90BYW9eaI+qnmuAFgbh?=
 =?us-ascii?Q?IgwzxKTgTkmPah2oKpGylGqzKFwWs+rLzMSW7X/PWyt7j6ANH8u00DcK77P+?=
 =?us-ascii?Q?FDw9RixK71mKBnsTxDS5A6whH6gFu0L1xvPSvRqI?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9e0672cb-9de0-4a9a-8c9d-08dc2f1a6be9
X-MS-Exchange-CrossTenant-AuthSource: CYYPR12MB8750.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2024 18:09:30.7025
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4S+FlNK53UzuL5qLyv+vF4/tg7qTswZRpocMYZ4L983dgN4X/H5NUgq5STiYdvwZhjFG8/giExGVoeZnJ7V/dA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8583

On 16.02.24 10:02:51, Dan Williams wrote:
> Robert Richter wrote:
> > The Linux CXL subsystem is built on the assumption that HPA == SPA.
> > That is, the host physical address (HPA) the HDM decoder registers are
> > programmed with are system physical addresses (SPA).
> > 
> > During HDM decoder setup, the DVSEC CXL range registers (cxl-3.1,
> > 8.1.3.8) are checked if the memory is enabled and the CXL range is in
> > a HPA window that is described in a CFMWS structure of the CXL host
> > bridge (cxl-3.1, 9.18.1.3).
> > 
> > Now, if the HPA is not an SPA, the CXL range does not match a CFMWS
> > window and the CXL memory range will be disabled then. The HDM decoder
> > stops working which causes system memory being disabled and further a
> > system hang during HDM decoder initialization, typically when a CXL
> > enabled kernel boots.
> > 
> > Prevent a system hang and do not disable the HDM decoder if the
> > decoder's CXL range is not found in a CFMWS window.
> > 
> > Note the change only fixes a hardware hang, but does not implement
> > HPA/SPA translation. Support for this can be added in a follow on
> > patch series.
> > 
> > Signed-off-by: Robert Richter <rrichter@amd.com>
> > ---
> >  drivers/cxl/core/pci.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/cxl/core/pci.c b/drivers/cxl/core/pci.c
> > index a0e7ed5ae25f..18616ca873e5 100644
> > --- a/drivers/cxl/core/pci.c
> > +++ b/drivers/cxl/core/pci.c
> > @@ -478,8 +478,8 @@ int cxl_hdm_decode_init(struct cxl_dev_state *cxlds, struct cxl_hdm *cxlhdm,
> >  	}
> >  
> >  	if (!allowed) {
> > -		cxl_set_mem_enable(cxlds, 0);
> > -		info->mem_enabled = 0;
> > +		dev_err(dev, "Range register decodes outside platform defined CXL ranges.\n");
> > +		return -ENXIO;
> >  	}
> 
> This looks good to me.

Thanks, Dan