Received-SPF: pass (google.com: domain of linux-kernel+bounces-69157-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240213074416.2169929-1-onkarnath.1@samsung.com>
 <CGME20240213074430epcas5p4c520bf2cce121cf5fa970eed429231a8@epcms5p3>
 <CAJZ5v0gBrc0FctEswQj_JMcZRqoswRgXvBRzT++tseUWBgYJWA@mail.gmail.com> <20240216054540epcms5p3b0b3f97fe4ec4a8126549a579e596910@epcms5p3>
In-Reply-To: <20240216054540epcms5p3b0b3f97fe4ec4a8126549a579e596910@epcms5p3>
From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: Fri, 16 Feb 2024 19:29:14 +0100
Message-ID: <CAJZ5v0h7Ed2VWPdsa_=m-PDfgOj2rCSUF=FEbpTEBg1Y9+PZ1w@mail.gmail.com>
Subject: Re: [PATCH v3 1/2] ACPI: use %pe for better readability of errors
 while printing
To: onkarnath.1@samsung.com
Cc: "Rafael J. Wysocki" <rafael@kernel.org>, "lenb@kernel.org" <lenb@kernel.org>, 
	"bhelgaas@google.com" <bhelgaas@google.com>, "viresh.kumar@linaro.org" <viresh.kumar@linaro.org>, 
	"mingo@redhat.com" <mingo@redhat.com>, "peterz@infradead.org" <peterz@infradead.org>, 
	"juri.lelli@redhat.com" <juri.lelli@redhat.com>, 
	"vincent.guittot@linaro.org" <vincent.guittot@linaro.org>, 
	"dietmar.eggemann@arm.com" <dietmar.eggemann@arm.com>, "rostedt@goodmis.org" <rostedt@goodmis.org>, 
	"bsegall@google.com" <bsegall@google.com>, "mgorman@suse.de" <mgorman@suse.de>, 
	"bristot@redhat.com" <bristot@redhat.com>, "vschneid@redhat.com" <vschneid@redhat.com>, 
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>, 
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, 
	"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>, 
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>, Rohit Thapliyal <r.thapliyal@samsung.com>, 
	Maninder Singh <maninder1.s@samsung.com>, "helgaas@kernel.org" <helgaas@kernel.org>, 
	Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Feb 16, 2024 at 6:54=E2=80=AFAM Onkarnath <onkarnath.1@samsung.com>=
 wrote:
>
> >On Tue, Feb 13, 2024 at 9:20=E2=80=AFAM Onkarnarth <onkarnath.1@samsung.=
com> wrote:
> >>
> >> From: Onkarnath <onkarnath.1@samsung.com>
> >>
> >> As %pe is already introduced, it's better to use it in place of (%ld) =
for
> >> printing errors in logs. It would enhance readability of logs.
> >>
> >> Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
> >
> >What exactly is the role of this S-o-b?  Has the person helped you to
> >develop the patch or something else?
> >
>
> Yes It was meant for Co-developed tag, Because We are working collectivel=
y for making errors more readable for our product kernel.(5.4)
> And some part of this patch was made by him.
>
> Then we checked that it is also suggested by open source to have %pe for =
printing errors:
> https://lore.kernel.org/all/92972476-0b1f-4d0a-9951-af3fc8bc6e65@suswa.mo=
untain/
>
> So I prepared same changes for open source kernel, and because of smaller=
 patch I kept it as normal signed-off tag only.
> If it is needed I can resend with Co-developed tag.

No need, I can add it for you.  Thanks for the explanation!