Received-SPF: pass (google.com: domain of linux-kernel+bounces-69214-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: "Elliott, Robert (Servers)" <elliott@hpe.com>
To: Stefan Berger <stefanb@linux.ibm.com>,
        "keyrings@vger.kernel.org"
	<keyrings@vger.kernel.org>,
        "linux-crypto@vger.kernel.org"
	<linux-crypto@vger.kernel.org>,
        "herbert@gondor.apana.org.au"
	<herbert@gondor.apana.org.au>,
        "davem@davemloft.net" <davem@davemloft.net>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "saulo.alessandre@tse.jus.br" <saulo.alessandre@tse.jus.br>
Subject: RE: [PATCH v2 06/14] crypto: ecc - Add NIST P521 curve parameters
Thread-Topic: [PATCH v2 06/14] crypto: ecc - Add NIST P521 curve parameters
Thread-Index: AQHaYGT5n3XQ+RCgI0uVCceBNs3BVrENS+AQ
Date: Fri, 16 Feb 2024 18:48:14 +0000
Message-ID: <MW5PR84MB184295E25332F1516BE10BA5AB4C2@MW5PR84MB1842.NAMPRD84.PROD.OUTLOOK.COM>
References: <20240215231414.3857320-1-stefanb@linux.ibm.com>
 <20240215231414.3857320-7-stefanb@linux.ibm.com>
In-Reply-To: <20240215231414.3857320-7-stefanb@linux.ibm.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?+SPCNRYl47bOrjB7nN9XVoS8G+7v2wIHbXz7u/oQ6KBP0XNtV9QT7qoj7qg0?=
 =?us-ascii?Q?/e91o+JgQlXpB/CYF0K2/UdlXNcwROhwB2hw1XvsNThsjycesg+vbh2pMlOU?=
 =?us-ascii?Q?lQWwZyI4jEYgMj87ceAJ61ilfIRc+TotPfLgPkRrbLxAx+OF/WYMoOkoLpz0?=
 =?us-ascii?Q?4h0YS1Xsa8VqLtSx+bAeJspAc67GGNVvVbQSLlNhMJwD+v+Cw9BjwkFEuTiq?=
 =?us-ascii?Q?zuXvsK74H6JIWm9DKkkSp5FaM26eQE4wpc/CfQx31QMjjFVAtZINSvbS9Mi6?=
 =?us-ascii?Q?u68wyUnjrTVCk9f3vP9amRDDT1i997LTgPwAiHuDH6UItQEanEF3WypH6zkt?=
 =?us-ascii?Q?cSwkuMrRk7J7NGNaDo/isyrNtCDSZB2IAAUYUq3GHOnJphfeiYrVXoHInjKF?=
 =?us-ascii?Q?pYntbxMPeXvJSyVkCYyIjH0J6ChkeBAzTdThsN8dLcLKt+IzKSI+P4EFcDZw?=
 =?us-ascii?Q?LS5XQUa5hGMGGk1t1sgaezDcKWq743VQfk5QFlTY2LeDHVvlDewHWWICV0Ue?=
 =?us-ascii?Q?qmIQRkUswmQ++6oBWKuK23tFschLk26GpUk+lqLTlRbNCcJoFs4Ffv3K0Vtz?=
 =?us-ascii?Q?TEfgfTa0YmgQ6/NhZw8R/KlrP/Y3N/ZMqjnzwKGe4052WDf4mnTPAPTAc/Lg?=
 =?us-ascii?Q?QOqaG2jg5fZ8i/sRbU+RouCSh8fSV5rl0swUIcoHWi71vccVfnz8ayXqiEN9?=
 =?us-ascii?Q?8UefSOSSZo/dxFkKbZZ0V38K4z3E3jF3+coSxsZoVeIHG+otsEJZ+5/YTEro?=
 =?us-ascii?Q?xGi/Yan6udloHiOKAzpqQ06lpXqeK2PP77i6ybnYahQLvFUQHGIwXKrxOW88?=
 =?us-ascii?Q?IF1dShhWeQIlcrgbHn1Q95bPf9edEpNS8YqjHoYKbmRqq4/7xLmMIo6+XzBo?=
 =?us-ascii?Q?6JZ+OlrmrFt01sCQGdC/639VrbDiSdftU2LwAHbzfiQZzkOaRwdPmEDeoPkb?=
 =?us-ascii?Q?71BqMsDv8ZqKnBjVjtjV9BIJnaaJt8+bp18liZ/kNC1Vz6BNs/TCzy6fR8PP?=
 =?us-ascii?Q?onjz4Jfv7MQ3YxlYc7NXoxxf/5JvvESYgZ6XRYIOnAqpKoydJ9YCh3DIC1KH?=
 =?us-ascii?Q?GZi0ShC+KTyo6z99Dj1jgER/TsdK4lC5kuf59XYP44WDw5iNs6G/oBZs2tYD?=
 =?us-ascii?Q?vm8S9TVgnOzTxEY2J4iqxujqZt0Bj5OmejoOmOaNtNgi33WWuQaTriZYQEAM?=
 =?us-ascii?Q?JMLvPwXBJAM4qoIdbQc9MlNOnbR5G5tL3PbPIuY3vpCKZaupROQbXJZrmnZO?=
 =?us-ascii?Q?qXPB17o+/0InRhE+6F0meQS3Y81WfORbNAhM1V7HmWhqxDqo+k+LHjb30Jv7?=
 =?us-ascii?Q?lXRcoE3u/oMu7fM4QxB8VW1Q6K8XgBSI44USx5TD6vx4m7+4n3eMCIpmgBty?=
 =?us-ascii?Q?l3JnhjNTnARsQdG2fZE4GayAns/QWlyQs/KdsfbbEeiDGQ6/wjN71HJVOivo?=
 =?us-ascii?Q?GdTv3SYYNVWpkdepenno9adT2kHO4cbSKjP1Dv6J5bOgC/xcMFw9fyJr4uoF?=
 =?us-ascii?Q?+YfNLBSb63tB+ZSUEABuvuJoFS4fiLBe252o4PgTXw9P/gFO58/P9TmIGaFJ?=
 =?us-ascii?Q?9ONFWnm22BtkcUUrkJQ=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW5PR84MB1842.NAMPRD84.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-Network-Message-Id: 3e1705c7-b962-4533-ef87-08dc2f1fd535
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Feb 2024 18:48:14.7237
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: w/ADXa4WJXEciXrDHH749VNdNQ0B3HJhhLkuXdwWkQfOZBqLFh3YQKy3cnB5YhNa
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR84MB1694
X-OriginatorOrg: hpe.com
X-Proofpoint-ORIG-GUID: DX6onMJ87whUhqlwVZheLn-eeL-juJxw
X-Proofpoint-GUID: DX6onMJ87whUhqlwVZheLn-eeL-juJxw
X-HPE-SCL: -1
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-16_18,2024-02-16_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999
 impostorscore=0 lowpriorityscore=0 adultscore=0 spamscore=0 mlxscore=0
 suspectscore=0 priorityscore=1501 malwarescore=0 bulkscore=0 clxscore=1011
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311290000 definitions=main-2402160147

> -----Original Message-----
> From: Stefan Berger <stefanb@linux.ibm.com>
> Sent: Thursday, February 15, 2024 5:14 PM
> Subject: [PATCH v2 06/14] crypto: ecc - Add NIST P521 curve parameters
>=20
> Add the parameters for the NIST P521 curve and define a new curve ID
> for it. Make the curve available in ecc_get_curve.
>=20
..
> diff --git a/crypto/ecc_curve_defs.h b/crypto/ecc_curve_defs.h
..
> +static struct ecc_curve nist_p521 =3D {
> +	.name =3D "nist_521",

Are the name fields in the ecc_curve structures used anywhere or
exposed to userspace?

It'd be nice if the strings for the nist_p192, nist_p256, and nist_p384=20
structures and this new nist_p521 structure included "p" before
the number, better matching all the code and the NIST FIPS 186-4 names:
    .name =3D "nist_p192"
    .name =3D "nist_p256"
    .name =3D "nist_p384"
    .name =3D "nist_p521"