Received-SPF: pass (google.com: domain of linux-kernel+bounces-69233-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <8649af3d-c7f9-452b-a8c4-921fe5fa30f8@linux.ibm.com>
Date: Fri, 16 Feb 2024 13:14:24 -0600
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 07/33] ARM: dts: aspeed: p10 and tacoma: Set FSI clock
 frequency
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        linux-fsi@lists.ozlabs.org
Cc: linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
        linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
        andi.shyti@kernel.org, alistair@popple.id.au, joel@jms.id.au,
        jk@ozlabs.org, sboyd@kernel.org, mturquette@baylibre.com,
        robh@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        conor+dt@kernel.org
References: <20240215220759.976998-1-eajames@linux.ibm.com>
 <20240215220759.976998-8-eajames@linux.ibm.com>
 <67ea1daa-72a5-4dc0-b766-34a99052dabb@linaro.org>
Content-Language: en-US
From: Eddie James <eajames@linux.ibm.com>
In-Reply-To: <67ea1daa-72a5-4dc0-b766-34a99052dabb@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit


On 2/16/24 02:08, Krzysztof Kozlowski wrote:
> On 15/02/2024 23:07, Eddie James wrote:
>> Now that the driver doesn't hardcode the clock divider, set it
>> in the device tree.
>>
>> Signed-off-by: Eddie James <eajames@linux.ibm.com>
>> ---
>>   arch/arm/boot/dts/aspeed/aspeed-bmc-opp-tacoma.dts | 1 +
>>   arch/arm/boot/dts/aspeed/ibm-power10-dual.dtsi     | 1 +
>>   2 files changed, 2 insertions(+)
> Please do not mix DTS patches with driver code. DTS goes to the end
> because driver code CANNOT depend on it (there are exceptions but it was
> not explained here).


Sure, I didn't realize. Thanks.

Eddie


>
> Best regards,
> Krzysztof
>