Received-SPF: pass (google.com: domain of linux-kernel+bounces-69235-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <91a5dd24-3a91-3114-d73d-eb57f3128d2e@oracle.com>
Date: Fri, 16 Feb 2024 14:18:03 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 08/10] selftests/sched: Migrate cs_prctl_test to
 kselfttest
To: "Joel Fernandes (Google)" <joel@joelfernandes.org>,
        linux-kernel@vger.kernel.org, Shuah Khan <shuah@kernel.org>
Cc: Suleiman Souhlal <suleiman@google.com>,
        Youssef Esmat <youssefesmat@google.com>,
        Steven Rostedt
 <rostedt@goodmis.org>,
        David Vernet <void@manifault.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        "Paul E . McKenney"
 <paulmck@kernel.org>,
        joseph.salisbury@canonical.com,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Ben Segall
 <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
        Daniel Bristot de Oliveira <bristot@redhat.com>,
        Valentin Schneider <vschneid@redhat.com>,
        Luca Abeni <luca.abeni@santannapisa.it>,
        Tommaso Cucinotta <tommaso.cucinotta@santannapisa.it>,
        Vineeth Pillai <vineeth@bitbyteword.org>,
        Shuah Khan <skhan@linuxfoundation.org>, Phil Auld <pauld@redhat.com>,
        linux-kselftest@vger.kernel.org
References: <20240216183108.1564958-1-joel@joelfernandes.org>
 <20240216183108.1564958-9-joel@joelfernandes.org>
Content-Language: en-US
From: Chris Hyser <chris.hyser@oracle.com>
In-Reply-To: <20240216183108.1564958-9-joel@joelfernandes.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?OGtoV3hQbEtJYmpJK090SklpQVlMTnFHKzByQXZ0VFhxaDU3OFUxVzg5bHlw?=
 =?utf-8?B?cWxUQ0FOTDh6TWpFMjJkM0VmZjRvcWZQenlFRHBHMHBaYnpMRmxvNmkzMHJ3?=
 =?utf-8?B?Vno3NmlrYnk0azRzYTdHM0hLYXhlRUNXWXlpbkxQNUx1eTQ1OGVSc1I4d2Qr?=
 =?utf-8?B?WW5PbS9hSEdPUGZEc0gyOWRkNW9DV2xWSmFFREJsT1FPUyttNy9rNktpZmFj?=
 =?utf-8?B?RGFGeEdwK3BYaHI3SEZRYkhGc3JkcDhKMElDS2tITkwrcW9EMVIzY3pqNVg5?=
 =?utf-8?B?dmlyNVJrTzFzRkFaSkZ2MUdPSXJPeVMvdDlReWVyb0pDNlhsUlNDb29EbitD?=
 =?utf-8?B?NTBCWElsaE90K0dwcnBXS0xiRnpzME14cVJNUWQ5TmZmNktFNk9TTUpMMTBO?=
 =?utf-8?B?VHdGbWFkdmJrRCthcll6OEtTZDlrWEdjcTdONkpMRGE5S3NRSkdqYjU5UkpF?=
 =?utf-8?B?bk9rQk1KWDZkTmlPQnUvMENHbzkzdHM5Y0tBS3orZlFzVkdnREJQZFpyc1l4?=
 =?utf-8?B?Q09LdmRRTGpBUlg5ekgxVzNDUVdOTDZSNUpGc1NQSTRMSlFodTNZNjhCS2JQ?=
 =?utf-8?B?c0JVai9sOEhBYS90aXBrYXo4QkIvT3R5eDloSE1LbzJ2NkJjbDVITExCT0ZP?=
 =?utf-8?B?ZFpuWVNCbFhtaXpmamY2b2lBeW1WWkFldXBKS3F3RFUrenRkcEV3WVhlRU9W?=
 =?utf-8?B?eU84azZ3WnMvcnM5VEhaRExPaU1hZkJJUHZaMFp6NGdOeDdsdU91d2VYaEtL?=
 =?utf-8?B?cytPV2xMQjJ6d3hyNlloTzhnZ1hSRDdKS0lUckFCajErSnN1VXVVa2poY0pk?=
 =?utf-8?B?OWUxa3VKY2ladzkzZldaZHkyck5CdElreTNSNlRjeWdFMzRBelRXRG9vS1F3?=
 =?utf-8?B?UjdZWUNBNGdvL3ZMbHFqVDZldXBLQktLcm5XSG91Tmh0N25JNzRuNm1SVTVB?=
 =?utf-8?B?dmxjaElCWHFpalkydFBHemdsVGZ4NEY4RVArVmFQYzloTnlhakM3WGx0eStT?=
 =?utf-8?B?eHU3OElwT2d3TG5wd0ZnNndBOVpkVVdsT29JYnliam9RbjEyYWV1L1U4Mmxp?=
 =?utf-8?B?b05kRUVjbndQVGhkQ1pGZmgwYmtBUTRURHRWUGQ3UDdxUEM4aG9MNzA1MC9x?=
 =?utf-8?B?V3VLbnN1cXI0N3RsTkd6TFpKSGFUUHJiWlhieDJYQnYzWEJKSnM5VFdNb3BI?=
 =?utf-8?B?NmlSZnE4Ui9OaG9NQ2xqU0gzeUJzZVNHSU5tYmU4YjR0SkZMc1pzeURueGxk?=
 =?utf-8?B?cHF2UElaOE9iTjFra2hVOTVzZC9OdWdDUDk3Tm1rQy8rUWdxeXE5UWdVNUgy?=
 =?utf-8?B?SnRQOS9qKzhQSkFqUkNSbHhFd1YvdXI5UkN6c2pLZVFZckdvMklsb0NXUTFr?=
 =?utf-8?B?aElHMEJSU2w1aHZBbDg2b0FEMlFuRGtKVFd0YVBZRGZrQzBVV3hCUGw2VnFu?=
 =?utf-8?B?OGtwZlhKcTlrbHl0MFFIeEpWV3h3UE8zc2dhbmRZd2lyVWdReVpBQlBuVjRI?=
 =?utf-8?B?NUZUVE4rWVBTbkU2N25lbVBabmVtQnoySkZEa0xPaGpBQWZlRFhldFNqdHJ6?=
 =?utf-8?B?dWUvMU0xbnovMEFsVGpzUGpKV2lHckxHWlk4L29TTU1iL0NjbXZwRnJXK2Qz?=
 =?utf-8?B?TEZMa2xKQUFxYmYzbkJjc0pzR1NyRm15YkJtSy9BZkoxWVdQTG9iejVKNmJt?=
 =?utf-8?B?eDRqbDJpbDdsNGRNVklzcmg2OXFwQnVuTm9HczdDZ0JFUWc3OTVzYldXWXNL?=
 =?utf-8?B?SmE1OGNCUTkyRE82UmErRkh5T2c3M0lhKzZkQ3hNdnJ2b2tDcWZUQ3Fod2sz?=
 =?utf-8?B?bUY5MU5JUDZydHRnSDdJQjRIaWl5K1ZtRkk4NTk1RWF3bEYyOGVpTldNaldw?=
 =?utf-8?B?c3VXWllFSitLbWtXWXlqVnVDWkV2dGphMnRXRlh3d3dmYm9laXZ0WjlYakta?=
 =?utf-8?B?V0R6T0pTZmlqWUJDQzBTYm92R1pJRWdJMnIzcWxmUkxWLzJDalBmbUc3UHBZ?=
 =?utf-8?B?NTd0Q3B0dWl6T1Ryem5UT0dlZEd5UlNBYlFwR2N1U1UyVExHUC9VdDdMMXRZ?=
 =?utf-8?B?UXZFdlZocmdySWd3ZlpLeU8vK2VrS0k0OHJDUUdYTG56OVRKWWJKK2JpRDZW?=
 =?utf-8?B?Q0crZmJGd3FSYWFWWUlKMHVGa2V0Yk5DbEorcnA0THdQTzJiQUw3SHY0elNy?=
 =?utf-8?B?UkE9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	hPYPBOeLTeK58EMsId2TcGqAsDtKw6wc+v9ocsCUL7aH3oyTakGLfxp928dFXdQEoPIt/j/nUBx6ZvWF4ytS92JjrKRp9Q2+kLHgP3UKG/V5dcf199nmQ23+eyq7t+Tq7qyZKbUCZz5dsUxVVVY/JmwgG0ARCGCMDZ+do1hfYNgMOU2q3Yf8M6ZFXJUi7Qq5ov+iOE04K6e11En6/yPs7EZ8VIVRlzLpLBydeurNU9vBvmT85pXtVF9UXKM23WGhtEMy2D8R/7fZhHuHd5R0EtdSPXbxPmg9Zz5FC65V+51RgbSFF7fJVqJTHJAdUrU5YX2xScfB6UlVl9W8t6b3oyL+/6Gt1g/DEZKowSwQjb/26UqCkcNLcdCJWb/bzAI8xb1hW1f8Y3CUnFlajtFPFlOj3Ns9lr6fkU9V4XZ3qzCxg7QsfhLunzqqyPo9mS/2MbMS6MO1PaIWT0GTcWS1kz9ZDseE5tuNkLJZ+K4AvxH7LNtGDyam8ydyu8z3K7wZ+8iv35upa9fR0QznbqOJgWrNw1k3Uzsp2ongRpUZ2CkC5JDKxtdhggymjSLh3X/Vu2HKd0TCS3Q+7rq4QGKitWLqAa2kwj++l4NTLjWImOc=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4325d7bd-49cd-4be9-eb2b-08dc2f24030e
X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4705.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2024 19:18:09.7528
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UNy1vdGcojUjMHRg3IB76UWNmBzpkH1a/RnsdZLWlZjD3xxPH3lnWEMprl+Gg/B5K/Tg/etkuTxszK9eg9QzAw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB4943
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-16_18,2024-02-16_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 phishscore=0 mlxscore=0
 bulkscore=0 spamscore=0 malwarescore=0 adultscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2402160150
X-Proofpoint-GUID: wKvuwGITTH6KoSpah3hDzng-TsDNWV-G
X-Proofpoint-ORIG-GUID: wKvuwGITTH6KoSpah3hDzng-TsDNWV-G

On 2/16/24 13:31, Joel Fernandes (Google) wrote:

> This test begs to be a kselftest, is in the kselftest hierarchy and does
> not even use a single kselftest API. Convert it.
>
> It simplifies some of the code and the output also looks much nicer now:
>
>   Totals: pass:17 fail:0 xfail:0 xpass:0 skip:0 error:0
>
> Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org>

Reviewed-by: Chris Hyser <chris.hyser@oracle.com>


> ---
>   tools/testing/selftests/sched/Makefile        |  6 +-
>   tools/testing/selftests/sched/cs_prctl_test.c | 74 ++++++++++---------
>   2 files changed, 43 insertions(+), 37 deletions(-)
>
> diff --git a/tools/testing/selftests/sched/Makefile b/tools/testing/selftests/sched/Makefile
> index f491d741cb45..90c53bc1337e 100644
> --- a/tools/testing/selftests/sched/Makefile
> +++ b/tools/testing/selftests/sched/Makefile
> @@ -1,9 +1,11 @@
>   # SPDX-License-Identifier: GPL-2.0+
>   TEST_GEN_PROGS := cs_dlserver_test
> -
> -cs_dlserver_test: cs_dlserver_test.c common.c
> +TEST_GEN_PROGS += cs_prctl_test
>   
>   CFLAGS += $(KHDR_INCLUDES)
>   CFLAGS += -Wall
>   
>   include ../lib.mk
> +
> +$(OUTPUT)/cs_dlserver_test: cs_dlserver_test.c common.c
> +$(OUTPUT)/cs_prctl_test: cs_prctl_test.c common.c
> diff --git a/tools/testing/selftests/sched/cs_prctl_test.c b/tools/testing/selftests/sched/cs_prctl_test.c
> index 7ba057154343..bb7aee703cdf 100644
> --- a/tools/testing/selftests/sched/cs_prctl_test.c
> +++ b/tools/testing/selftests/sched/cs_prctl_test.c
> @@ -28,10 +28,11 @@
>   #include <unistd.h>
>   #include <time.h>
>   #include <errno.h>
> -#include <stdio.h>
>   #include <stdlib.h>
>   #include <string.h>
>   
> +#include "common.h"
> +
>   #if __GLIBC_PREREQ(2, 30) == 0
>   #include <sys/syscall.h>
>   static pid_t gettid(void)
> @@ -80,7 +81,7 @@ static int _prctl(int option, unsigned long arg2, unsigned long arg3, unsigned l
>   	int res;
>   
>   	res = prctl(option, arg2, arg3, arg4, arg5);
> -	printf("%d = prctl(%d, %ld, %ld, %ld, %lx)\n", res, option, (long)arg2, (long)arg3,
> +	ksft_print_msg("%d = prctl(%d, %ld, %ld, %ld, %lx)\n", res, option, (long)arg2, (long)arg3,
>   	       (long)arg4, arg5);
>   	return res;
>   }
> @@ -91,21 +92,20 @@ static int _prctl(int option, unsigned long arg2, unsigned long arg3, unsigned l
>   static void __handle_error(char *fn, int ln, char *msg)
>   {
>   	int pidx;
> -	printf("(%s:%d) - ", fn, ln);
> +	ksft_print_msg("(%s:%d) - ", fn, ln);
>   	perror(msg);
>   	if (need_cleanup) {
>   		for (pidx = 0; pidx < num_processes; ++pidx)
>   			kill(procs[pidx].cpid, 15);
>   		need_cleanup = 0;
>   	}
> -	exit(EXIT_FAILURE);
> +	ksft_exit_fail();
>   }
>   
>   static void handle_usage(int rc, char *msg)
>   {
> -	puts(USAGE);
> -	puts(msg);
> -	putchar('\n');
> +	ksft_print_msg("%s\n", USAGE);
> +	ksft_print_msg("%s\n\n", msg);
>   	exit(rc);
>   }
>   
> @@ -117,7 +117,7 @@ static unsigned long get_cs_cookie(int pid)
>   	ret = prctl(PR_SCHED_CORE, PR_SCHED_CORE_GET, pid, PIDTYPE_PID,
>   		    (unsigned long)&cookie);
>   	if (ret) {
> -		printf("Not a core sched system\n");
> +		ksft_print_msg("Not a core sched system\n");
>   		return -1UL;
>   	}
>   
> @@ -160,7 +160,7 @@ static int child_func_process(void *arg)
>   
>   	ret = write(ca->pfd[1], &ca->thr_tids, sizeof(int) * ca->num_threads);
>   	if (ret == -1)
> -		printf("write failed on pfd[%d] - error (%s)\n",
> +		ksft_print_msg("write failed on pfd[%d] - error (%s)\n",
>   			ca->pfd[1], strerror(errno));
>   
>   	close(ca->pfd[1]);
> @@ -192,7 +192,7 @@ void create_processes(int num_processes, int num_threads, struct child_args proc
>   	for (i = 0; i < num_processes; ++i) {
>   		ret = read(proc[i].pfd[0], &proc[i].thr_tids, sizeof(int) * proc[i].num_threads);
>   		if (ret == -1)
> -			printf("read failed on proc[%d].pfd[0] error (%s)\n",
> +			ksft_print_msg("read failed on proc[%d].pfd[0] error (%s)\n",
>   				i, strerror(errno));
>   		close(proc[i].pfd[0]);
>   	}
> @@ -202,30 +202,29 @@ void disp_processes(int num_processes, struct child_args proc[])
>   {
>   	int i, j;
>   
> -	printf("tid=%d, / tgid=%d / pgid=%d: %lx\n", gettid(), getpid(), getpgid(0),
> +	ksft_print_msg("tid=%d, / tgid=%d / pgid=%d: %lx\n", gettid(), getpid(), getpgid(0),
>   	       get_cs_cookie(getpid()));
>   
>   	for (i = 0; i < num_processes; ++i) {
> -		printf("    tid=%d, / tgid=%d / pgid=%d: %lx\n", proc[i].cpid, proc[i].cpid,
> +		ksft_print_msg("    tid=%d, / tgid=%d / pgid=%d: %lx\n", proc[i].cpid, proc[i].cpid,
>   		       getpgid(proc[i].cpid), get_cs_cookie(proc[i].cpid));
>   		for (j = 0; j < proc[i].num_threads; ++j) {
> -			printf("        tid=%d, / tgid=%d / pgid=%d: %lx\n", proc[i].thr_tids[j],
> +			ksft_print_msg("        tid=%d, / tgid=%d / pgid=%d: %lx\n", proc[i].thr_tids[j],
>   			       proc[i].cpid, getpgid(0), get_cs_cookie(proc[i].thr_tids[j]));
>   		}
>   	}
>   	puts("\n");
>   }
>   
> -static int errors;
> -
>   #define validate(v) _validate(__LINE__, v, #v)
>   void _validate(int line, int val, char *msg)
>   {
>   	if (!val) {
> -		++errors;
> -		printf("(%d) FAILED: %s\n", line, msg);
> +		ksft_print_msg("(%d) FAILED: %s\n", line, msg);
> +		ksft_inc_fail_cnt();
>   	} else {
> -		printf("(%d) PASSED: %s\n", line, msg);
> +		ksft_print_msg("(%d) PASSED: %s\n", line, msg);
> +		ksft_inc_pass_cnt();
>   	}
>   }
>   
> @@ -254,13 +253,17 @@ int main(int argc, char *argv[])
>   			keypress = 1;
>   			break;
>   		case 'h':
> -			printf(USAGE);
> +			ksft_print_msg(USAGE);
>   			exit(EXIT_SUCCESS);
>   		default:
>   			handle_usage(20, "unknown option");
>   		}
>   	}
>   
> +	if (!hyperthreading_enabled()) {
> +		ksft_exit_skip("This test requires hyperthreading to be enabled\n");
> +	}
> +
>   	if (num_processes < 1 || num_processes > MAX_PROCESSES)
>   		handle_usage(1, "Bad processes value");
>   
> @@ -272,17 +275,22 @@ int main(int argc, char *argv[])
>   
>   	srand(time(NULL));
>   
> -	/* put into separate process group */
> +	/* Put into separate process group */
>   	if (setpgid(0, 0) != 0)
>   		handle_error("process group");
>   
> -	printf("\n## Create a thread/process/process group hiearchy\n");
> +	ksft_print_header();
> +
> +	/* Increase the count if adding more validate() statements. */
> +	ksft_set_plan(17);
> +
> +	ksft_print_msg("\n## Create a thread/process/process group hiearchy\n");
>   	create_processes(num_processes, num_threads, procs);
>   	need_cleanup = 1;
>   	disp_processes(num_processes, procs);
>   	validate(get_cs_cookie(0) == 0);
>   
> -	printf("\n## Set a cookie on entire process group\n");
> +	ksft_print_msg("\n## Set a cookie on entire process group\n");
>   	if (_prctl(PR_SCHED_CORE, PR_SCHED_CORE_CREATE, 0, PIDTYPE_PGID, 0) < 0)
>   		handle_error("core_sched create failed -- PGID");
>   	disp_processes(num_processes, procs);
> @@ -296,7 +304,7 @@ int main(int argc, char *argv[])
>   	validate(get_cs_cookie(0) == get_cs_cookie(pid));
>   	validate(get_cs_cookie(0) == get_cs_cookie(procs[pidx].thr_tids[0]));
>   
> -	printf("\n## Set a new cookie on entire process/TGID [%d]\n", pid);
> +	ksft_print_msg("\n## Set a new cookie on entire process/TGID [%d]\n", pid);
>   	if (_prctl(PR_SCHED_CORE, PR_SCHED_CORE_CREATE, pid, PIDTYPE_TGID, 0) < 0)
>   		handle_error("core_sched create failed -- TGID");
>   	disp_processes(num_processes, procs);
> @@ -305,7 +313,7 @@ int main(int argc, char *argv[])
>   	validate(get_cs_cookie(pid) != 0);
>   	validate(get_cs_cookie(pid) == get_cs_cookie(procs[pidx].thr_tids[0]));
>   
> -	printf("\n## Copy the cookie of current/PGID[%d], to pid [%d] as PIDTYPE_PID\n",
> +	ksft_print_msg("\n## Copy the cookie of current/PGID[%d], to pid [%d] as PIDTYPE_PID\n",
>   	       getpid(), pid);
>   	if (_prctl(PR_SCHED_CORE, PR_SCHED_CORE_SHARE_TO, pid, PIDTYPE_PID, 0) < 0)
>   		handle_error("core_sched share to itself failed -- PID");
> @@ -315,7 +323,7 @@ int main(int argc, char *argv[])
>   	validate(get_cs_cookie(pid) != 0);
>   	validate(get_cs_cookie(pid) != get_cs_cookie(procs[pidx].thr_tids[0]));
>   
> -	printf("\n## Copy cookie from a thread [%d] to current/PGID [%d] as PIDTYPE_PID\n",
> +	ksft_print_msg("\n## Copy cookie from a thread [%d] to current/PGID [%d] as PIDTYPE_PID\n",
>   	       procs[pidx].thr_tids[0], getpid());
>   	if (_prctl(PR_SCHED_CORE, PR_SCHED_CORE_SHARE_FROM, procs[pidx].thr_tids[0],
>   		   PIDTYPE_PID, 0) < 0)
> @@ -325,7 +333,7 @@ int main(int argc, char *argv[])
>   	validate(get_cs_cookie(0) == get_cs_cookie(procs[pidx].thr_tids[0]));
>   	validate(get_cs_cookie(pid) != get_cs_cookie(procs[pidx].thr_tids[0]));
>   
> -	printf("\n## Copy cookie from current [%d] to current as pidtype PGID\n", getpid());
> +	ksft_print_msg("\n## Copy cookie from current [%d] to current as pidtype PGID\n", getpid());
>   	if (_prctl(PR_SCHED_CORE, PR_SCHED_CORE_SHARE_TO, 0, PIDTYPE_PGID, 0) < 0)
>   		handle_error("core_sched share to self failed -- PGID");
>   	disp_processes(num_processes, procs);
> @@ -340,20 +348,16 @@ int main(int argc, char *argv[])
>   	validate(_prctl(PR_SCHED_CORE, PR_SCHED_CORE_SHARE_TO, 0, PIDTYPE_PGID, 1) < 0
>   		&& errno == EINVAL);
>   
> -	if (errors) {
> -		printf("TESTS FAILED. errors: %d\n", errors);
> -		res = 10;
> -	} else {
> -		printf("SUCCESS !!!\n");
> -	}
> -
> -	if (keypress)
> +	if (keypress) {
> +		ksft_print_msg("Waiting for keypress to exit\n");
>   		getchar();
> -	else
> +	} else {
>   		sleep(delay);
> +	}
>   
>   	for (pidx = 0; pidx < num_processes; ++pidx)
>   		kill(procs[pidx].cpid, 15);
>   
> +	ksft_finished();
>   	return res;
>   }