Received-SPF: pass (google.com: domain of linux-kernel+bounces-69240-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Feedback-ID: i56684263:Fastmail
Message-ID: <75a5a4cc-af27-415a-87b8-9e231574a519@ryhl.io>
Date: Fri, 16 Feb 2024 20:25:39 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3] rust: str: add {make,to}_{upper,lower}case() to
 CString
Content-Language: en-US-large
To: Danilo Krummrich <dakr@redhat.com>, Alice Ryhl <aliceryhl@google.com>
Cc: a.hindborg@samsung.com, alex.gaynor@gmail.com, benno.lossin@proton.me,
 bjorn3_gh@protonmail.com, boqun.feng@gmail.com, gary@garyguo.net,
 linux-kernel@vger.kernel.org, ojeda@kernel.org,
 rust-for-linux@vger.kernel.org, wedsonaf@gmail.com
References: <20240214172505.5044-1-dakr@redhat.com>
 <20240216165320.1820346-1-aliceryhl@google.com>
 <18a49662-3640-49c1-9587-db5cc9d62fbc@redhat.com>
From: Alice Ryhl <alice@ryhl.io>
In-Reply-To: <18a49662-3640-49c1-9587-db5cc9d62fbc@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 2/16/24 18:11, Danilo Krummrich wrote:
> On 2/16/24 17:53, Alice Ryhl wrote:
>>> +    /// Returns a copy of this [`CString`] where each character is 
>>> mapped to its
>>> +    /// ASCII upper case equivalent.
>>> +    ///
>>> +    /// ASCII letters 'a' to 'z' are mapped to 'A' to 'Z',
>>> +    /// but non-ASCII letters are unchanged.
>>> +    ///
>>> +    /// To uppercase the value in-place, use [`make_ascii_uppercase`].
>>> +    ///
>>> +    /// [`make_ascii_uppercase`]: str::make_ascii_uppercase
>>> +    pub fn to_ascii_uppercase(&self) -> Result<CString, AllocError> {
>>> +        let mut s = (*self).to_cstring()?;
>>> +
>>> +        s.make_ascii_uppercase();
>>> +
>>> +        return Ok(s);
>>> +    }
>>
>> Please move these to `CStr` as well.
> 
> That would result into two copies if I actually want a CString, wouldn't 
> it?
> 
> Also, what would be the use case? And even if someone wants to have a CStr
> again, couldn't we just deref the resulting CString?

To clarify, I want you to move it to the `impl CStr` block. That changes 
the type of the `self` argument. I don't want you to change the return 
type - that should still be `CString`.

Currently, if I have a `&CStr` and I want an uppercase `CString`, I 
can't do that with this method.

Alice