Received-SPF: pass (google.com: domain of linux-kernel+bounces-69265-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <12cd0fd0-be86-4af0-8d6b-85d3a81edd2a@hartkopp.net>
Date: Fri, 16 Feb 2024 20:47:43 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] can: softing: remove redundant NULL check
To: Simon Horman <horms@kernel.org>, Daniil Dulov <d.dulov@aladdin.ru>
Cc: Wolfgang Grandegger <wg@grandegger.com>,
 Marc Kleine-Budde <mkl@pengutronix.de>, "David S. Miller"
 <davem@davemloft.net>, Jakub Kicinski <kuba@kernel.org>,
 Kurt Van Dijck <dev.kurt@vandijck-laurijssen.be>, linux-can@vger.kernel.org,
 netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
 lvc-project@linuxtesting.org
References: <20240211150535.3529-1-d.dulov@aladdin.ru>
 <20240216172701.GP40273@kernel.org>
Content-Language: en-US
From: Oliver Hartkopp <socketcan@hartkopp.net>
In-Reply-To: <20240216172701.GP40273@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Simon,

I have a general question on the "Fixes:" tag in this patch:

On 16.02.24 18:27, Simon Horman wrote:
> On Sun, Feb 11, 2024 at 07:05:35AM -0800, Daniil Dulov wrote:
>> In this case dev cannot be NULL, so remove redundant check.
>>
>> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>>
>> Fixes: 03fd3cf5a179 ("can: add driver for Softing card")

IMHO this is simply an improvement which is done by all patches applied 
to the kernel but it does not really "fix" anything from a functional 
standpoint.

Shouldn't we either invent a new tag or better leave it out to not 
confuse the stable maintainers?

Best regards,
Oliver

>> Signed-off-by: Daniil Dulov <d.dulov@aladdin.ru>
> 
> Hi Daniil,
> 
> I am not sure that dev cannot be NULL.
> But I do see that the code assumes it is not, and would crash if it is.
> So I think that, functionally, your statement is correct.
> 
> 	priv = netdev_priv(dev);
> 	card = priv->card;
> 
> Reviewed-by: Simon Horman <horms@kernel.org>
>