Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754540AbXL0XA3 (ORCPT ); Thu, 27 Dec 2007 18:00:29 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753292AbXL0XAW (ORCPT ); Thu, 27 Dec 2007 18:00:22 -0500 Received: from zeniv.linux.org.uk ([195.92.253.2]:34138 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752182AbXL0XAV (ORCPT ); Thu, 27 Dec 2007 18:00:21 -0500 Date: Thu, 27 Dec 2007 22:59:47 +0000 From: Al Viro To: Christoph Lameter Cc: Theodore Tso , Andi Kleen , Willy Tarreau , Steven Rostedt , Linus Torvalds , Ingo Molnar , Peter Zijlstra , LKML , Andrew Morton , Christoph Hellwig , "Rafael J. Wysocki" Subject: Re: SLUB sysfs support Message-ID: <20071227225947.GH27894@ZenIV.linux.org.uk> References: <20071223051241.GA4449@1wt.eu> <20071223141500.GB6430@one.firstfloor.org> <20071224034530.GB16658@thunk.org> <20071224233701.GB9784@kernel.org> <20071226221631.GD27894@ZenIV.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 935 Lines: 21 On Thu, Dec 27, 2007 at 12:28:14PM -0800, Christoph Lameter wrote: > Hmmm.. If I separately allocate the kobject then I can no longer get to > the kmem_cache structure from the kobject. > > I need to add a second kobject_del to sysfs_slab_remove() to make sysfs > completely forget about the object? > > Probably should track down any remaining symlinks at that point and nuke > them too. Isnt there some way to convince sysfs to remove the symlinks > if the target vanishes? Don't bother with separate allocation. a) remove symlink when slab goes away b) instead of kfree() in slab removal do kobject_put() if you have sysfs stuff c) have ->release() of these kobjects do kfree() -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/