Received-SPF: pass (google.com: domain of linux-kernel+bounces-69273-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
References: <20240216-feature_ptp_netnext-v8-0-510f42f444fb@bootlin.com>
 <20240216-feature_ptp_netnext-v8-10-510f42f444fb@bootlin.com>
User-agent: mu4e 1.10.8; emacs 28.2
From: Rahul Rameshbabu <rrameshbabu@nvidia.com>
To: Kory Maincent <kory.maincent@bootlin.com>
Cc: Florian Fainelli <florian.fainelli@broadcom.com>, Broadcom internal
 kernel review list <bcm-kernel-feedback-list@broadcom.com>, Andrew Lunn
 <andrew@lunn.ch>, Heiner Kallweit <hkallweit1@gmail.com>, Russell King
 <linux@armlinux.org.uk>, "David S. Miller" <davem@davemloft.net>, Eric
 Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo
 Abeni <pabeni@redhat.com>, Richard Cochran <richardcochran@gmail.com>,
 Radu Pirea <radu-nicolae.pirea@oss.nxp.com>, Jay Vosburgh
 <j.vosburgh@gmail.com>, Andy Gospodarek <andy@greyhouse.net>, Nicolas
 Ferre <nicolas.ferre@microchip.com>, Claudiu Beznea
 <claudiu.beznea@tuxon.dev>, Willem de Bruijn
 <willemdebruijn.kernel@gmail.com>, Jonathan Corbet <corbet@lwn.net>,
 Horatiu Vultur <horatiu.vultur@microchip.com>,
 UNGLinuxDriver@microchip.com, Simon Horman <horms@kernel.org>, Vladimir
 Oltean <vladimir.oltean@nxp.com>, Thomas Petazzoni
 <thomas.petazzoni@bootlin.com>, netdev@vger.kernel.org,
 linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Maxime Chevallier
 <maxime.chevallier@bootlin.com>
Subject: Re: [PATCH RFC net-next v8 10/13] net: netdevsim: ptp_mock: Convert
 to netdev_ptp_clock_register
Date: Fri, 16 Feb 2024 11:48:30 -0800
In-reply-to: <20240216-feature_ptp_netnext-v8-10-510f42f444fb@bootlin.com>
Message-ID: <871q9cgor3.fsf@nvidia.com>
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?LDALfNHR+QP6XMJV/C0JPjaJY15FrZGJY1rlucq/jCryYXFN7JTZcsG6M/rB?=
 =?us-ascii?Q?kFMeKTUySaV6W8hbEXOD4f5t2o+wvNqL+8S/dAUp1vmHGJ+ej4Mh9WWKdcNr?=
 =?us-ascii?Q?s7AFtO1oWR+o28wR2dVtjUOueNGLPucM3nqZu6n+5/XdzDIoJURTmW4N7a8f?=
 =?us-ascii?Q?WCDwL46I0RwTFmszX4Tb/gCdpach7BX/q3k4iJPdvmL03QxQwLbsaXeny/m2?=
 =?us-ascii?Q?9Se5apMYVTghxon60BOyoEhHZ/Oet6/67f6agPBJv+isMhZYyCmh/9irvXFY?=
 =?us-ascii?Q?rKd4jxgS+jmho+M6DPml+iGTLJr/TntY8SGhX14v1nquqC/X4HxtxmltjhYJ?=
 =?us-ascii?Q?QONgyVjn4LP7T5MdGAprDYnuIEp7UtlnH9TdP8LIMKBEKyATQIy/KBQtSuqw?=
 =?us-ascii?Q?CBJEgckW//z9vMrFOA+HSxzpCfXKlRgnj9ZmCT4J7i9RTuqx0cvbvSjxEFyh?=
 =?us-ascii?Q?WY48cPkaa8MSmTmaT7XNKP0GGAfx4WQhnUqFyqexP9mVdNod0RjlKIJ7UTz/?=
 =?us-ascii?Q?ZTYQmCLHMT/kBRyho2QdlSv5K49don1o55ARtoUhgykqka/EHU5fkmnKRRAC?=
 =?us-ascii?Q?9Bdd2Y1IkqYXeHgE4Pf02iLQdzrZF50x0hG68IU2loxiMJyDiMPL7HEp1SJm?=
 =?us-ascii?Q?0oLe4iriw4DiKxazzOC5Tm0s/wC8u0EdkuFpRCwFD0VEiJaeZy65sevtkeoV?=
 =?us-ascii?Q?dsWFZHwATZo4tqcEvB/AcysHc31xdt5JAIrULGuxPBmFokMidCT/PH/cqqHc?=
 =?us-ascii?Q?zUrFkuhpo28Xa0rBBOr0Ok5L/v1ztq+BfSWcczOzIiYPFo3XWbwh5OtKwta7?=
 =?us-ascii?Q?/Bw6FakL0vETnZMOp/pYfb0Eiy6mL+9NTmkpxElb/uC36rqGruDjS5OG1QHi?=
 =?us-ascii?Q?45gp7QauXshjwiPz4m0Pr1q3tAMsaNjQL3r5HanlEj7qMQBqBayfTuddpi5U?=
 =?us-ascii?Q?sEhZipGV9tuqqBdB7UmAikz/DeG3JjZJjsFlMZvaKcL2hymybGqKKHzuqjd4?=
 =?us-ascii?Q?tzo9UOxjSUuDzJVD6hSX7NXvHh5FjRN3C1pxMI6VryA0KQBa/GOtKOhHdV4V?=
 =?us-ascii?Q?iXAPirE/mE/OioxXNtdrfjnivD50gaBXwfyN0gvRxnX0yNjA8NkIfNFI42bq?=
 =?us-ascii?Q?W/vxY3Cit5tpiN3JAzs/OclRUhIfVFT0wFcwNu+5yHMkuvjkRGtVoBXoLA87?=
 =?us-ascii?Q?FbQ5EAexZP9GD53cxZlUXvjZ3S7PaCcPORxYwWL+Nrgr151JTLEnJsUwT8dU?=
 =?us-ascii?Q?WmNUISz2FW7ziWIj2bqq6uIpz6w3sp+QCHn7HrJ8d3O/rsWvWSaLaY/iPyJn?=
 =?us-ascii?Q?sLskf7nsicf8uzzw9nIdW/M7TULmpV9nEjeAgwSfsua9ABXQUJQK+2N+faYy?=
 =?us-ascii?Q?23iFqa7peXs2LolEL/kU61an34YEQ/sBWycoDECfUXLqtjEc8jkN6IhiQ/SW?=
 =?us-ascii?Q?AtL7cf1zkHQ31Mu+Ju0KywmNmEEfbBlT3I0dyI4+i2xmp6fl52bC5muOG1Wp?=
 =?us-ascii?Q?NlVs2nVaCeMINyHsxYtx8ZOorfdsQedtCXcsYBRFR0RA/jFwTQcw9P5LuD2g?=
 =?us-ascii?Q?2O1bgcFSCaQMVRyjHDNxsCgFigQGtlJoMfVjebYDTJDsD3asQACBZ7vju5/x?=
 =?us-ascii?Q?Rw=3D=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: eef35c70-da02-4db7-9010-08dc2f2a6ae9
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB2743.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2024 20:04:00.9837
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Akat9Y/cG+SiSkWGteXfjIH40RyATGXEt5UocBWrE8zO8V1fDWicU9wHobuHCCN+lxu/+yzkIMZZnOQJ7ukwrA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6453

On Fri, 16 Feb, 2024 16:52:28 +0100 Kory Maincent <kory.maincent@bootlin.com> wrote:
> The hardware registration clock for net device is now using
> netdev_ptp_clock_register to save the net_device pointer within the PTP
> clock xarray. netdevsim is registering its ptp through the mock driver.
> It is the only driver using the mock driver to register a ptp clock.
> Convert the mock driver to the new API.
>
> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
> ---
> Shouldn't we move the mock driver in the netdevsim directory as it is only
> used by netdevsim driver?

This gets interesting. I think the reason it live under drivers/ptp
rather than drivers/net/netdevsim is because a bunch of reference/simple
phc implementations live under drivers/ptp already. In the case of mlx5,
it lives under the mlx5 driver directory to avoid needing to export
symbols between some mlx5_ptp driver and the netdev driver. I think
since the mock-up driver makes for a good reference for developers
wanting to know what it would take to implement the functionality for a
phc, it is fine living under drivers/ptp. That is just my opinion
though.

>
> Changes in v8:
> - New patch
> ---

Reviewed-by: Rahul Rameshbabu <rrameshbabu@nvidia.com>