Received: by 2002:a05:7412:1e0b:b0:fc:a2b0:25d7 with SMTP id kr11csp1338809rdb; Fri, 16 Feb 2024 12:24:56 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCV4dHjyUJXj0mU7dzjGexeHp+k6SODl9LLIAO9iaRXiFuKYoXaZyHTKGp1ZO1WxDp3D+SgKNJDVQj978DpNj7IQm10l21qr3OAaE9AO3w== X-Google-Smtp-Source: AGHT+IHHeb9BRbrnoGdH71nSdQISjibieJ3I1w3OH6+VvSQM1u0R2G8bsSBtKwXNs7uFA2p0IcfX X-Received: by 2002:a17:906:b41:b0:a3e:1559:e67c with SMTP id v1-20020a1709060b4100b00a3e1559e67cmr158162ejg.56.1708115096586; Fri, 16 Feb 2024 12:24:56 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708115096; cv=pass; d=google.com; s=arc-20160816; b=xPQqmmP8d9weRok84Kr3G+bDwppSFcznXNn+9VjCQAjXT1yDa8aAh2IUNUe4qlUq02 Ly+LBcHbcDCMb0xz/XK5pyTa2QDw7sNu9vX0E/87mc5Yxj+aLkrqLjJwx1wCYC546rqP rELCoL6RrdvGmSdzhfYC5B7fSdsetId5gvlnUuTMcm8842Nj19Y3UFYlXyLFJqjGAy+B bNkCTSqEbLg7waKOmjXw9wkQVmM6Zr9sR2Q4Sv7l/GbnoLwnxcDSjNTulBELrJgn9jyV vj0HQeFa+rFwASQRu6Mk2Ktg6eveoHd5UXcj+VSuX7icFSpvvRvCu/H6Mv7K9FU0x2Pf 8bkw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=Q0L+j6R3TK0LzuWguZ8aBc6nyXkJcTXMxyXlMirQfjg=; fh=uM3b1fZGhprIEBQvE7EAfF3PHgVuA6genHmNzETK8b4=; b=tBqlqC5OD0aM+DgZjoX7A/Xe96OyL+AuMed5eBcNm8Onm6MqSADRs8B3mHJTDFsmB5 hi6qQJWYMNW3ang1h7TYSA1t++9Ovk1sFHGozyYPlr4fV/a4kwIjFk6N7vsT8HLwMKbV dzoeC0iNU58jvUyZt92Pkbu0V247L86RtWZm6HF11HfB/zlMyiNZFSdIiSpjHwO6ZGBR k/usBaGFMlhE06eZu9rsDXz8fDKmOlEV0jsIj0kOXXWKgCwXlkF9NVKS3rgBxPGE5nh2 V7evy270yspB212g76Nq/SFv/UdxnzWyc5tIL/g52r2Zq70y4qcKamk5jM0HCVW4aiLi M8JA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=o4pyvA3u; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-69292-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-69292-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id ox26-20020a170907101a00b00a3cfe376122si230309ejb.364.2024.02.16.12.24.56 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Feb 2024 12:24:56 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-69292-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=o4pyvA3u; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-69292-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-69292-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 581181F23335 for ; Fri, 16 Feb 2024 20:24:56 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B6D3B139573; Fri, 16 Feb 2024 20:24:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="o4pyvA3u" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E12E1136640 for ; Fri, 16 Feb 2024 20:24:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708115089; cv=none; b=HlheUhWppoRGYkwUjI84Ja4dhB+KWJ0F6F6PjPTkc7YagaB1VniBk7VsNl+ewXNJ2WtTlPx/UFcZT/oYQg75ADQ4OpcKRIHbrYc66Vq98mYZj0yngoq5gC2JEzYauN0vDU1NhpeaQZtv3nooHDxayoV1Yo0wgXD3PmLZXu3sM4M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708115089; c=relaxed/simple; bh=O3Vq/9iekbJvfivB8fPNqfc/VdUr6NW92uCL9/WplH8=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=Xj7viJO8uTO6QjPE3KJmZyOQokA2y4b0sA7TXia8gJ5zAf7vrGcvjiQmEvIaLSME85pWj9QgD43Lzzg4aBXDhffiZSrmm7/wcaAvTnJX3KYkdAb8a+HsQY+wQ543tBd0ngYClo/Y07qcjud23UGuYmUBXx0MSoH2CSjnUgZO16Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=o4pyvA3u; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 918C0C433F1; Fri, 16 Feb 2024 20:24:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708115088; bh=O3Vq/9iekbJvfivB8fPNqfc/VdUr6NW92uCL9/WplH8=; h=From:To:Cc:Subject:Date:From; b=o4pyvA3urDBZ5absWA/kHxTMsUxqDiraqvUHzCvCZsa7S0GmRjiXDAtU2otgYDGdq rFd7s2UI/6YOfwxfkRxyCzlxvmo9OxpsJT94IKgMtTq2yv3aMJlJUp7xbmbUym6AAx R2AVyJN9VY+gL9kRUqn9IeL+UdYV+I99jKHPtrKm2GnBCmSvhTaxKMD6/rminmP/9s Yg53Bk7R26epRSUPyl6s/TZWVFmjKU80plf8NXxpnBjeteQXHD05VIxUBo7/ZqgGAW j7t48iqo3h3QX6HuTT6gyPHYao49ciSc9jw0I/VRd8BbE121S1BGrTbjAt5zxKO4Fv w39jyPvupSZaQ== From: Arnd Bergmann To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann Cc: Arnd Bergmann , David Airlie , Daniel Vetter , Arunpravin Paneer Selvam , =?UTF-8?q?Christian=20K=C3=B6nig?= , David Gow , =?UTF-8?q?Ma=C3=ADra=20Canal?= , Matthew Auld , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH] drm/tests/drm_buddy: avoid 64-bit calculation Date: Fri, 16 Feb 2024 21:24:30 +0100 Message-Id: <20240216202442.2493031-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Arnd Bergmann The newly added drm_test_buddy_alloc_contiguous() test fails to link on 32-bit targets because of inadvertent 64-bit calculations: ERROR: modpost: "__aeabi_uldivmod" [drivers/gpu/drm/tests/drm_buddy_test.ko] undefined! ERROR: modpost: "__aeabi_ldivmod" [drivers/gpu/drm/tests/drm_buddy_test.ko] undefined! From what I can tell, the numbers cannot possibly overflow a 32-bit size, so use different types for these. I noticed that the function has another possible flaw in that is mixes what it calls pages with 4KB units. This is a big confusing at best, or possibly broken when built on machines with larger pages. Fixes: a64056bb5a32 ("drm/tests/drm_buddy: add alloc_contiguous test") Signed-off-by: Arnd Bergmann --- drivers/gpu/drm/tests/drm_buddy_test.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/tests/drm_buddy_test.c b/drivers/gpu/drm/tests/drm_buddy_test.c index fee6bec757d1..50a5f98cd5bd 100644 --- a/drivers/gpu/drm/tests/drm_buddy_test.c +++ b/drivers/gpu/drm/tests/drm_buddy_test.c @@ -21,7 +21,8 @@ static inline u64 get_size(int order, u64 chunk_size) static void drm_test_buddy_alloc_contiguous(struct kunit *test) { - u64 mm_size, ps = SZ_4K, i, n_pages, total; + u64 mm_size, total; + u32 i, ps = SZ_4K, n_pages; struct drm_buddy_block *block; struct drm_buddy mm; LIST_HEAD(left); @@ -29,7 +30,8 @@ static void drm_test_buddy_alloc_contiguous(struct kunit *test) LIST_HEAD(right); LIST_HEAD(allocated); - mm_size = 16 * 3 * SZ_4K; + n_pages = 16 * 3; + mm_size = n_pages * SZ_4K; KUNIT_EXPECT_FALSE(test, drm_buddy_init(&mm, mm_size, ps)); @@ -42,7 +44,6 @@ static void drm_test_buddy_alloc_contiguous(struct kunit *test) */ i = 0; - n_pages = mm_size / ps; do { struct list_head *list; int slot = i % 3; -- 2.39.2