Received-SPF: pass (google.com: domain of linux-kernel+bounces-69298-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
From: Michael Kelley <mhklinux@outlook.com>
To: =?iso-8859-1?Q?Ilpo_J=E4rvinen?= <ilpo.jarvinen@linux.intel.com>
CC: "haiyangz@microsoft.com" <haiyangz@microsoft.com>, "wei.liu@kernel.org"
	<wei.liu@kernel.org>, "decui@microsoft.com" <decui@microsoft.com>,
	"lpieralisi@kernel.org" <lpieralisi@kernel.org>, "kw@linux.com"
	<kw@linux.com>, "robh@kernel.org" <robh@kernel.org>, "bhelgaas@google.com"
	<bhelgaas@google.com>, "linux-pci@vger.kernel.org"
	<linux-pci@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>,
	"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>
Subject: RE: [PATCH v2 1/1] PCI: hv: Fix ring buffer size calculation
Thread-Topic: [PATCH v2 1/1] PCI: hv: Fix ring buffer size calculation
Thread-Index: AQHaX+NrV9kpOA7q8kKo52FVqq7NobENDfiAgABebnA=
Date: Fri, 16 Feb 2024 20:28:04 +0000
Message-ID:
 <SN6PR02MB415749788D7DEA3D1D792913D44C2@SN6PR02MB4157.namprd02.prod.outlook.com>
References: <20240215074823.51014-1-mhklinux@outlook.com>
 <0802ce88-c86d-3a74-501f-28393d6112f3@linux.intel.com>
In-Reply-To: <0802ce88-c86d-3a74-501f-28393d6112f3@linux.intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?iso-8859-1?Q?qewd65Gc/ycHisuj0ElAd9/6wtomJsRBdY5swJwt4/czV+B0XvdIURCj6A?=
 =?iso-8859-1?Q?5qUoR4kMiojuufhYZrUUTgEjqjGxerLQLFEyDWOE2u+fFRX1sCSIPCdLT9?=
 =?iso-8859-1?Q?c1bm6FF9pvWf9MZ1UK5JWO0V/FNm9BJJxaVhkhYHrPusJkUQBBWIXxF0dK?=
 =?iso-8859-1?Q?jK7z3rTBGmRHG8+b/KCMkPxBx2GQQysAMD3iUEhUEgk19JvDFPmMNvbLoJ?=
 =?iso-8859-1?Q?QDeUlboSbHBEBY6NFunN92kRxhTp+w4wcN6dOiGXrVVX2froqDV38QCMpe?=
 =?iso-8859-1?Q?B0CrpIW9JG1wXRPxlpgTF/hyfQ5xHii2p2lqKinLSV3WrOFWRuXX1tHxvk?=
 =?iso-8859-1?Q?jBBrzDgkODVUAw3MUNuBGyxcpdRHL3mkKz+yJQVWl/I6zJ8Xj0ZJutV8m5?=
 =?iso-8859-1?Q?xbUk+VTZUqQy+lnjtApdwPp2lZmu84B0QQtHh6SAJOVUaRgBQtsqL21DT/?=
 =?iso-8859-1?Q?ZeboFRK66MDnZxT2TCv2fEj5dgjPFn+JdQ8dA14H72dLL4RNyvd1SH/evq?=
 =?iso-8859-1?Q?y/gWIxmiGdXpRIJpRst4iONKbd/NG0BIrcH1Tx/MJhKPsCaIUjVXHdztVX?=
 =?iso-8859-1?Q?FRHT9fPs+4nnN+b5WQBs679sfUAd525/xkuVj8tjjF/O+J2znNp3FxSYjG?=
 =?iso-8859-1?Q?BkfD30vsIPgmIebNymetPu2SHb7ketTz6mW/gtTTELTdA94gJ+BxekgS7+?=
 =?iso-8859-1?Q?V7nGKxm0XxDzBb6lOLgrqpJsk6AC3saCzF4BQYrJWZqD7qgClEPy5WxJEc?=
 =?iso-8859-1?Q?rNkcUJHpnKmv6MwwLY0y+mBxspbBFYnBOg4bRVnAQGYptyQWnlZOq7pYbe?=
 =?iso-8859-1?Q?iXo5uhWJBLxFrRjn0O5kirEGDiMYjii2cXY3JsOhzsro7eGwTnpmpOD20O?=
 =?iso-8859-1?Q?fwzbd49cPPGS5E2VpubSFPomy//7vYLpYbqAHI/YseAewlLI45Gf2ducUn?=
 =?iso-8859-1?Q?f3IdxipPBKLsOIzoiO8ejfn6ckRxMVOGXR899MjMyKYmUBKb5hDcsrOPw7?=
 =?iso-8859-1?Q?4tj2Pc+hYwaB/46UstF3viHMsnNodvHkr0OEfxcTiWTlz3bCQRGGLgmtdE?=
 =?iso-8859-1?Q?Ts9cDMqTOgVXBU/8l4Zb3L/O+/EDylihxNkeCGMaPbuNtHLO1aGQ7eC2a1?=
 =?iso-8859-1?Q?1+qUKLw9+6q7VNYnP+QXFxXuse3mv6d/JDL1jUYky9U4tC0Ny8WJofA/If?=
 =?iso-8859-1?Q?wDVUmz1XDtaokSlhU+ucRDOyExo7DtqITL1kTk2Keb+sRKKRMozGFSEl/A?=
 =?iso-8859-1?Q?PmpN6xZj2VWcTac1CRy6qKQFBdY7nzj+N8uDF1fWY=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN6PR02MB4157.namprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-Network-Message-Id: faf18e99-8d82-41e6-2e5f-08dc2f2dc73c
X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Feb 2024 20:28:04.1998
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR02MB9943

From: Ilpo J=E4rvinen <ilpo.jarvinen@linux.intel.com> Sent: Friday, Februar=
y 16, 2024 6:46 AM
>=20
> On Wed, 14 Feb 2024, mhkelley58@gmail.com wrote:
> >
> > For a physical PCI device that is passed through to a Hyper-V guest VM,
> > current code specifies the VMBus ring buffer size as 4 pages.  But this
> > is an inappropriate dependency, since the amount of ring buffer space
> > needed is unrelated to PAGE_SIZE. For example, on x86 the ring buffer
> > size ends up as 16 Kbytes, while on ARM64 with 64 Kbyte pages, the ring
> > size bloats to 256 Kbytes. The ring buffer for PCI pass-thru devices
> > is used for only a few messages during device setup and removal, so any
> > space above a few Kbytes is wasted.
> >
> > Fix this by declaring the ring buffer size to be a fixed 16 Kbytes.
> > Furthermore, use the VMBUS_RING_SIZE() macro so that the ring buffer
> > header is properly accounted for, and so the size is rounded up to a
> > page boundary, using the page size for which the kernel is built. While
> > w/64 Kbyte pages this results in a 64 Kbyte ring buffer header plus a
> > 64 Kbyte ring buffer, that's the smallest possible with that page size.
> > It's still 128 Kbytes better than the current code.
> >
> > Cc: <stable@vger.kernel.org> # 5.15.x
> > Signed-off-by: Michael Kelley <mhklinux@outlook.com>
> > Reviewed-by: Kuppuswamy Sathyanarayanan
> <sathyanarayanan.kuppuswamy@linux.intel.com>
> > ---
> > Changes in v2:
> > * Use SZ_16K instead of 16 * 1024
> > ---
> >  drivers/pci/controller/pci-hyperv.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/pci/controller/pci-hyperv.c b/drivers/pci/controll=
er/pci-
> hyperv.c
> > index 1eaffff40b8d..baadc1e5090e 100644
> > --- a/drivers/pci/controller/pci-hyperv.c
> > +++ b/drivers/pci/controller/pci-hyperv.c
> > @@ -465,7 +465,7 @@ struct pci_eject_response {
> >  	u32 status;
> >  } __packed;
> >
> > -static int pci_ring_size =3D (4 * PAGE_SIZE);
> > +static int pci_ring_size =3D VMBUS_RING_SIZE(SZ_16K);
> >
> >  /*
> >   * Driver specific state.
> >
>=20
> Hi,
>=20
> You forgot to add #include <linux/sizes.h> for it.
>=20
> With that fixed:
>=20
> Reviewed-by: Ilpo J=E4rvinen <ilpo.jarvinen@linux.intel.com>
>=20

Fixed in v3.  I mis-interpreted your previous comment about
adding the #include "if needed".  It's not needed to compile
correctly, as sizes.h is indirectly included through some other
#include.  But it's better to directly #include what's needed
lest some unrelated change cause a failure.

Michael