Received-SPF: pass (google.com: domain of linux-kernel+bounces-69330-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Fri, 16 Feb 2024 12:46:45 -0800
From: Dan Williams <dan.j.williams@intel.com>
To: Tom Lendacky <thomas.lendacky@amd.com>, Dan Williams
	<dan.j.williams@intel.com>, <linux-kernel@vger.kernel.org>, <x86@kernel.org>
CC: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>, Dave Hansen <dave.hansen@linux.intel.com>,
	"H. Peter Anvin" <hpa@zytor.com>, Andy Lutomirski <luto@kernel.org>, "Peter
 Zijlstra" <peterz@infradead.org>, Michael Roth <michael.roth@amd.com>, Ashish
 Kalra <ashish.kalra@amd.com>
Subject: Re: [PATCH 10/11] x86/sev: Extend the config-fs attestation support
 for an SVSM
Message-ID: <65cfc9b581b4_5e9bf2941d@dwillia2-xfh.jf.intel.com.notmuch>
References: <cover.1706307364.git.thomas.lendacky@amd.com>
 <10637f104d1ed7f21e281a4890f2c549d1e85985.1706307364.git.thomas.lendacky@amd.com>
 <65bc95732df26_65b2629448@dwillia2-mobl3.amr.corp.intel.com.notmuch>
 <afabdd17-7f1e-4d8c-a7c2-dbbbb230fccf@amd.com>
 <65cad52616ffa_29b129412@dwillia2-mobl3.amr.corp.intel.com.notmuch>
 <ed3d8b93-2631-45fb-dd9d-69a97a9338a7@amd.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <ed3d8b93-2631-45fb-dd9d-69a97a9338a7@amd.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?KkFE3Sjss0RUz4DVHfiOPXiVGoi33GGsgIs3Ep5iiMBYfmOatyJgoK61Bu1O?=
 =?us-ascii?Q?moigUZhvbcXNvYfQkgD47nts0j93p50tvkCeduptxZkHB5krEm68W2gv8DA6?=
 =?us-ascii?Q?qJLanE68W/1QETXJuGspO6c9FQ22K5k2YRjQ7/EYgV5ngtFZ7aXCEtJ4HULU?=
 =?us-ascii?Q?ctWkVb76yYtQexNQebMwl8v224z5ycCaWQATHSntjXjUwgGcCHijHRH1htPD?=
 =?us-ascii?Q?kmdusb0NgLR5AgeKwSTVjBgRT81e8S791PSyZ0hadSgbd3y1q75fO2/Ex+co?=
 =?us-ascii?Q?tLjcUIlF/kVo8LcgX8OcM9jRl89RG3hOk30SZQtuYPgDi5Z1zSIuI6QBcQzW?=
 =?us-ascii?Q?KNHuUbl8L4ew8NyXTh7g3TaPbRgCpFtLhp5Jg3fkKwTfOzGsg5d0xOWJbm76?=
 =?us-ascii?Q?npKPEQbDygW4S2ABCaVAszVUj1nHQoScr1X0nE3G8VI1p9WSIlf88ICqzSNR?=
 =?us-ascii?Q?hrIoBJ01nkom9REo42m0CZ6abtCHZyjqtfmx1J98gZbujQBzBEIwMkeL9h+j?=
 =?us-ascii?Q?/bP9QjWdf8RRVL65YOXmNDP2GaZtcGK4EbmbALETBQJewpx8hpbV/HTu+P6f?=
 =?us-ascii?Q?XFLBb0ov1Z4d9oyIXPhlhNQF3WrZkrlrk/Ey02+bfYcQgCcT8Y2QROsVwm8a?=
 =?us-ascii?Q?XUltKpvSZ+Tg3FYQPI0766xaAo029Yavko6c2Wa/MA7FyVvA27Uj03dLrhVI?=
 =?us-ascii?Q?h7JeZr7gyZShGUDNMlZI/szLAhOg72bTCnuuCQNbqr/Fnui4nCcwrWkXL+9W?=
 =?us-ascii?Q?cypKFC6ffvqH9OYhMp5g1Y7EIfRPmEB7aN2N+4yYmzWewlj8g5o2/vvDChgx?=
 =?us-ascii?Q?erTNXhU5bjOYMseZrAQRbuwwb1AtR09TaTfwmkx9gptHI9vYuOhgmI/+XdxG?=
 =?us-ascii?Q?1NBAqIc55mtkL6syNCbG+rsasBZ1ucg1Q3z+gb2N8e58XYVz+vZZVGwKXvun?=
 =?us-ascii?Q?MJmUEG1pFPpmt3dTRfMC6Ylex+y6T3AMt+6uFq1v8J9+/l3pLmTlXzjo8ws1?=
 =?us-ascii?Q?tPx7pJrZ6wx9V5h//V/H0t7SCzU7DT2pZilGM+wye7wJAmuC4j68n82+dZa7?=
 =?us-ascii?Q?qwqDAhK5J2MUzNgrRjMM/e+TK6LwH5a6TVKEFW9XhwFfwJyjrWq1e47tjIgn?=
 =?us-ascii?Q?zfsMOKd1HuaSaOV4Zl8jS3nSbb+YwPQgKaKl2oGBBp7aZMpbW37ufpADqfO0?=
 =?us-ascii?Q?jlUUnykFLUTgcsuU43u1UDlIhkF6Jcxd6aU/M8Xe8oAq/icmSN/qJaKfnZOc?=
 =?us-ascii?Q?XqV2nkRbo+Vm+dvngV6zuUKQ0QbbRpjovMBtlGX3Qb/qaLT0hI0lcPrU+1U1?=
 =?us-ascii?Q?JdqHhnEUiOqqDu0zxNfC2lT4SsONTZMHlozW8ToozAohWyQiJTDshgcXZ04G?=
 =?us-ascii?Q?NRSvx9mERk2E6zaiaH/i2xM064MMg/7AmxQGjmh8f/yh3+//UyXtTNuHK3me?=
 =?us-ascii?Q?LT/Eiy3nD9Pg+pOd35Jd1G0rWMS4EgBzWYfjq4DUMpkBfcfZfZqYta7bxJ/V?=
 =?us-ascii?Q?YPnn8UOWiyL15MS04jjVb57FiYA/svfLXn9CQNPZpa1DOJDr4JGBtLEtG+6T?=
 =?us-ascii?Q?tDzR8qK13NMU5lQ7RUEvz6I/LYwujcFLlglhuZGO+NB8nyxrJmZeAZUL3M57?=
 =?us-ascii?Q?nA=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 81095728-ae51-4c59-2ad3-08dc2f3064bb
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2024 20:46:47.6297
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TYKVtXxM7nHYTuBNv/CmnvWWTdvXN1QdKQL2AFGzUCnqH1awQQKyNGR1uK76qLCMKG6qdQNH/s1qvlTfZhzNCLydMjPN4Hqfkh27wD9Rm/M=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB6924
X-OriginatorOrg: intel.com

Tom Lendacky wrote:
[..]
> > If it is the same format, and the input is user controlled then I am
> > confused what the new ABI is selecting? Could it not be inferred by
> > privlevel?
> 
> The new ABI selects whether to go through the SVSM to get the attestation
> report, which will additionally return a manifest that, along with the
> nonce, has become part of the report through hashing.

Ah yeah, that's a lot to overlead to the meaning of privlevel.

> 
> But, yes, I mentioned in a previous reply [1] that we could use privlevel
> to determine whether to invoke attestation through an SVSM request or
> through the standard method of issuing an extended guest request.
> 
> [1] https://lore.kernel.org/lkml/3fca61f2-6fe0-4431-818e-9c7b96c6a391@amd.com/

Missed that, thanks. Lets keep explicit as you have it and not overload
privlevel.

[..]
> > Can the version be made to not matter, or be inferred by the presence of
> > a new enumerated service capability? For example, make the same compat
> > guarantees that ACPI methods do between versions where extensions are
> > optional and software can always use v1 without breaking? Otherwise, I
> > am not grokking what software should do with this version.
> 
> Software can always use v1. The idea is that if a service wanted to
> provide additional information or change the information provided in the
> service manifest, then it would have to do that via a new version of its
> manifest so as not to break existing users. By default, zero would be used
> for the service manifest version and have to be updated by the user if
> they wanted a different one.

Can it just be the case the manifest can only grow but old fields never
change? Then software can determine the "version" based on manifest size
and no software gets built with an explicit version check, and is
instead built to understand a certain point in the evolution of the
manifest.

To be clear this is my standard response to any specification that
transmits a payload that "may change in the future", if it is an
awkward fit in this case it would at least be good to clarify why.

> > Separately, is this a version for the service protocol or a version of
> > the manifest format? The description makes it sound like the latter, but
> > the "service_version" name makes it sound like the former.
> 
> Correct, it is for the manifest version. I can rename it to
> service_manifest or service_manifest_version. I'd rather not rename it to
> manifest_version since it is specific to an individual service.

FWIW, service_manifest_version makes it crystal clear to me, but maybe
even better would be that the output size already conveys that, this
attribute is not needed, and userspace reads as much of the manifest as
it knows about.